Re: [PATCH 02/13] xmlrpc: Bump version
On 20 Sep 14:32, Daniel Axtens wrote:
> Stephen Finucane writes:
>
> > This should have been bumped with 'c547dc7'.
> What's c547dc7?
> Git log says:
>
> Fixes: c547dc77d602 ("xmlrpc: fix max_count for check_list")
Yup - that wasn't so much a fix as a new feature (I don't think that
resource ever supported negative indexing), thus, a new version was
needed.
> > +History:
> > +
> > +1.0.0: Patchwork 1.0 release
> > +1.1.0: ???
> > +1.2.0: ???
> > +1.3.0: Add support for negative indexing of Checks
> >
> I'm a bit weak on sematic versioning - is there any reason this isn't
> 1.2.1?
So if we used semver, then this would still be a MINOR version bump:
MINOR version when you add functionality in a backwards-compatible
manner
(from the semver website [1]). However, in my experience APIs don't
tend to use semantic version so I think we can ignore that.
[1] http://semver.org/
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
Re: [PATCH 02/13] xmlrpc: Bump version
Stephen Finucane writes:
> This should have been bumped with 'c547dc7'.
What's c547dc7?
Git log says:
Fixes: c547dc77d602 ("xmlrpc: fix max_count for check_list")
> +History:
> +
> +1.0.0: Patchwork 1.0 release
> +1.1.0: ???
> +1.2.0: ???
> +1.3.0: Add support for negative indexing of Checks
>
I'm a bit weak on sematic versioning - is there any reason this isn't
1.2.1?
Regards,
Daniel
signature.asc
Description: PGP signature
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
[PATCH 02/13] xmlrpc: Bump version
This should have been bumped with 'c547dc7'. Signed-off-by: Stephen Finucane --- patchwork/views/xmlrpc.py | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/patchwork/views/xmlrpc.py b/patchwork/views/xmlrpc.py index 342ceca..8f950a6 100644 --- a/patchwork/views/xmlrpc.py +++ b/patchwork/views/xmlrpc.py @@ -389,10 +389,17 @@ def pw_rpc_version(): recommended that one first test the API version for compatibility before making method calls. +History: + +1.0.0: Patchwork 1.0 release +1.1.0: ??? +1.2.0: ??? +1.3.0: Add support for negative indexing of Checks + Returns: Version of the API. """ -return (1, 2, 0) +return (1, 3, 0) @xmlrpc_method() -- 2.7.4 ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
