Re: [PATCH 04/13] trivial: Don't shadow built-ins

On 20 Sep 14:47, Daniel Axtens wrote: > I haven't read through every single litte one of the changes, but I'm > behind the concept. If it passes the tests, I'm pretty happy. > > Reviewed-by: Daniel Axtens Thanks. Merged. ___ Patchwork

Re: [PATCH 04/13] trivial: Don't shadow built-ins

I haven't read through every single litte one of the changes, but I'm behind the concept. If it passes the tests, I'm pretty happy. Reviewed-by: Daniel Axtens Regards, Daniel Stephen Finucane writes: > * Don't use 'str', 'id', 'max', etc. as

[PATCH 04/13] trivial: Don't shadow built-ins

* Don't use 'str', 'id', 'max', etc. as variable names * Remove unnecessary use of six.range * Remove unnecessary use of six.map There is one paramter in xmlrpc that cannot be renamed as it could break some client code. noqa this instead. Signed-off-by: Stephen Finucane