Re: [PATCH 05/13] trivial: Remove broad exceptions where possible

2016-09-24 Thread Stephen Finucane
On 23 Sep 10:54, Daniel Axtens wrote: > Hi Stephen, > > I've had a quick look at the patches labelled trivial. > > For those patches en bloc: > Reviewed-by: Daniel Axtens Thanks for the reviews. Merged. ___ Patchwork mailing list Patchwork@lists.ozlab

Re: [PATCH 05/13] trivial: Remove broad exceptions where possible

2016-09-22 Thread Daniel Axtens
Hi Stephen, I've had a quick look at the patches labelled trivial. For those patches en bloc: Reviewed-by: Daniel Axtens Regards, Daniel Stephen Finucane writes: > The are two somewhat significant changes: > > * The behavior of 'Bundle.add_patch' is changed. Previously this would > raise a

[PATCH 05/13] trivial: Remove broad exceptions where possible

2016-09-19 Thread Stephen Finucane
The are two somewhat significant changes: * The behavior of 'Bundle.add_patch' is changed. Previously this would raise an exception if the provided patch already existed in the bundle. Since this code was only used in one location, change this to return the BundlePatch if valid else None and