Re: [PATCH 3/7] REST: Use ModelMultipleChoiceField

2018-05-09 Thread Daniel Axtens
Stephen Finucane writes: > On Wed, 2018-05-09 at 01:45 +1000, Daniel Axtens wrote: >> Stephen Finucane writes: >> >> Some comments below. >> >> > We use a modified version of this that allows us to query on multiple >> > fields. >> >> I think you're trying to say that we use a modified versio

Re: [PATCH 3/7] REST: Use ModelMultipleChoiceField

2018-05-08 Thread Stephen Finucane
On Wed, 2018-05-09 at 01:45 +1000, Daniel Axtens wrote: > Stephen Finucane writes: > > Some comments below. > > > We use a modified version of this that allows us to query on multiple > > fields. > > I think you're trying to say that we use a modified version of Django's > ModelMultipleChoiceFi

Re: [PATCH 3/7] REST: Use ModelMultipleChoiceField

2018-05-08 Thread Daniel Axtens
Stephen Finucane writes: Some comments below. > We use a modified version of this that allows us to query on multiple > fields. I think you're trying to say that we use a modified version of Django's ModelMultipleChoiceField? but I'm not sure if "this that" refers to something else. > > Signed

[PATCH 3/7] REST: Use ModelMultipleChoiceField

2018-04-11 Thread Stephen Finucane
We use a modified version of this that allows us to query on multiple fields. Signed-off-by: Stephen Finucane Fixes: #156 --- patchwork/api/filters.py | 103 - patchwork/tests/api/test_patch.py | 15 ++- .../improved-rest-filtering-