Re: [PATCH v3 4/5] tools: Trivial formatting fixes

2017-12-19 Thread Tom Rini
On Thu, Dec 01, 2016 at 09:46:51AM +, Stephen Finucane wrote: > These tools are currently broken, but before beginning surgery let's > clean things up. Use standard 4 spaces and the longer, but easier to > read, if-else-fi syntax for comparison. > > Missing license headers are added for compl

Re: [PATCH v3 4/5] tools: Trivial formatting fixes

2016-12-02 Thread Stephen Finucane
On Fri, 2016-12-02 at 15:44 +1100, Daniel Axtens wrote: > Hi Stephen, > > While you're on a cleaning fix, may I suggest shellcheck.net? No > pressure :) Again, merged as is just to fix the bug, but shellcheck looks good an I'll submit a patch shortly to finish the cleanup here. Good call on the t

Re: [PATCH v3 4/5] tools: Trivial formatting fixes

2016-12-01 Thread Daniel Axtens
Hi Stephen, While you're on a cleaning fix, may I suggest shellcheck.net? No pressure :) Regards, Daniel Stephen Finucane writes: > These tools are currently broken, but before beginning surgery let's > clean things up. Use standard 4 spaces and the longer, but easier to > read, if-else-fi syn

[PATCH v3 4/5] tools: Trivial formatting fixes

2016-12-01 Thread Stephen Finucane
These tools are currently broken, but before beginning surgery let's clean things up. Use standard 4 spaces and the longer, but easier to read, if-else-fi syntax for comparison. Missing license headers are added for completeness sake. Signed-off-by: Stephen Finucane Cc: Paul Jakma Cc: Tom Rini