Re: [PATCH 1/5] models: Make use of aggregates

2016-10-13 Thread Stephen Finucane
On 2016-10-12 23:13, Daniel Axtens wrote: Hi Stephen, -if len(orders) > 0: -max_order = orders[0]['order'] +if orders and orders['order__max']: +max_order = orders['order__max'] + 1 else: -max_order = 0 +max_order = 1 I'

Re: [PATCH 1/5] models: Make use of aggregates

2016-10-12 Thread Daniel Axtens
Hi Stephen, > -if len(orders) > 0: > -max_order = orders[0]['order'] > +if orders and orders['order__max']: > +max_order = orders['order__max'] + 1 > else: > -max_order = 0 > +max_order = 1 > I'm not super happy with the ch