Re: [PATCH v3 5/5] tools: Update to use 'hasher'

2017-12-19 Thread Tom Rini
On Thu, Dec 01, 2016 at 09:46:52AM +, Stephen Finucane wrote: > The old 'parser' module used to extract diffs from their surrounding > mbox fluff before hashing this. Seeing as this was only used in the > context of an actual git repo, avoid all of that rigmarole by just using > 'git diff', whi

Re: [PATCH v3 5/5] tools: Update to use 'hasher'

2016-12-02 Thread Stephen Finucane
On Fri, 2016-12-02 at 15:42 +1100, Daniel Axtens wrote: > Hi, > > >  local hash > > -hash=$(git show -C $1 | python $PWDIR/parser.py --hash) > > +hash=$(git diff "$1~..$1" | python $pwpath/hasher.py) That's a good point - I don't think the existing code handled merge commits and neith

Re: [PATCH v3 5/5] tools: Update to use 'hasher'

2016-12-01 Thread Daniel Axtens
Hi, > local hash > -hash=$(git show -C $1 | python $PWDIR/parser.py --hash) > +hash=$(git diff "$1~..$1" | python $pwpath/hasher.py) Does this function appropriately in the presence of merge commits? ISTR they had interesting behaviour and there was a difference between using ~ and u