Re: Wrong message order in patch view
Hi Stephen, > > I found interesting bug in patch view: messages are in wrong order. > > #5 should be actually before #4. > It looks like the emails themselves were incorrect. > #5, which was really #4, is dated [1]: > Wed Mar 25 00:35:51 CET 2020 > #4, which was really #5, is dated [2]: > Tue Mar 24 19:07:39 CET 2020 > Patchwork is simply sorting things by date - it doesn't thread replies > - so this is working as intended. We could investigate threading emails > in the comment view but that's an RFE more so than a bugfix. > I imagine either you or Cyril probably need to fix your MUA :) Thanks for investigating it. I'm sorry, as I wrote it was a configuration problem on Cyril's side (wrong time set, result of testing his time namespace patches tests :)). I didn't expect such issue, I'll check it on our side before reporting to you next time. Kind regards, Petr ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Wrong message order in patch view
Hi Aaron, > Check message arrival time compared to modification time. Contrary to > popular belief that doesn’t mean the message was altered necessarily. I m > not trying to start a flame war re specifications and when SHOULD becomes > MUST, but there are valid reasons. You're right, one of the developers has set wrong date on his machine (1 day ahead), so he's sending messages from the future: Wed Mar 25 18:07:40 CET 2020. A bit confusing, because mailman which uses threads sort displays it correctly. Sorry for bothering with this issue. Kind regards, Petr ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Wrong message order in patch view
On Tue, 2020-03-24 at 19:15 +0100, Petr Vorel wrote: > Hi, > > I found interesting bug in patch view: messages are in wrong order. > #5 should be actually before #4. It looks like the emails themselves were incorrect. #5, which was really #4, is dated [1]: Wed Mar 25 00:35:51 CET 2020 #4, which was really #5, is dated [2]: Tue Mar 24 19:07:39 CET 2020 Patchwork is simply sorting things by date - it doesn't thread replies - so this is working as intended. We could investigate threading emails in the comment view but that's an RFE more so than a bugfix. I imagine either you or Cyril probably need to fix your MUA :) Stephen [1] http://lists.linux.it/pipermail/ltp/2020-March/016229.html [2] http://lists.linux.it/pipermail/ltp/2020-March/016234.html > Nothing critical for me, but worth enough to report it. > > Kind regards, > Petr > > [1] https://patchwork.ozlabs.org/patch/1260343/ ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Wrong message order in patch view
Check message arrival time compared to modification time. Contrary to popular belief that doesn’t mean the message was altered necessarily. I m not trying to start a flame war re specifications and when SHOULD becomes MUST, but there are valid reasons. Aaron S. Kaufman, Esq. 353 Veterans Memorial Highway Suite 210 Commack NY 11725 (631)-366-2172 (w) (631)-366-1718 (fax) (631)-422-1650 (h) (646)-488-9488 (c) aa...@aaronskaufman.com > On Mar 24, 2020, at 2:33 PM, Petr Vorel wrote: > > Hi, > > I found interesting bug in patch view: messages are in wrong order. > #5 should be actually before #4. > > Nothing critical for me, but worth enough to report it. > > Kind regards, > Petr > > [1] https://patchwork.ozlabs.org/patch/1260343/ > ___ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork