Hi Dhruv, Thank you for the message, the -11 is now uploaded.
It’s strange that I did not receive these review and response… let me try to figure out the problem. Best wishes, Haomian 发件人: Dhruv Dhody [mailto:dhruv.i...@gmail.com] 发送时间: 2022年10月24日 14:49 收件人: Zhenghaomian <zhenghaom...@huawei.com> 抄送: Erik Kline <ek.i...@gmail.com>; draft-ietf-pce-vn-associat...@ietf.org; pce@ietf.org; The IESG <i...@ietf.org>; pce-cha...@ietf.org; Hariharan Ananthakrishnan <h...@netflix.com>; Dhruv Dhody <d...@dhruvdhody.com> 主题: Re: [Pce] Erik Kline's No Objection on draft-ietf-pce-vn-association-09: (with COMMENT) Hi Haomian, Can you make the suggested change in the below email (that Erik agreed to) instead of "//" for the length. The reason -> the Length field's value is variable, but its size is 16 bits! Thanks! Dhruv On Tue, Oct 18, 2022 at 1:02 AM Dhruv Dhody <d...@dhruvdhody.com<mailto:d...@dhruvdhody.com>> wrote: Hi Erik, Thanks for your review, see inline... On Sun, Oct 16, 2022 at 11:23 AM Erik Kline via Datatracker <nore...@ietf.org<mailto:nore...@ietf.org>> wrote: Erik Kline has entered the following ballot position for draft-ietf-pce-vn-association-09: No Objection When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-pce-vn-association/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- # Internet AD comments for {draft-ietf-pce-vn-association-09} CC @ekline ## Comments ### S4 * The format layout diagram, Figure 2, states that Length is variable, as does the text that follows it, but the use of the "|" at the end of the first word implied to me that it was actually a 16-bit integer. Perhaps change the end of this line to just be "//" or something? Alternatively, if this field is actually a 16-bit integer then I suggest clarifying the text that says it's "variable". I suggest this change - OLD: Type: TBD2 (to be allocated by IANA) Length: Variable Length, which covers the value portion of the TLV. NEW: Type (16-bits): TBD2 (to be allocated by IANA) Length (16-bits): indicates the length of the value portion of the TLV in octets and MUST be greater than 0. The TLV MUST be zero- padded so that the TLV is 4-octet aligned. END * Related: what should an implementation do if the length of the VN is zero? We can add - If a PCEP speaker receives a VN ASSOCIATION object with a TLV that violates the rules specified in this document, then the PCEP speaker MUST send a PCErr message with Error-Type = 10 (Reception of an invalid object) and Error-value = 11 (Malformed object) and MUST close the PCEP session. Thanks! Dhruv _______________________________________________ Pce mailing list Pce@ietf.org<mailto:Pce@ietf.org> https://www.ietf.org/mailman/listinfo/pce
_______________________________________________ Pce mailing list Pce@ietf.org https://www.ietf.org/mailman/listinfo/pce
