Re: [pcre-dev] A problem with config.h.generic

2012-12-08 Thread Philip Hazel
On Fri, 7 Dec 2012, Graycode wrote: I vote for (b) with the presumption that the PCRE code honors the defined/undefined specifications. For example, when the file says: /* Define to any value to enable the 16 bit PCRE library. */ /* #undef SUPPORT_PCRE16 */ then any value should not be

Re: [pcre-dev] A problem with config.h.generic

2012-12-08 Thread Ralf Junker
On 08.12.2012 13:23, Philip Hazel wrote: There seems to be general support for (b) so far, so I will proceed with arranging for suitable comments to end up in the code. What do people think about the added lines such as these: /* Define to 1 if you have the stdint.h header file. */ #ifndef

Re: [pcre-dev] A problem with config.h.generic

2012-12-08 Thread Philip Hazel
On Sat, 8 Dec 2012, Ralf Junker wrote: I very much like to keep this version because it allows to override config.h on the command line via the -D switch: -DHAVE_STDINT_H=0 which will not work! The reason is that all of the checks in the code are of the form #ifdef HAVE_STDINT_H

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-08 Thread Philip Hazel
On Thu, 6 Dec 2012, Daniel Richard G. wrote: On Thu, 6 Dec 2012, Graycode wrote: Yet the CMakeLists.txt file currently contains: IF(MSVC) ADD_DEFINITIONS(-D_CRT_SECURE_NO_DEPRECATE) ENDIF(MSVC) I'm not a Cmake user, but that seems a more appropriate place for settings

Re: [pcre-dev] A problem with config.h.generic

2012-12-08 Thread Graycode
On Sat, 8 Dec 2012, Philip Hazel wrote: On Sat, 8 Dec 2012, Ralf Junker wrote: I very much like to keep this version because it allows to override config.h on the command line via the -D switch: -DHAVE_STDINT_H=0 which will not work! The reason is that all of the checks in the

Re: [pcre-dev] A problem with config.h.generic

2012-12-08 Thread zatlas1
Agree , b seems to be the way to go za Connected by DROID on Verizon Wireless -Original message- From: Philip Hazel p...@hermes.cam.ac.uk To: Graycode xgc...@gmail.com Cc: pcre-dev@exim.org Sent: Sat, Dec 8, 2012 12:23:31 GMT+00:00 Subject: Re: [pcre-dev] A problem with

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-08 Thread Zoltán Herczeg
Thank you, Philip. Daniel, please test the current code, and let me know if any other issues remain. Regards, Zoltan Philip Hazel p...@hermes.cam.ac.uk írta: On Thu, 6 Dec 2012, Daniel Richard G. wrote: On Thu, 6 Dec 2012, Graycode wrote: Yet the CMakeLists.txt file currently contains: