Re: [pcre-dev] pcre_compile.c: error_texts

2012-12-31 Thread Zoltán Herczeg
Hi Arpe, thanks for your suggestion! Just my two cents: the reason of the search is that it shouldn't be a bottleneck. I suspect it takes less than 1% of the total compilation time, although I never really measured it. I think before we jump to coding, we should measure it somehow. I wouldn't

Re: [pcre-dev] pcre_compile.c: error_texts

2012-12-31 Thread Philip Hazel
On Mon, 31 Dec 2012, Zoltán Herczeg wrote: Alternatively, we can simply use something like: static char* error_texts[] = { text1, text2, ... }; error_texts[i] would return with the text corresponding to error code. Isn't that what we are trying to avoid? I suspect that is what it used to be