Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-19 Thread Ævar Arnfjörð Bjarmason via Pcre-dev
On Tue, Apr 18, 2017 at 10:09 AM, Zoltán Herczeg wrote: I.e. no difference in v1 & v2 anymore. The log case though shows pcre1 being 2% faster than pcre2: > > I don't know the reason then, needs more investigation. Btw I have started to > improve the first character

Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-18 Thread Zoltán Herczeg
>>>I.e. no difference in v1 & v2 anymore. The log case though shows pcre1 >>>being 2% faster than pcre2: I don't know the reason then, needs more investigation. Btw I have started to improve the first character search optimization in JIT. It is still in progress (corner cases), although you can

Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-13 Thread Ævar Arnfjörð Bjarmason via Pcre-dev
On Thu, Apr 13, 2017 at 8:51 AM, Zoltán Herczeg wrote: > Hi, > I did some basic performance benchmarks between v1 and v2 of PCRE. Depending on whether we use git-grep or git-log v2 is 1% to 10% slower than v1 when both use JIT. >>> >>> I would like to see the

Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-13 Thread Zoltán Herczeg
Hi, >JIT is enabled in Debian on pcre builds for some architectures (roughly, >those where it's believed to work ;-) ). It was true in old-pcre (Debian >calls this pcre3) at the point I took over looking after pcre for >Debian, and so I made it so for pcre2 also. This is great news indeed! The

Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-12 Thread Matthew Vernon
On 12/04/17 06:10, Zoltán Herczeg wrote: [apropos Debian pcre packages] >> I couldn't find out how to get the compile flags for those, but >> presumably it's some comparable middle-of-the-road value, probably >> -O2. I'll try compiling from svn & report back. > > Likely -O2. I am surprised that

Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-12 Thread Ævar Arnfjörð Bjarmason via Pcre-dev
On Mon, Apr 10, 2017 at 4:13 PM, Zoltán Herczeg wrote: > Hi Ævar, > > this is really awesome news! I am happy that you choose pcre for git. > >>I did some basic performance benchmarks between v1 and v2 of PCRE. >>Depending on whether we use git-grep or git-log v2 is 1% to

Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-11 Thread Zoltán Herczeg
Hi, >I couldn't find out how to get the compile flags for those, but >presumably it's some comparable middle-of-the-road value, probably >-O2. I'll try compiling from svn & report back. Likely -O2. I am surprised that JIT is enabled in default builds. I am sure it wasn't in the past. >> This

Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-11 Thread Ævar Arnfjörð Bjarmason via Pcre-dev
On Mon, Apr 10, 2017 at 4:13 PM, Zoltán Herczeg wrote: > Hi Ævar, > > this is really awesome news! I am happy that you choose pcre for git. > >>I did some basic performance benchmarks between v1 and v2 of PCRE. >>Depending on whether we use git-grep or git-log v2 is 1% to

Re: [pcre-dev] I'm adding PCRE v2 support to Git. It's a bit slower than v1

2017-04-10 Thread Zoltán Herczeg
Hi Ævar, this is really awesome news! I am happy that you choose pcre for git. >I did some basic performance benchmarks between v1 and v2 of PCRE. >Depending on whether we use git-grep or git-log v2 is 1% to 10% slower >than v1 when both use JIT. I would like to see the compilation flags for