Re: [PD-dev] status of verbose() in 0.43?

2011-03-09 Thread Hans-Christoph Steiner
Ok, finally, its all cooked into a nice, decently-tested series of patches against the HEAD of master. This patch set completes a set of inter-related things related to the Pd window and the logging functions. I think you'll find it a huge improvement. It is a combo of work that IOhannes

Re: [PD-dev] status of verbose() in 0.43?

2011-03-08 Thread Miller Puckette
Hi all, Sorry to reopen this old thread -- I think there's a more recent message from HC but I can't find it right now. I wonder if, in the interest of putting 0.43 out, we should just hide the verbosity level control and let all printout through for 0.43, then try to figure out how to do this

Re: [PD-dev] status of verbose() in 0.43?

2011-03-08 Thread Hans-Christoph Steiner
I agree that there should only be one set of levels, that would just mean removing the +4 from two places, and it would be that way. Tomorrow morning I can complete a patch for 0.43 based on a tested and debugged version of all this that I have mostly in the pd-extended.git patch_series

Re: [PD-dev] status of verbose() in 0.43?

2011-02-24 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-23 21:52, Hans-Christoph Steiner wrote: It seems to me the way to really do this would be to have post() and logpost() find out the calling object instance on its own, if that's possible. Then it would automatically apply to all

Re: [PD-dev] status of verbose() in 0.43?

2011-02-23 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-22 23:26, Hans-Christoph Steiner wrote: This would be very nice, I could see being about to double-click any line in the log and have it pop up which object made the log message. I won't have time to implement this in the foreseeable

Re: [PD-dev] status of verbose() in 0.43?

2011-02-23 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-23 09:05, IOhannes m zmoelnig wrote: On 2011-02-22 23:26, Hans-Christoph Steiner wrote: This would be very nice, I could see being about to double-click any line in the log and have it pop up which object made the log message. I

Re: [PD-dev] status of verbose() in 0.43?

2011-02-23 Thread Hans-Christoph Steiner
On Feb 23, 2011, at 5:38 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-23 09:05, IOhannes m zmoelnig wrote: On 2011-02-22 23:26, Hans-Christoph Steiner wrote: This would be very nice, I could see being about to double-click any line in the log and

Re: [PD-dev] status of verbose() in 0.43?

2011-02-23 Thread Hans-Christoph Steiner
On Feb 23, 2011, at 5:38 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-23 09:05, IOhannes m zmoelnig wrote: On 2011-02-22 23:26, Hans-Christoph Steiner wrote: This would be very nice, I could see being about to double-click any line in the log and

Re: [PD-dev] status of verbose() in 0.43?

2011-02-23 Thread Hans-Christoph Steiner
On Feb 23, 2011, at 5:50 PM, Hans-Christoph Steiner wrote: On Feb 23, 2011, at 5:38 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-23 09:05, IOhannes m zmoelnig wrote: On 2011-02-22 23:26, Hans-Christoph Steiner wrote: This would be very nice, I

Re: [PD-dev] status of verbose() in 0.43?

2011-02-22 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-22 07:32, Hans-Christoph Steiner wrote: So how about this: - keep verbose() as it is - add logpost(level, message) to both Tcl and C - change ::pdwindow::post to mirror the C post() i.e. remove level - remove ::pdwindow::fatal,

Re: [PD-dev] status of verbose() in 0.43?

2011-02-22 Thread Hans-Christoph Steiner
On Tue, 2011-02-22 at 09:17 +0100, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-22 07:32, Hans-Christoph Steiner wrote: So how about this: - keep verbose() as it is - add logpost(level, message) to both Tcl and C - change ::pdwindow::post to

Re: [PD-dev] status of verbose() in 0.43?

2011-02-21 Thread Hans-Christoph Steiner
On Feb 16, 2011, at 4:26 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-16 04:53, Hans-Christoph Steiner wrote: Do you remember why those incr 4 and level+4 are there to begin yes, so that verbose(0, is not the same as error( with? I think

Re: [PD-dev] status of verbose() in 0.43?

2011-02-21 Thread Hans-Christoph Steiner
On Feb 21, 2011, at 5:42 PM, Hans-Christoph Steiner wrote: On Feb 16, 2011, at 4:26 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-16 04:53, Hans-Christoph Steiner wrote: Do you remember why those incr 4 and level+4 are there to begin yes, so

Re: [PD-dev] status of verbose() in 0.43?

2011-02-16 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-16 04:53, Hans-Christoph Steiner wrote: Do you remember why those incr 4 and level+4 are there to begin yes, so that verbose(0, is not the same as error( with? I think removing that is the best solution, the duplication should be

Re: [PD-dev] status of verbose() in 0.43?

2011-02-16 Thread Hans-Christoph Steiner
On Feb 16, 2011, at 4:26 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-16 04:53, Hans-Christoph Steiner wrote: Do you remember why those incr 4 and level+4 are there to begin yes, so that verbose(0, is not the same as error( with? I think

Re: [PD-dev] status of verbose() in 0.43?

2011-02-15 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-15 01:59, Hans-Christoph Steiner wrote: Hmm, this might be the problem, in doverbose(): sys_vgui(::pdwindow::post %d {%s}\n, level+4, strnescape(upbuf, s, MAXPDSTRING)); Why is there level+4? Why not just pass level straight

Re: [PD-dev] status of verbose() in 0.43?

2011-02-15 Thread Hans-Christoph Steiner
On Feb 15, 2011, at 4:04 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-15 01:59, Hans-Christoph Steiner wrote: Hmm, this might be the problem, in doverbose(): sys_vgui(::pdwindow::post %d {%s}\n, level+4, strnescape(upbuf, s, MAXPDSTRING)); Why is

Re: [PD-dev] status of verbose() in 0.43?

2011-02-15 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-02-15 16:15, Hans-Christoph Steiner wrote: I get the ranked levels, that stuff make sense. I am wondering about the algorithm. In both C and Tcl, the verbose() posting is adding 4 to the level value, so that means if people are doing