Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread Michael Gold
On Tue, Jan 27, 2009 at 19:14:35 -0800, ge...@gnu.org wrote: > > > OTOH, I'm really against assertions in code. I consider it a serious > desi= > > gn > > > flaw. > > > > Why? > > They cause the program to abort instead of giving the chance to handle the > error. There's no sensible way to

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread gerel
> Date: Tue, 27 Jan 2009 21:25:48 -0500 > From: Michael Gold > Content-Disposition: inline > > > > We should also verify > > >sizeof(pdf_list_iterator_s) >=3D3D sizeof(gl_list_iterator_t) > > >and sizeof(pdf_hash_iterator_s) >=3D3D sizeof(gl_list_iterator_= > t) > > >

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread Michael Gold
On Tue, Jan 27, 2009 at 16:06:14 -0800, ge...@gnu.org wrote: > > Date: Tue, 27 Jan 2009 16:20:31 -0500 > > From: Michael Gold > > Content-Disposition: inline > > > > They're 56 bytes on x86_64. Since all the struct's values are pointers > > or size_t (which is pointer-sized on x86/x86_64),

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread gerel
> Date: Tue, 27 Jan 2009 16:20:31 -0500 > From: Michael Gold > > We should also verify >sizeof(pdf_list_iterator_s) >=3D sizeof(gl_list_iterator_t) >and sizeof(pdf_hash_iterator_s) >=3D sizeof(gl_list_iterator_t) > BTW, I didn't use sizeof() on gl_list because that way we

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread gerel
> Date: Tue, 27 Jan 2009 16:20:31 -0500 > From: Michael Gold > Content-Disposition: inline > > > On Tue, Jan 27, 2009 at 08:37:08 -0800, ge...@gnu.org wrote: > > Hi hackers, > >=20 > > I attach a patch for stack based iterators, in list and hash modules. > >=20 > > BTW, the current gn

[pdf-devel] [flyspray] pdf-filter should emit a warning when a filter fail

2009-01-27 Thread GNU PDF Library
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#94 - pdf-filter should emit a warning when a filter fail User who did this - Jose E. Marchesi (jemarch) Reason for closing: DONE Additional comments about closing: Implemented and tested. More information can be f

[pdf-devel] [flyspray] Document the usage of opaque pointers in the hackers guide

2009-01-27 Thread GNU PDF Library
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#68 - Document the usage of opaque pointers in the hackers guide User who did this - Jose E. Marchesi (jemarch) Reason for closing: DONE Additional comments about closing: Documentation added to the "Opaque Pointers

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread Michael Gold
On Tue, Jan 27, 2009 at 08:37:08 -0800, ge...@gnu.org wrote: > Hi hackers, > > I attach a patch for stack based iterators, in list and hash modules. > > BTW, the current gnulib iterators are 28 bytes long, correct me if I'm wrong. > I gave 48 bytes to iterators, though this remains open to discu

Re: [pdf-devel] Patch for FS#94 missing warnings in filter utility

2009-01-27 Thread jemarch
Hi gerel. I attach a patch for the task in question. I applied the patch in the trunk after several modifications, since it contained some errors and there was also a bug in pdf_stm_flush: it was not propagating any error from the stream's filter chain, so the pdf_stm_write function was alway

[pdf-devel] [flyspray] Add unit tests for pdf_stm_flush

2009-01-27 Thread GNU PDF Library
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Jose E. Marchesi (jemarch) Attached to Project - GNU PDF Library Summary - Add unit tests for pdf_stm_flush Task Type - Sporadic Task Category - Stream Module Status - NEX

[pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread gerel
Hi hackers, I attach a patch for stack based iterators, in list and hash modules. BTW, the current gnulib iterators are 28 bytes long, correct me if I'm wrong. I gave 48 bytes to iterators, though this remains open to discussion. ## # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id

[pdf-devel] Patch for FS#94 missing warnings in filter utility

2009-01-27 Thread gerel
Hi hackers, I attach a patch for the task in question. ## # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: ge...@gnu.org-20090127141432-ug96eejedyuzhhsp # target_branch: file:///home/gerel/PROJECTS/libgnupdf/trunk/ # testament_sha1: 34dee3b07cc9994647497f38bdcef8c12eb90415 # timest

Re: [pdf-devel] Introduction to PDF

2009-01-27 Thread gerel
> Date: Tue, 27 Jan 2009 13:34:38 +0100 > From: Sylvain Beucler > Content-Disposition: inline > > > Can you try to precise what made you wish for those links? You just said it: > Maybe this would make people feel safer though, since they might mess > the copy/paste or the pdf-filter co

Re: [pdf-devel] Introduction to PDF

2009-01-27 Thread Sylvain Beucler
Hi, > > http://gnupdf.org/Introduction_to_PDF > > Very nice Beuc! > > It would be great if you add the following links to files: > > - Link to the first 'hello world' example. > - Link to the flate encoded stream (so the user/developer can play with the >pdf-utility on his system) Hmm