[pdf-devel] Patch for FS#117

2010-04-18 Thread gerel
Here is a patch for #117, text object and ASCII concat (doc and tests are a gift :-) ). ## # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: ge...@gnu.org-20100419041257-27mlz6ww2gz9khgu # target_branch: file:///home/gerel/PROJECTS/libgnupdf/trunk/ # testament_sha1: a7212288530d544b4

Re: [pdf-devel] Patch for FS#116

2010-04-18 Thread gerel
> Date: Sun, 18 Apr 2010 13:02:32 +0200 (CEST) > From: Jose E. Marchesi > > >/* 0x0100 */ > -if((filter & PDF_TEXT_FILTER_REMOVE_LINE_ENDINGS) && \ > - (pdf_text_filter_remove_line_endings(text) != PDF_OK)) > + if((filter & PDF_TEXT_FILTER_REMOVE_LINE_

Re: [pdf-devel] Patch for FS#114

2010-04-18 Thread gerel
Ok. Here is try 2 :-) ## # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: ge...@gnu.org-20100418215209-0imic49ywr2s6dx9 # target_branch: file:///home/gerel/PROJECTS/libgnupdf/trunk/ # testament_sha1: e23fd060d388ce397f3749dd265260573d26eafb # timestamp: 2010-04-18 18:52:31 -0300 # b

Re: [pdf-devel] Patch for FS#116

2010-04-18 Thread gerel
Here is try 2. Review and apply. ## # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: ge...@gnu.org-20100418214759-c1ho9719elvho1kk # target_branch: file:///home/gerel/PROJECTS/libgnupdf/trunk/ # testament_sha1: ef2e62b091722280c7473af3bcc5769214eadcfb # timestamp: 2010-04-18 18:48:0

Re: [pdf-devel] Patch for FS#115

2010-04-18 Thread gerel
> Date: Sun, 18 Apr 2010 12:59:55 +0200 (CEST) > From: Jose E. Marchesi > > > Instead of making that cast I would create a new inlined static > function: > > bool *pdf_list_element_equals_fn (ELT1, ELT2) > > that would call the user-supplied callback, casting the bool to > pdf_boo

Re: [pdf-devel] Patch for FS#116

2010-04-18 Thread Aleksander Morgado
> /* 0x0100 */ >-if((filter & PDF_TEXT_FILTER_REMOVE_LINE_ENDINGS) && \ >- (pdf_text_filter_remove_line_endings(text) != PDF_OK)) >+ if((filter & PDF_TEXT_FILTER_REMOVE_LINE_ENDINGS) && \ >+ (pdf_text_filter_remove_line_endings(text) != PDF_OK)) > > Please d

Re: [pdf-devel] Patch for FS#116

2010-04-18 Thread Jose E . Marchesi
/* 0x0100 */ -if((filter & PDF_TEXT_FILTER_REMOVE_LINE_ENDINGS) && \ - (pdf_text_filter_remove_line_endings(text) != PDF_OK)) + if((filter & PDF_TEXT_FILTER_REMOVE_LINE_ENDINGS) && \ + (pdf_text_filter_remove_line_endings(text) != PDF_OK)) Please don't wr

Re: [pdf-devel] Patch for FS#115

2010-04-18 Thread Jose E . Marchesi
Here is a patch for FS#115 with casting. If you start working in a task, please set yourself as the asignee of that task and change its status to STARTED. Note that we still need stdbool.h, I guess wa can't get rid of it. It is not a problem to use stdbool's 'bool' type in pdf-list.

Re: [pdf-devel] Patch for FS#114

2010-04-18 Thread Jose E . Marchesi
Hi Gerel. + long cpos; + cpos = ftell(((pdf_fsys_disk_file_t)file->data)->file_descriptor); Please put a blank character between the function names and the parenthesized parameters list. -- Jose E. Marchesi http://www.jemarch.net GNU Project http://ww

Re: [pdf-devel] Patch for FS#107

2010-04-18 Thread Jose E . Marchesi
Hi Gerel. Here is a patch for the task. Also added a little description about the filter utility. Thanks for this content. The manual needs more structure. I saved your patch in Flyspray and I will structure the manual using part of your contribution. -- Jose E. Marchesi

[pdf-devel] New API method in the FileSystem module: pdf_fsys_build_path()

2010-04-18 Thread Aleksander Morgado
Hi all, Still, I've got another request which I believe would be for the FileSystem interface. http://www.gnupdf.org/flyspray/index.php?do=details&task_id=118 Comments welcome! - The idea is to have a method equivalent to GLib's g_build_filename() http://library.gnome.org/devel/glib/unstabl

[pdf-devel] New API method in the Text Module: pdf_text_concat_ascii

2010-04-18 Thread Aleksander Morgado
This is yet another request for the Text Module, to implement a new API method quite useful when playing with text objects. Explained below, and comments are welcome! http://www.gnupdf.org/flyspray/index.php?do=details&task_id=117 New method in the Text Module, to append (concatenate) an AS

Re: [pdf-devel] Patch for FS#116

2010-04-18 Thread Aleksander Morgado
Hey gerel, > Here is a patch for FS#116. New pdf_text_get_printable. > Aleks, tell me if this was what you meant. Just one comment, below. Thanks! > > +const pdf_char_t * > +pdf_text_get_printable (pdf_text_t text) > +{ > + pdf_size_t size; > + > + if (text->printable != NULL){ > +if (te