Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread Michael Gold
On Tue, Jan 27, 2009 at 19:14:35 -0800, ge...@gnu.org wrote: > > > OTOH, I'm really against assertions in code. I consider it a serious > desi= > > gn > > > flaw. > > > > Why? > > They cause the program to abort instead of giving the chance to handle the > error. There's no sensible way to

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread gerel
> Date: Tue, 27 Jan 2009 21:25:48 -0500 > From: Michael Gold > Content-Disposition: inline > > > > We should also verify > > >sizeof(pdf_list_iterator_s) >=3D3D sizeof(gl_list_iterator_t) > > >and sizeof(pdf_hash_iterator_s) >=3D3D sizeof(gl_list_iterator_= > t) > > >

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread Michael Gold
On Tue, Jan 27, 2009 at 16:06:14 -0800, ge...@gnu.org wrote: > > Date: Tue, 27 Jan 2009 16:20:31 -0500 > > From: Michael Gold > > Content-Disposition: inline > > > > They're 56 bytes on x86_64. Since all the struct's values are pointers > > or size_t (which is pointer-sized on x86/x86_64),

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread gerel
> Date: Tue, 27 Jan 2009 16:20:31 -0500 > From: Michael Gold > > We should also verify >sizeof(pdf_list_iterator_s) >=3D sizeof(gl_list_iterator_t) >and sizeof(pdf_hash_iterator_s) >=3D sizeof(gl_list_iterator_t) > BTW, I didn't use sizeof() on gl_list because that way we

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread gerel
> Date: Tue, 27 Jan 2009 16:20:31 -0500 > From: Michael Gold > Content-Disposition: inline > > > On Tue, Jan 27, 2009 at 08:37:08 -0800, ge...@gnu.org wrote: > > Hi hackers, > >=20 > > I attach a patch for stack based iterators, in list and hash modules. > >=20 > > BTW, the current gn

Re: [pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread Michael Gold
On Tue, Jan 27, 2009 at 08:37:08 -0800, ge...@gnu.org wrote: > Hi hackers, > > I attach a patch for stack based iterators, in list and hash modules. > > BTW, the current gnulib iterators are 28 bytes long, correct me if I'm wrong. > I gave 48 bytes to iterators, though this remains open to discu

[pdf-devel] Patch for FS#93 stack based iterators

2009-01-27 Thread gerel
Hi hackers, I attach a patch for stack based iterators, in list and hash modules. BTW, the current gnulib iterators are 28 bytes long, correct me if I'm wrong. I gave 48 bytes to iterators, though this remains open to discussion. ## # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id