Re: [Pdl-devel] pdl complex support

2019-04-21 Thread ingosch
Ed, great, that split helps development, I'm sure. basic complex number support seems to work. Currently, I face two issues: print does not do what i want. it seems to ignore my format. the other is abs. i need to set output type based on input type, i want to cast complex double to double, w

Re: [Pdl-devel] pdl complex support

2019-04-21 Thread Ed .
I don’t have much help to offer for the complex stuff currently, only a couple of thoughts. Looking at the diffs between your branch and master, I see you’re doing lots of interesting things, together with a couple I don’t understand: * There’s no reason for you to change version numbers, l

Re: [Pdl-devel] pdl complex support

2019-04-21 Thread ingosch
yes, i agree with most of what you say. Let me just say that I didn't understand the internals when I started and still don't really in many places. so a lot of the changes were and are trial and error. tests are missing and will come, so will reverting the unnecessary changes. the livstc++ i

Re: [Pdl-devel] pdl complex support

2019-04-21 Thread Ed .
Fair enough on all points! You may find it more convenient to work on this against pdla-core rather than pdl, just because it will build far faster without all the “kitchen-sink” stuff. It’s possible to get your commits over to pdla-core using git but it’s a bit involved. If you’d like me to do