Re: [PECL-DEV] Submit base58 extention to pecl

2018-05-22 Thread Arnold Daniels
Hi Anatol, Thanks a lot. I've made the suggested changes. - I removed the SODIUM references. - For base58_encode I now use zend_string directly. For base58_decode I copy the char* into a zend_string as it has an offset. Also, I have sure I free everything on an error. - I considered returning NUL

Re: [PECL-DEV] Submit base58 extention to pecl

2018-05-19 Thread Anatol Belski
Hi, On Tue, 2018-05-15 at 21:26 +0200, Arnold Daniels wrote: > Hi, > > I'd like to request the submission of a package to PECL. > > We've created a PHP extension for base58 encoding and decoding using > the > Bitcoin alphabet. It's a simple binding to the bitcoin/libbase58 c > library. > > The

[PECL-DEV] Submit base58 extention to pecl

2018-05-15 Thread Arnold Daniels
Hi, I'd like to request the submission of a package to PECL. We've created a PHP extension for base58 encoding and decoding using the Bitcoin alphabet. It's a simple binding to the bitcoin/libbase58 c library. The source code can be found here: https://github.com/legalthings/base58-php-ext *Why