Re: [PECL-DEV] New extension proposal (geohash)

2017-12-29 Thread Emir Beganovic
Merged into https://github.com/php-geospatial/geospatial. On 18 September 2017 at 11:03, Emir Beganovic wrote: > Hi, > > After some code review with @remicollet I think the code has been cleaned > up and the extension is ready for stable release. >

Re: [PECL-DEV] New extension proposal (geohash)

2017-09-19 Thread Derick Rethans
On Thu, 7 Sep 2017, Emir Beganović wrote: > Hi, > > I'd like to propose a new extension named geohash, that brings geohash > encoding and decoding functionality. There is a significant performance > gain from using this extension compared to user-land libraries. > > The extension is licensed

Re: [PECL-DEV] New extension proposal (geohash)

2017-09-18 Thread Emir Beganovic
Hi, After some code review with @remicollet I think the code has been cleaned up and the extension is ready for stable release.

Re: [PECL-DEV] New extension proposal (geohash)

2017-09-08 Thread Remi Collet
Le 07/09/2017 à 23:43, Emir Beganović a écrit : > Hi, > > I'd like to propose a new extension named geohash, that brings geohash > encoding and decoding functionality. There is a significant performance > gain from using this extension compared to user-land libraries. > > The extension is

Re: [PECL-DEV] New extension proposal (geohash)

2017-09-08 Thread Johannes Schlüter
Hi, > I'd like to propose a new extension named geohash, that brings > geohash on a quick review this looks good. Two small comments:   hash = (char*)emalloc(sizeof(char) * (precision + 1)); this might overflow. Better use safe_emalloc which calculates the buffer size in an overflow-safe way.