Merged into https://github.com/php-geospatial/geospatial.
On 18 September 2017 at 11:03, Emir Beganovic wrote:
> Hi,
>
> After some code review with @remicollet I think the code has been cleaned
> up and the extension is ready for stable release.
>
On Thu, 7 Sep 2017, Emir Beganović wrote:
> Hi,
>
> I'd like to propose a new extension named geohash, that brings geohash
> encoding and decoding functionality. There is a significant performance
> gain from using this extension compared to user-land libraries.
>
> The extension is licensed
Hi,
After some code review with @remicollet I think the code has been cleaned
up and the extension is ready for stable release.
Le 07/09/2017 à 23:43, Emir Beganović a écrit :
> Hi,
>
> I'd like to propose a new extension named geohash, that brings geohash
> encoding and decoding functionality. There is a significant performance
> gain from using this extension compared to user-land libraries.
>
> The extension is
Hi,
> I'd like to propose a new extension named geohash, that brings
> geohash
on a quick review this looks good.
Two small comments:
hash = (char*)emalloc(sizeof(char) * (precision + 1));
this might overflow. Better use safe_emalloc which calculates the
buffer size in an overflow-safe way.