Re: [perfmon2] [PATCH 4/5] perf_events: add cgroup support (v7)

2011-01-05 Thread Stephane Eranian
Peter, On Wed, Jan 5, 2011 at 2:01 PM, Stephane Eranian wrote: > On Wed, Jan 5, 2011 at 12:23 PM, Peter Zijlstra wrote: >> On Mon, 2011-01-03 at 18:20 +0200, Stephane Eranian wrote: >>> +void >>> +perf_cgroup_switch(struct task_struct *task, struct task_struct *next) >>> +{ >>> +     struct perf

Re: [perfmon2] [PATCH 4/5] perf_events: add cgroup support (v7)

2011-01-05 Thread Stephane Eranian
On Wed, Jan 5, 2011 at 12:23 PM, Peter Zijlstra wrote: > On Mon, 2011-01-03 at 18:20 +0200, Stephane Eranian wrote: > >> +#ifdef CONFIG_CGROUP_PERF >> +/* >> + * perf_cgroup_info keeps track of time_enabled for a cgroup. >> + * This is a per-cpu dynamically allocated data structure. >> + */ >> +st

Re: [perfmon2] [PATCH 4/5] perf_events: add cgroup support (v7)

2011-01-05 Thread Peter Zijlstra
On Mon, 2011-01-03 at 18:20 +0200, Stephane Eranian wrote: > +#ifdef CONFIG_CGROUP_PERF > +/* > + * perf_cgroup_info keeps track of time_enabled for a cgroup. > + * This is a per-cpu dynamically allocated data structure. > + */ > +struct perf_cgroup_info { > + u64 time; > + u64 timestamp;

Re: [perfmon2] [PATCH 0/5] perf_events: add support for per-cpu per-cgroup monitoring (v7)

2011-01-05 Thread Peter Zijlstra
I've applied 1,2 and 3. I'll wait for a fixed 4 and a rebased 5 (won't apply to current -tip). -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize thei

Re: [perfmon2] [PATCH 4/5] perf_events: add cgroup support (v7)

2011-01-05 Thread Stephane Eranian
Li, Thanks for your comment. Good catch on perf_detach_cgroup(). I will resubmit this patch (part 4/5). On Wed, Jan 5, 2011 at 4:13 AM, Li Zefan wrote: > Stephane Eranian wrote: >> This kernel patch adds the ability to filter monitoring based on >> container groups (cgroups). This is for use in