[perfmon2] [BUG] perf: perf report -n shows bogus number of samples

2011-02-08 Thread Stephane Eranian
Arnaldo, I think the -n option of perf report shows bogus number of samples. I believe it does not print the number of samples but rather the number of events if I understand the code in hist_entry__snprintf(). I think that's useless, the number of samples is more useful. $ perf report -h usag

Re: [perfmon2] [PATCH 1/2] perf_events: add cgroup support (v8)

2011-02-08 Thread Stephane Eranian
Peter, See comments below. On Mon, Feb 7, 2011 at 5:10 PM, Peter Zijlstra wrote: > Compile tested only, depends on the cgroup::exit patch > > --- linux-2.6.orig/include/linux/perf_event.h > +++ linux-2.6/include/linux/perf_event.h > @@ -905,6 +929,9 @@ struct perf_cpu_context { >        struct

Re: [perfmon2] [PATCH] perf: fix compile error in annotate.h

2011-02-08 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu: > > The following patch is necessary to compile without NEWT. > > Merged already, Borislav Petkov sent a similar patch. I just pushed it out - Stephane, mind checking that latest -tip indee

Re: [perfmon2] [PATCH] perf: fix compile error in annotate.h

2011-02-08 Thread Stephane Eranian
On Tue, Feb 8, 2011 at 4:19 PM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu: >> > The following patch is necessary to compile without NEWT. >> >> Merged already, Borislav Petkov sent a similar patch. > > I just

Re: [perfmon2] [PATCH] perf: fix compile error in annotate.h

2011-02-08 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu: > The following patch is necessary to compile without NEWT. Merged already, Borislav Petkov sent a similar patch. Thanks, - Arnaldo > Signed-off-by: Stephane Eranian > --- > > diff --git a/tools/perf/util/annotate.h b/tools

[perfmon2] [PATCH] perf: fix compile error in annotate.h

2011-02-08 Thread Stephane Eranian
The following patch is necessary to compile without NEWT. Signed-off-by: Stephane Eranian --- diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h index b1253aa..bc08b36 100644 --- a/tools/perf/util/annotate.h +++ b/tools/perf/util/annotate.h @@ -82,7 +82,7 @@ int symbol__tty_ann

Re: [perfmon2] [RFC][PATCH] cgroup: Fix cgroup_subsys::exit callback

2011-02-08 Thread Paul Menage
On Mon, Feb 7, 2011 at 12:02 PM, Peter Zijlstra wrote: > On Mon, 2011-02-07 at 11:28 -0800, Paul Menage wrote: >> On Mon, Feb 7, 2011 at 8:10 AM, Peter Zijlstra wrote: >> > >> > Make the ::exit method act like ::attach, it is after all very nearly >> > the same thing. >> >> The major difference b

Re: [perfmon2] [PATCH 1/2] perf_events: add cgroup support (v8)

2011-02-08 Thread Paul Menage
On Wed, Feb 2, 2011 at 4:46 AM, Peter Zijlstra wrote: > On Wed, 2011-02-02 at 17:20 +0530, Balbir Singh wrote: >> * Peter Zijlstra [2011-02-02 12:29:20]: >> >> > On Thu, 2011-01-20 at 15:39 +0100, Peter Zijlstra wrote: >> > > On Thu, 2011-01-20 at 15:30 +0200, Stephane Eranian wrote: >> > > > @@

Re: [perfmon2] [PATCH 1/2] perf_events: add cgroup support (v8)

2011-02-08 Thread Paul Menage
On Mon, Feb 7, 2011 at 12:09 PM, Peter Zijlstra wrote: > > Also, the core cgroup code should deal with the cgroup refcount, not > individual controllers. Right, that's what I meant - make it so that an rmdir that fails because a subsystem is still holding a refcount puts/leaves the cgroup in a st

Re: [perfmon2] [RFC][PATCH] cgroup: Fix cgroup_subsys::exit callback

2011-02-08 Thread Paul Menage
On Mon, Feb 7, 2011 at 8:10 AM, Peter Zijlstra wrote: > > Make the ::exit method act like ::attach, it is after all very nearly > the same thing. The major difference between attach and exit is that the former is only triggered in response to user cgroup-management action, whereas the latter is t

Re: [perfmon2] [RFC][PATCH] cgroup: Fix cgroup_subsys::exit callback

2011-02-08 Thread Peter Zijlstra
On Mon, 2011-02-07 at 13:21 -0800, Paul Menage wrote: > On Mon, Feb 7, 2011 at 12:02 PM, Peter Zijlstra wrote: > > On Mon, 2011-02-07 at 11:28 -0800, Paul Menage wrote: > >> On Mon, Feb 7, 2011 at 8:10 AM, Peter Zijlstra > >> wrote: > >> > > >> > Make the ::exit method act like ::attach, it is a