Re: [perfmon2] Question about the plm field in perf_event_attr

2009-11-26 Thread stephane eranian
Corey, On Wed, Nov 25, 2009 at 8:56 PM, Corey Ashford wrote: >> Ok, I see. The issue here is that you are assuming that attribute values >> are all integers. The way it is setup right now, an attribute can have any >> type, incl. a string. > > In my original email, I had a parenthetical question/

Re: [perfmon2] Question about the plm field in perf_event_attr

2009-11-26 Thread stephane eranian
Corey, I had a second thought on all of this while you are enjoying your long week-end ;-> I think we could use your proposed structure and call as a substitute for most of the attribute entry points such as: pfm_get_event_attr_name() pfm_get_event_attr_desc() pfm_get_event_attr_code()

[perfmon2] [PATCH] perf_events: fix read() bogus counts when in error state

2009-11-26 Thread Stephane Eranian
When a pinned group cannot be scheduled it goes into error state. Normally a group cannot go out of error state without being explicitly re-enabled or disabled. There was a bug in per-thread mode, whereby upon termination of the thread, the group would transition fro

Re: [perfmon2] [PATCH] perf_events: fix read() bogus counts when in error state

2009-11-26 Thread Peter Zijlstra
On Thu, 2009-11-26 at 09:24 -0800, Stephane Eranian wrote: > When a pinned group cannot be scheduled it goes into error state. > Normally a group cannot go out of error state without being explicitly > re-enabled or disabled. There was a bug in per-thread mode, whereby > upo

Re: [perfmon2] [PATCH] perf_events: fix read() bogus counts when in error state

2009-11-26 Thread Stephane Eranian
On Thu, Nov 26, 2009 at 6:36 PM, Peter Zijlstra wrote: > On Thu, 2009-11-26 at 09:24 -0800, Stephane Eranian wrote: >>       When a pinned group cannot be scheduled it goes into error state. >>       Normally a group cannot go out of error state without being explicitly >>       re-enabled or disa