On Tue, Jan 12, 2010 at 5:10 PM, Peter Zijlstra wrote:
> On Tue, 2010-01-12 at 12:50 +0200, Stephane Eranian wrote:
>> This patch improves event scheduling by maximizing the use
>> of PMU registers regardless of the order in which events are
>> created in a group.
>>
>> The
On Wed, 2010-01-13 at 10:54 +0100, Stephane Eranian wrote:
> > One concern I do have is the loss of error checking on
> > event_sched_in()'s event->pmu->enable(), that could be another
> > 'hardware' PMU like breakpoints, in which case it could fail.
> >
> Well, x86_pmu_enable() does return an err
On Wed, Jan 13, 2010 at 5:29 PM, Peter Zijlstra wrote:
> On Wed, 2010-01-13 at 10:54 +0100, Stephane Eranian wrote:
>
>> > One concern I do have is the loss of error checking on
>> > event_sched_in()'s event->pmu->enable(), that could be another
>> > 'hardware' PMU like breakpoints, in which case
Ok,
Something like that should problably do it:
static void event_sched_out(struct perf_event *event, int cpu)
{
event->state = PERF_EVENT_STATE_INACTIVE;
event->oncpu = -1;
}
hw_perf_group_sched_in()
{
n = 1;
list_for_each_entry(sub, &leader->sibling_l
