From 475281771e43ec28ab1840c77edcedd193ec506d Mon Sep 17 00:00:00 2001 From: Petr Písař <ppi...@redhat.com> Date: Aug 10 2017 06:33:04 +0000 Subject: Disable unreliable t/leak.t instead
--- diff --git a/Env-C-0.14-Skip-unreliable-t-leat.t-test.patch b/Env-C-0.14-Skip-unreliable-t-leat.t-test.patch new file mode 100644 index 0000000..a02e2fb --- /dev/null +++ b/Env-C-0.14-Skip-unreliable-t-leat.t-test.patch @@ -0,0 +1,30 @@ +From cda1f8167d248a25b8ad0942c6b69b60e6756cc0 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppi...@redhat.com> +Date: Thu, 10 Aug 2017 08:30:23 +0200 +Subject: [PATCH] Skip unreliable t/leat.t test +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +https://github.com/mschout/env-c/issues/3 +Signed-off-by: Petr Písař <ppi...@redhat.com> +--- + t/leak.t | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/t/leak.t b/t/leak.t +index 7094a82..6e044d8 100644 +--- a/t/leak.t ++++ b/t/leak.t +@@ -7,6 +7,8 @@ use strict; + use Test::More; + use Env::C; + ++plan skip_all => 'This test is fragile, there are inherent leaks in glibc'; ++ + if (Env::C::using_safe_putenv()) { + plan skip_all => "perl leaks with PERL_USE_SAFE_PUTENV"; + } +-- +2.9.4 + diff --git a/perl-Env-C.spec b/perl-Env-C.spec index 669f9ef..19b447a 100644 --- a/perl-Env-C.spec +++ b/perl-Env-C.spec @@ -7,10 +7,11 @@ URL: http://search.cpan.org/dist/Env-C/ Source0: http://www.cpan.org/authors/id/M/MS/MSCHOUT/Env-C-%{version}.tar.gz # Fix compiler warnings, <https://github.com/mschout/env-c/pull/9> Patch0: Env-C-0.14-Fix-compiler-warnings.patch -# Obey to perl's PERL_USE_SAFE_PUTENV default. -# If it proves wrong, we will disable t/leak.t instead. -# <https://github.com/mschout/env-c/issues/3> +# Obey to perl's PERL_USE_SAFE_PUTENV default Patch1: Env-C-0.14-Obey-to-perl-s-PERL_USE_SAFE_PUTENV-default.patch +# Disable unreliable t/leak.t instead. ppc64 usually fails. +# <https://github.com/mschout/env-c/issues/3> +Patch2: Env-C-0.14-Skip-unreliable-t-leat.t-test.patch BuildRequires: findutils BuildRequires: gcc BuildRequires: make @@ -34,6 +35,7 @@ It also can return all the environ variables. %setup -q -n Env-C-%{version} %patch0 -p1 %patch1 -p1 +%patch2 -p1 %build perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" NO_PACKLIST=1 @@ -58,6 +60,7 @@ make test * Wed Aug 09 2017 Petr Pisar <ppi...@redhat.com> - 0.14-5 - Fix compiler warnings - Obey to perl's PERL_USE_SAFE_PUTENV default (bug #1465738) +- Disable unreliable t/leak.t instead (bug #1465738) * Thu Aug 03 2017 Fedora Release Engineering <rel...@fedoraproject.org> - 0.14-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild https://src.fedoraproject.org/rpms/perl-Env-C/c/475281771e43ec28ab1840c77edcedd193ec506d?branch=master _______________________________________________ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org