[rpms/perl-FCGI] PR #2: Conditionalize client tests
ppisar closed without merging a pull-request against the project: `perl-FCGI` that you are following. Closed pull-request: `` Conditionalize client tests `` https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
ppisar commented on the pull-request: `Conditionalize client tests` that you are following: `` I applied this, slightly modified, patch. It removes the tests which require FCGI::Client on RHEL. `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
mspacek commented on the pull-request: `Conditionalize client tests` that you are following: `` > FCGI::Client is not a low-cost test dependency though You are right. In this case, we need to rewrite the testing of FCGI::Client. `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
yselkowitz commented on the pull-request: `Conditionalize client tests` that you are following: `` FCGI::Client is not a low-cost test dependency though, through Type::Tiny it pulls in dozens of otherwise unnecessary Perl module packages, some of which are explicitly unwanted in RHEL. Running this test in gating rather than in %check avoids the need to import and maintain those dozens of dependencies as packages in RHEL for 10+ years. `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
mspacek commented on the pull-request: `Conditionalize client tests` that you are following: `` @yselkowitz Yes 4) it's possible, but in my mind, this is something for integration tests. This is a kind of sw library, where is implemented some network protocol and I think that each this library needs some unit tests. `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
yselkowitz commented on the pull-request: `Conditionalize client tests` that you are following: `` 4) Merge this, and run the full testsuite in gating instead of during the build, which gives you much more flexibility wrt dependencies: https://docs.fedoraproject.org/en-US/ci/tmt/ `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
mspacek commented on the pull-request: `Conditionalize client tests` that you are following: `` @yselkowitz I don't think that's a good approach. CC @jplesnik We want to deliver these tests to RHEL10 (btw: I created these tests). The only issue is the big dependencies of FCGI::Client. Possible approaches: 1) I created PR https://src.fedoraproject.org/rpms/perl-Type-Tiny/pull-request/1 for adding conditions to not add big frameworks to RHEL. With enabling in Fedora. Ralf doesn't want this approach too. 2) We could add the previous PR to ELN. 3) Simplify tests in FCGI `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
yselkowitz commented on the pull-request: `Conditionalize client tests` that you are following: `` This is part of Fedora being the upstream of CentOS Stream and RHEL. Fedora builds are not affected, they will continue to run all the tests. Only RHEL/ELN builds, where these test dependencies are unwanted, are affected, because otherwise this requires dozens of Perl module RPMs to be imported and maintained in the buildroot for the sole purpose of running these tests during the build. Note that only recent versions had these client tests; e.g. 0.79 in c9s only has a basic load test, which will continue to be run in the RHEL/ELN builds. `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
yselkowitz commented on the pull-request: `Conditionalize client tests` that you are following: `` This is part of Fedora being the upstream of CentOS Stream and RHEL. Fedora builds are not affected, they will continue to run all the tests. Only RHEL/ELN builds, where these test dependencies are unwanted, are affected, because otherwise this requires dozens of Perl module RPMs to be imported and maintained in the buildroot for the sole purpose of running these tests during the build. Note that only recent versions had these client tests; e.g. 0.79 in c9s only has a basic load test, which will continue to be run in the RHEL/ELN builds. `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
corsepiu commented on the pull-request: `Conditionalize client tests` that you are following: `` I do not agree neither with this patch nor with the attitude behind it. It has always been Fedora's convention to "test to the max" and not to cripple packages, which are providing self tests. Besides that, disabling fcgi/fcgi tests is not a clever idea, because in Fedora mod_perl had been deprecated, leaving fcgi as the only option. `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[rpms/perl-FCGI] PR #2: Conditionalize client tests
yselkowitz opened a new pull-request against the project: `perl-FCGI` that you are following: `` Conditionalize client tests `` To reply, visit the link below https://src.fedoraproject.org/rpms/perl-FCGI/pull-request/2 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
