Notification time stamped 2019-10-18 13:27:56 UTC

From c6b3215f0113c444223960d1d97a31fc024f2beb Mon Sep 17 00:00:00 2001
From: Paul Howarth <p...@city-fan.org>
Date: Oct 18 2019 08:42:24 +0000
Subject: Spec tidy-up


- Use author-independent source URL
- Classify buildreqs by usage
- Drop redundant use of %{?perl_default_filter}
- Use %{make_build} and %{make_install}
- Fix permissions verbosely
- Make %files list more explicit
- Package README.md rather than README

---

diff --git a/perl-Mail-Transport.spec b/perl-Mail-Transport.spec
index 8a37c46..e3c7ce3 100644
--- a/perl-Mail-Transport.spec
+++ b/perl-Mail-Transport.spec
@@ -1,33 +1,42 @@
 Name:          perl-Mail-Transport
 Version:       3.004
-Release:       2%{?dist}
+Release:       3%{?dist}
 Summary:       Email message exchange
 License:       GPL+ or Artistic
 URL:           https://metacpan.org/release/Mail-Transport
-Source0:       
https://cpan.metacpan.org/authors/id/M/MA/MARKOV/Mail-Transport-%{version}.tar.gz
+Source0:       
https://cpan.metacpan.org/modules/by-module/Mail/Mail-Transport-%{version}.tar.gz
+BuildArch:     noarch
+# Build
+BuildRequires: coreutils
 BuildRequires: make
 BuildRequires: perl-generators
 BuildRequires: perl-interpreter
+BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76
+BuildRequires: perl(IO::Handle)
+# Runtime
 BuildRequires: perl(base)
 BuildRequires: perl(Carp)
 BuildRequires: perl(Errno)
-BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76
 BuildRequires: perl(File::Spec) >= 0.7
-BuildRequires: perl(IO::Handle)
 BuildRequires: perl(IO::Lines)
 BuildRequires: perl(IO::Socket)
 BuildRequires: perl(List::Util)
 BuildRequires: perl(Mail::Reporter) >= 3
+BuildRequires: perl(Net::Config)
+BuildRequires: perl(Net::Domain)
 BuildRequires: perl(Net::SMTP)
 BuildRequires: perl(strict)
-BuildRequires: perl(Test::More)
 BuildRequires: perl(vars)
 BuildRequires: perl(warnings)
-BuildArch:     noarch
-Requires:      perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo 
$version))
+# Test Suite
+BuildRequires: perl(Test::More)
+# Dependencies
+Requires:      perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:      perl(IO::Lines)
-
-%{?perl_default_filter}
+Requires:      perl(IO::Socket)
+Requires:      perl(List::Util)
+Requires:      perl(Net::Config)
+Requires:      perl(Net::Domain)
 
 %description
 Email message exchange code, formerly part of the Mail::Box package.
@@ -36,22 +45,39 @@ Email message exchange code, formerly part of the Mail::Box 
package.
 %setup -q -n Mail-Transport-%{version}
 
 %build
-yes y |%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
-make
+yes y | perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%{make_build}
 
 %install
-make pure_install DESTDIR=$RPM_BUILD_ROOT
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{make_install}
+%{_fixperms} -c %{buildroot}
 
 %check
 make test
 
 %files
-%doc README ChangeLog
+%doc ChangeLog README.md
 %{perl_vendorlib}/Mail/
-%{_mandir}/man3/*.3*
+%{_mandir}/man3/Mail::Transport.3*
+%{_mandir}/man3/Mail::Transport::Exim.3*
+%{_mandir}/man3/Mail::Transport::Mailx.3*
+%{_mandir}/man3/Mail::Transport::Qmail.3*
+%{_mandir}/man3/Mail::Transport::Receive.3*
+%{_mandir}/man3/Mail::Transport::SMTP.3*
+%{_mandir}/man3/Mail::Transport::Send.3*
+%{_mandir}/man3/Mail::Transport::Sendmail.3*
 
 %changelog
+* Fri Oct 18 2019 Paul Howarth <p...@city-fan.org> - 3.004-3
+- Spec tidy-up
+  - Use author-independent source URL
+  - Classify buildreqs by usage
+  - Drop redundant use of %%{?perl_default_filter}
+  - Use %%{make_build} and %%{make_install}
+  - Fix permissions verbosely
+  - Make %%files list more explicit
+  - Package README.md rather than README
+
 * Fri Jul 26 2019 Fedora Release Engineering <rel...@fedoraproject.org> - 
3.004-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
 


        
https://src.fedoraproject.org/rpms/perl-Mail-Transport/c/c6b3215f0113c444223960d1d97a31fc024f2beb?branch=epel8
_______________________________________________
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org

Reply via email to