Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread David Wheeler
On Oct 5, 2004, at 12:53 PM, Geoffrey Young wrote: yeah, I think that's all the required up front pieces. authors still need to configure Devel::Cover over in httpd.conf land, but there's not much we can do from a makefile to help with that. I think we're good to go, then. Regards, David

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Geoffrey Young
David Wheeler wrote: > On Oct 5, 2004, at 12:43 PM, Geoffrey Young wrote: > >> no, it is required. but only cvs currently supports -one-process as an >> option - earlier versions will explode. > > > Okay. So I just added this to the testcover action: > > local $ENV{APACHE_TEST_EXTRA_ARGS

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread David Wheeler
On Oct 5, 2004, at 12:43 PM, Geoffrey Young wrote: no, it is required. but only cvs currently supports -one-process as an option - earlier versions will explode. Okay. So I just added this to the testcover action: local $ENV{APACHE_TEST_EXTRA_ARGS} = "-one-process"; Is that all it needs? Regar

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Geoffrey Young
David Wheeler wrote: > On Oct 5, 2004, at 12:36 PM, Geoffrey Young wrote: > >> somewhere in here it looks like -one-process is missing, though I >> wouldn't >> know where it would go. > > > I'll put it in, though it isn't needed if you use A-T in CVS, eh? no, it is required. but only cvs cur

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread David Wheeler
On Oct 5, 2004, at 12:36 PM, Geoffrey Young wrote: somewhere in here it looks like -one-process is missing, though I wouldn't know where it would go. I'll put it in, though it isn't needed if you use A-T in CVS, eh? you're the only one with commit access who uses or understand Module::Build, so g

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Geoffrey Young
> +my $atdir = $self->localize_file_path("$ENV{HOME}/.apache-test"); > +local $Test::Harness::switches= > +local $Test::Harness::Switches= > +local $ENV{HARNESS_PERL_SWITCHES} = "-MDevel::Cover=+inc,'$atdir'"; somewhere in here it looks like -one-process is missing, though

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread David Wheeler
On Oct 5, 2004, at 11:51 AM, Geoffrey Young wrote: basically it goes into $HOME because it stores the A-T preferences for a specific user. but this is all part of the endless 'sticky preferences' foo that I really don't want to be associated with ;) lots of to and fro in the httpd-test archive

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread David Wheeler
On Oct 5, 2004, at 11:51 AM, Geoffrey Young wrote: basically it goes into $HOME because it stores the A-T preferences for a specific user. but this is all part of the endless 'sticky preferences' foo that I really don't want to be associated with ;) lots of to and fro in the httpd-test archive

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Geoffrey Young
David Wheeler wrote: > On Oct 5, 2004, at 11:32 AM, Geoffrey Young wrote: > >>> Ah, cool. But $(HOME) doesn't correspond to ~/ here, does it? >> >> >> yeah - it's equivalent to $ENV{HOME} in make-land. I guess there is >> always >> the danger that $HOME isn't populated, but internally A-T uses

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Paul Johnson
On Tue, Oct 05, 2004 at 11:32:23AM -0700, David Wheeler wrote: > On Oct 5, 2004, at 11:25 AM, Paul Johnson wrote: > > >I wonder whether we shouldn't try to standardise the target name before > >it's too late to do so. Module::Build uses covertest, I've always used > >cover, and Geoff has just us

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread David Wheeler
On Oct 5, 2004, at 11:32 AM, Geoffrey Young wrote: Ah, cool. But $(HOME) doesn't correspond to ~/ here, does it? yeah - it's equivalent to $ENV{HOME} in make-land. I guess there is always the danger that $HOME isn't populated, but internally A-T uses $ENV{HOME} when it generates the .apache-test

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Geoffrey Young
>>test-cover :: >> @cover -delete >> @HARNESS_PERL_SWITCHES=-MDevel::Cover=+inc,$(HOME)/.apache-test >>APACHE_TEST_EXTRA_ARGS=-one-process $(MAKE) test >> @cover > > > I wonder whether we shouldn't try to standardise the target name before > it's too late to do so. Module::Build

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Geoffrey Young
>> - HARNESS_PERL_SWITCHES gets Devel::Cover started > > > Module::Build's testcover target already does this. :) > >> - +inc,$(HOME)/.apache-test keeps coverage away from generated A-T >> files, >> which isn't required > > > Ah, cool. But $(HOME) doesn't correspond to ~/ here, does it?

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread David Wheeler
On Oct 5, 2004, at 11:25 AM, Paul Johnson wrote: I wonder whether we shouldn't try to standardise the target name before it's too late to do so. Module::Build uses covertest, I've always used cover, and Geoff has just used test-cover. Actually, Module::Build uses "testcover". I'm not overly concer

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Paul Johnson
On Tue, Oct 05, 2004 at 02:08:25PM -0400, Geoffrey Young wrote: > David Wheeler wrote: > > > > Perhaps I should add support for Module::Build's "covertest" action to > > Apache::TestMB...just tell me what it needs to do. > > I think that all Apache::TestMB would need to do is add a make target t

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread David Wheeler
On Oct 5, 2004, at 11:08 AM, Geoffrey Young wrote: I think that all Apache::TestMB would need to do is add a make target that looks like this: test-cover :: @cover -delete @HARNESS_PERL_SWITCHES=-MDevel::Cover=+inc,$(HOME)/.apache-test APACHE_TEST_EXTRA_ARGS=-one-process $(MAKE) t

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Geoffrey Young
David Wheeler wrote: > On Oct 2, 2004, at 2:30 PM, Geoffrey Young wrote: > >> I started to maintain Apache-Test skeletons, but I never quite got >> them up >> to speed. give me a few days and I'll roll a tarball with a test-cover >> target so that folks can have an entire working example of the

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Paul Johnson
On Tue, Oct 05, 2004 at 11:27:01AM -0400, Geoffrey Young wrote: > as promised, here is a tarball that includes a 'test-cover' target. > > http://perl.apache.org/~geoff/Apache-Test-with-Devel-Cover.tar.gz > > it's made a little more complex than it needs to be because of version > restrictions:

Re: running Devel::Cover in mod_perl (1.3)

2004-10-05 Thread Geoffrey Young
Geoffrey Young wrote: >>[ Just before sending this I notice Geoff has recommended something >>better, but I'll send this too as another WTDI. ] > > > cool :) > > I started to maintain Apache-Test skeletons, but I never quite got them up > to speed. give me a few days and I'll roll a tarball w