Re: Unintended consequences

2006-05-22 Thread David H. Adler
On Mon, May 22, 2006 at 09:45:31PM -0500, Andy Lester wrote: > Here's an example of why I'm not real excited about CPANTS: > > http://community.livejournal.com/perl/120747.html You mean the fact that there's a perl community on LJ? :-) dha -- David H. Adler - <[EMAIL PROTECTED]> - http://www.p

Re: Unintended consequences

2006-05-22 Thread Steve Peters
On Mon, May 22, 2006 at 09:45:31PM -0500, Andy Lester wrote: > Here's an example of why I'm not real excited about CPANTS: > > http://community.livejournal.com/perl/120747.html > I prefer Acme::Raise_my_kwalitee as my anti-CPANTs example. S

Unintended consequences

2006-05-22 Thread Andy Lester
Here's an example of why I'm not real excited about CPANTS: http://community.livejournal.com/perl/120747.html xoa -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance

Re: Changing permissions on temporary directories during testing

2006-05-22 Thread James E Keenan
Michael G Schwern wrote: There's other issues with this code. For one, its not portable. You're using a system command (touch) and you're assuming Unix filepath syntax. Another is your errors do not include $! which is the reason the command failed (no such file or directory). Additionally,

Re: Changing permissions on temporary directories during testing

2006-05-22 Thread Michael G Schwern
On 5/21/06, James E Keenan <[EMAIL PROTECTED]> wrote: This code is intended to achieve that goal but doesn't DWIM: This is the right idea, but... my ($file, $workdir, $destdir); { $workdir = File::Temp::tempdir(); chdir $workdir or die "Cannot change to $workdir"; $file = sys

Re: Changing permissions on temporary directories during testing

2006-05-22 Thread Michael G Schwern
On 5/22/06, David Golden <[EMAIL PROTECTED]> wrote: How portable does this need to be? My inclination is not to mess with file permissions in a test suite if you can avoid it. ... For system interaction tests, I prefer to fake failures rather than try to manufacture them. All things bei

Re: Changing permissions on temporary directories during testing

2006-05-22 Thread David Golden
James E Keenan wrote: Let's say that I'm writing a test suite for a Perl module which creates files and then, optionally, moves those files to predetermined directories. To test this module's functionality, I would have to see what happens when the user running the tests does not have write p

Re: Changing permissions on temporary directories during testing

2006-05-22 Thread Adam Kennedy
See the test suite for File::Flat, I put a ton of work into making sure it worked, and a lot of code doing filesystem stuff. Adam K James E Keenan wrote: Let's say that I'm writing a test suite for a Perl module which creates files and then, optionally, moves those files to predetermined dire