Re: New TAP Grammar

2006-09-14 Thread Chris Dolan
A few minor corrections: On Sep 14, 2006, at 3:47 PM, jerry gay wrote: grammar TAP; ## Ovid's TAP grammar, translated, corrected, and rendered idiomatic ## NOTE: not yet extended to deal with 'Bail out!' etc. token tap { | * } token plan{ <'1..'> \d+ \n } That \d+ is bad

Re: Too many tests

2006-09-14 Thread Michael G Schwern
Ovid wrote: > Here's we have a test where the plan is 1..3 but we've run 7 tests. > > TAPx-Parser $ prove -v t/sample-tests/too_many > t/sample-tests/too_many...1..3 > ok 1 > ok 2 > ok 3 > ok 4 > ok 5 > ok 6 > ok 7 > dubious > Test returned status 4 (wstat 1024, 0x400

Re: New TAP Grammar

2006-09-14 Thread Adam Kennedy
It might be worth running Perl::MinimumVersion over the codebase real quick. It has all the obvious stuff coded into it (like warnings and qr//) already. Adam K Michael G Schwern wrote: Ovid wrote: Also, for purposes of backwards compatability, I'm concerned about qr// and $code->(). When we

Re: New TAP Grammar

2006-09-14 Thread Michael G Schwern
chromatic wrote: > On Thursday 14 September 2006 13:14, Ovid wrote: > >> What's 'bonus'? I haven't figured that out yet. > > That should be the number of successful TODO tests. If it's not, I have no > idea. > >> Also, I never tracked the exit status of the tests. Frankly, I never used >> th

Re: New TAP Grammar

2006-09-14 Thread Michael G Schwern
Ovid wrote: > The reason you see descriptions starting with a hyphen in Test::More style > output is because people do stuff like this: > > ok $foo, '3rd test passed'; > > And you don't want to risk that leading digit confusing the parser. Actually its there because I thought it made it easie

Re: New TAP Grammar

2006-09-14 Thread Michael G Schwern
Ovid wrote: > Also, for purposes of backwards compatability, I'm concerned about qr// and > $code->(). > When were those first introduced in Perl? I don't want someone using really > old versions to not be able to use this code. qr// was introduced in 5.6. $code->() has been in there as long

Re: CPANTS quality brainstorming

2006-09-14 Thread brian d foy
In article <[EMAIL PROTECTED]>, David Golden <[EMAIL PROTECTED]> wrote: > brian d foy wrote: > > Thinking about this further and talking to a few people about it, the > > only place that makes any sense is the source code file itself. After > > installation, the rest of the distribution will disap

Re: Too many tests

2006-09-14 Thread Adam Kennedy
How else are you going to deal with "you've run more tests than you said you were"? If you accept the results and assume the count is wrong how do you know what the program didn't silently die part way through and in fact you are dealing with a catastrophic failure in the middle of more tests th

Re: Too many tests

2006-09-14 Thread demerphq
On 9/14/06, Ovid <[EMAIL PROTECTED]> wrote: Here's we have a test where the plan is 1..3 but we've run 7 tests. TAPx-Parser $ prove -v t/sample-tests/too_many t/sample-tests/too_many...1..3 ok 1 ok 2 ok 3 ok 4 ok 5 ok 6 ok 7 dubious Test returned status 4 (wstat 102

Re: TidyView - preview your perltidy options

2006-09-14 Thread demerphq
On 9/15/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Well, I'm hoping for feedback from this maillist, and when that settles down, I'm debating whether to send it to CPAN ten announce on perlmonks et al, or to announce on perl monks whilst still on sourceforge, and after feedback from perl

RE: TidyView - preview your perltidy options

2006-09-14 Thread leif . eriksen
Not a huge effort - I tried to separate the code into two main areas - dealing with Perltidy and dealing with Tk - so theoretically, it would just require poking the Tk side. That said, I've never played with Wx so the most work is in learning the Wx API. The lib/ dir is split into the two area

RE: TidyView - preview your perltidy options

2006-09-14 Thread leif . eriksen
Well, I'm hoping for feedback from this maillist, and when that settles down, I'm debating whether to send it to CPAN ten announce on perlmonks et al, or to announce on perl monks whilst still on sourceforge, and after feedback from perl monks, post it to CPAN -I already have a PAUSE id etc. So

Re: New TAP Grammar

2006-09-14 Thread jerry gay
On 9/14/06, Ovid <[EMAIL PROTECTED]> wrote: - Original Message From: jerry gay <[EMAIL PROTECTED]> > thanks for the responses. i've done a second take on the TAP grammar > in perl6 format, with the help of patrick michaud. i'm pretty sure > it's correct now, at least as per your previou

Re: New TAP Grammar

2006-09-14 Thread Ovid
- Original Message From: jerry gay <[EMAIL PROTECTED]> > thanks for the responses. i've done a second take on the TAP grammar > in perl6 format, with the help of patrick michaud. i'm pretty sure > it's correct now, at least as per your previous grammar. have a look: I'll update my gramma

Too many tests

2006-09-14 Thread Ovid
Here's we have a test where the plan is 1..3 but we've run 7 tests. TAPx-Parser $ prove -v t/sample-tests/too_many t/sample-tests/too_many...1..3 ok 1 ok 2 ok 3 ok 4 ok 5 ok 6 ok 7 dubious Test returned status 4 (wstat 1024, 0x400) DIED. FAILED tests 4-7 F

Re: New TAP Grammar

2006-09-14 Thread chromatic
On Thursday 14 September 2006 13:14, Ovid wrote: > What's 'bonus'? I haven't figured that out yet. That should be the number of successful TODO tests. If it's not, I have no idea. > Also, I never tracked the exit status of the tests. Frankly, I never used > that number myself. Does anyone?

Re: New TAP Grammar

2006-09-14 Thread jerry gay
thanks for the responses. i've done a second take on the TAP grammar in perl6 format, with the help of patrick michaud. i'm pretty sure it's correct now, at least as per your previous grammar. have a look: grammar TAP; ## Ovid's TAP grammar, translated, corrected, and rendered idiomatic ## NOTE:

Re: New TAP Grammar

2006-09-14 Thread Ovid
- Original Message From: Michael G Schwern > You might find it handy to pull all the sample test files from the > Test::Harness tests and use them to test > TAPx::Parser. http://svn.perl.org/modules/Test-Harness/trunk/t/sample-tests/ What a pain in the @$$. I'm up to 613 new te

Re: TidyView - preview your perltidy options

2006-09-14 Thread Adam Kennedy
I see the opposite. Alien::wxWidgets has gotten better and worse with each version, but gradually trending towards better. Tk, well there's a lot of scary errors there. I'd try Wx again every couple of Alien:: releases, and see how it goes if you let it build Wx itself. Adam K Ovid wrote:

Re: New TAP Grammar

2006-09-14 Thread Ovid
- Original Message From: jerry gay <[EMAIL PROTECTED]> > i translated this grammar to a perl 6 grammar. i know it has some bugs > in it (probably 'rule' vs. 'token' among others) but it's a good > start. from translating it, there are a few things that stick out. Wonderful! ~ i thought

Re: TidyView - preview your perltidy options

2006-09-14 Thread Michael G Schwern
Ovid wrote: > - Original Message > From: Adam Kennedy <[EMAIL PROTECTED]> > >> Please excuse the stupid question, but is there any chance this could >> use Wx instead of Tk, since Wx installs from CPAN cleanly everywhere now >> (I think) and Tk doesn't seem to install properly. > > I f

Re: New TAP Grammar

2006-09-14 Thread jerry gay
On 9/14/06, Ovid <[EMAIL PROTECTED]> wrote: I'm not particularly gifted with grammars, so corrections welcome. The corrected TAP grammar: digit ::= [:digit:] character ::= ([:print:] - "\n") positiveInteger::= ( digit - '0' ) {digit} nonNegativeInteger ::= digit {d

Re: New TAP Grammar

2006-09-14 Thread Ovid
- Original Message From: Michael G Schwern > > nonNegativeInteger ::= digit {digit} > > plan::= '1..' nonNegativeInteger "\n" > > TODO and SKIP are case insensitive TAPx::Parser treats them as case insensitive, but I wasn't sure how to represent that in a gram

Re: Installing Tests

2006-09-14 Thread Michael G Schwern
Adam Kennedy wrote: > I'm not suggesting we test against the post-make code, but if we keep > everything, we can be fairly certain we still have any data files or > other things that are needed to support the testing. > > Now we rerun the test suite, but without including blib. > > And you get a

Re: New TAP Grammar

2006-09-14 Thread Michael G Schwern
Ovid wrote: > The corrected TAP grammar: > > digit ::= [:digit:] > character ::= ([:print:] - "\n") > positiveInteger::= ( digit - '0' ) {digit} > nonNegativeInteger ::= digit {digit} > > tap ::= plan tests | tests plan {comment} > plan::= '1..' no

Re: Comments after ending plan

2006-09-14 Thread Michael G Schwern
Ovid wrote: > - Original Message > From: chromatic <[EMAIL PROTECTED]> > >>> ok 1 >>> not ok 2 >>> 1..2 >>> # this comment is acceptable >>> ... but what about this? >> Shouldn't that last line always be an error wherever it occurs? > > For purposes of forward compata

Re: post-YAPC::Europe CPANTS news

2006-09-14 Thread Michael G Schwern
Adam Kennedy wrote: > I'm find with adding an additional environment variable though for the > packaging state. But please lets not decide on anything right now, > AUTOMATED_TESTING is already a sub-optimal name, I'd rather make sure > that the EU::MM, M:B and M:I modules all agreed on a single con

Re: Installing Tests

2006-09-14 Thread Michael G Schwern
Adam Kennedy wrote: >> Hmm, that would waste a lot of disk. Maybe we could cache the >> tarballs somewhere. Maybe on the network or even Amazon S3. Some >> sort of big repository of modules. We can call it the Network of >> Archived Postinstall Crap, NAPC for short! > > This same argument appl

Re: CPANTS quality brainstorming

2006-09-14 Thread Gabor Szabo
On 9/14/06, Chris Dolan <[EMAIL PROTECTED]> wrote: * Advocacy to get popular modules to state their licenses more prominently * Advocacy to get modules with inconsistently stated licenses (e.g. DSLIP vs. POD) corrected I think if we can include it in the CPANTS tests so there might be sever

Re: TidyView - preview your perltidy options

2006-09-14 Thread Michael Peters
Michael Carman wrote: > From: [EMAIL PROTECTED] >> >> colourised diff's between what you code originally looked like and >> how Perltidy formatted it would be a great addition, but I haven't >> a clue how to do it. > > Use Algorithm::Diff::sdiff() to calculate the differences, then parse the

Re: TidyView - preview your perltidy options

2006-09-14 Thread Michael Carman
From: [EMAIL PROTECTED] > > colourised diff's between what you code originally looked like and > how Perltidy formatted it would be a great addition, but I haven't > a clue how to do it. Use Algorithm::Diff::sdiff() to calculate the differences, then parse the output to convert it into tagged t

Re: CPANTS quality brainstorming

2006-09-14 Thread Chris Dolan
On Sep 14, 2006, at 4:36 AM, David Cantrell wrote: Adam Kennedy wrote: Agreed, while the META.yml key is the simplest way, it should be possible to locate the most common patterns for licensing, such at the typical COPYRIGHT POD block that often contains "... is licensed ..." etc. Or li

Re: TidyView - preview your perltidy options

2006-09-14 Thread Ovid
- Original Message From: Adam Kennedy <[EMAIL PROTECTED]> > Please excuse the stupid question, but is there any chance this could > use Wx instead of Tk, since Wx installs from CPAN cleanly everywhere now > (I think) and Tk doesn't seem to install properly. I finally gave up trying to

Re: TidyView - preview your perltidy options

2006-09-14 Thread Adam Kennedy
And the second obvious question, while I'm thinking about it... When will we be able to install this from CPAN? :) Adam K [EMAIL PROTECTED] wrote: Hi all, I have release a pet project on Sourceforge called TidyView, at https://sourceforge.net/projects/tidyview/

Re: TidyView - preview your perltidy options

2006-09-14 Thread Adam Kennedy
Please excuse the stupid question, but is there any chance this could use Wx instead of Tk, since Wx installs from CPAN cleanly everywhere now (I think) and Tk doesn't seem to install properly. But then I imagine moving to Wx would mean a HUGE amount of code to change... Adam K [EMAIL PROTE

Updated Tidyvew URL

2006-09-14 Thread leif . eriksen
Of course it had to be wrong didnt it - http://sourceforge.net/projects/tidyview/ if the https isnt working for you. Leif Eriksen -- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.1.405 / Virus Database: 268.12.3/44

TidyView - preview your perltidy options

2006-09-14 Thread leif . eriksen
Hi all, I have release a pet project on Sourceforge called TidyView, at https://sourceforge.net/projects/tidyview/ Basically it is a Tk GUI to help preview the effect of the plethora of options provided by Perltidy. If you dont know what

Re: post-YAPC::Europe CPANTS news

2006-09-14 Thread Philippe "BooK" Bruhat
Le mardi 12 septembre 2006 à 11:15, Chris Dolan écrivait: > On Sep 12, 2006, at 9:24 AM, Salve J Nilsen wrote: > > >>Any metric that catches bad things, particularly bad technical > >>things, is going to be just fine. > >>Metrics that try to push "good" behavior are fraught with trouble, > >>b

Re: CPANTS quality brainstorming

2006-09-14 Thread Adam Kennedy
David Cantrell wrote: Adam Kennedy wrote: Agreed, while the META.yml key is the simplest way, it should be possible to locate the most common patterns for licensing, such at the typical COPYRIGHT POD block that often contains "... is licensed ..." etc. Or licenced. Please remember to take

Re: CPANTS quality brainstorming

2006-09-14 Thread David Cantrell
Adam Kennedy wrote: Agreed, while the META.yml key is the simplest way, it should be possible to locate the most common patterns for licensing, such at the typical COPYRIGHT POD block that often contains "... is licensed ..." etc. Or licenced. Please remember to take account of such a common

New TAP Grammar

2006-09-14 Thread Ovid
As it turns out, adding support to allow comments after a terminating plan was trivial. However, the grammar was getting a bit old and needed some work. I noticed, amongst other things, that comments had never been integrated. If you're not familiar with reading this style of grammar, here are