Re: P::C or PPI bug?

2006-11-07 Thread Adam Kennedy
I'm not sure you can reliably test that though, not to 100% anyway, given the problem of implicit params. is( foo $bar, $baz, $expected ); which means is( foo($bar, $baz), $expected ); Yes, his specific case is ok, but I think you need to be a bit cunning about how you check... Adam K Chr

Re: P::C or PPI bug?

2006-11-07 Thread Chris Dolan
On Nov 7, 2006, at 6:15 PM, Christopher H. Laco wrote: I just wanted to get some thoughts on this before I filed a bug report with either PPI or Perl::Critic: I'm going through and testing all of my *.t files for RequireTestLabels. I was humming right along when I ran into an oddity. The new

P::C or PPI bug?

2006-11-07 Thread Christopher H. Laco
I just wanted to get some thoughts on this before I filed a bug report with either PPI or Perl::Critic: I'm going through and testing all of my *.t files for RequireTestLabels. I was humming right along when I ran into an oddity. The newest Perl::Critic 0.21 + PPI 1.118 complains that the tests do

Re: CPANTS and META.yml

2006-11-07 Thread Thomas Klausner
Hi! On Tue, Nov 07, 2006 at 06:58:11AM +0100, A. Pagaltzis wrote: > But yeah, other than that, I agree, the metric should check that > META.yml conforms to the spec it says it conforms to, and that > a metric that checks for conformance to the latest version should > be a bonus, if it exists at a