Re: New CPANTS metrics

2007-04-01 Thread Graham Barr
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mar 31, 2007, at 5:32 PM, Yuval Kogman wrote: On Sat, Mar 31, 2007 at 18:26:26 -0400, Yuval Kogman wrote: uses_version_control sounds more like lacks_manifest_skip_file which should deduct kwalitee IMHO. Hmm... reading into the other metrics, i

Re: New CPANTS metrics

2007-04-01 Thread Yuval Kogman
On Sun, Apr 01, 2007 at 19:51:09 -0500, Graham Barr wrote: > Yes look at the date > > Date: Sun, 1 Apr 2007 00:14:42 +0200 > > Seems like a few fell for it though :-) My excuse is that I'm jetlagged and I barely know what day of the week it is, let alone what the date is ;-) It was def. a good

Re: New CPANTS metrics

2007-04-01 Thread chromatic
On Sunday 01 April 2007 07:11, ReneeB wrote: > I dont't use vi(m) or emacs! There's a kwalitee ding for sure! -- c

Re: New CPANTS metrics

2007-04-01 Thread A. Pagaltzis
* Thomas Klausner <[EMAIL PROTECTED]> [2007-04-01 00:20]: > Even though I was fighting mail servers today, I managed to put > some time aside for long-needed CPANTS improvements. Congrats on being _the_ _only_ _one_ to pull an online April fool’s prank, all day, that actually managed to lead me as

Re: New CPANTS metrics

2007-04-01 Thread David E . Wheeler
On Mar 31, 2007, at 21:06, Shlomi Fish wrote: Maybe so, but how else can CPANTS detect that you use the world's most advanced version control system: CVS? Are you kidding? Methinks you are not familiar with chromatic's sense of humor. Most people aren't, though, especially in email. :-)

Re: New CPANTS metrics

2007-04-01 Thread Eric Wilhelm
# from Andy Armstrong # on Sunday 01 April 2007 07:53 am: >Agreed. May I propose the additional requirement that the   >documentation contain a lengthy treatise on the benefits of true[1]   >object orientation? > >[1] For whichever value of 'true' the author prefers. Yes, but then it should also

Re: New CPANTS metrics

2007-04-01 Thread Andy Armstrong
On 1 Apr 2007, at 15:45, Paul Johnson wrote: uses_oo Shortcoming: Your code contains conditional statements (if, unless, or, ?: and so forth). This indicates that you do not have a firm grasp of OO principles and probably need to reread the GoF book. Remedy: Replace all you

Re: New CPANTS metrics

2007-04-01 Thread Paul Johnson
On Sun, Apr 01, 2007 at 01:29:59PM +0100, Andy Armstrong wrote: > I'm going to start using this once I can optimise it. It takes too > long to run at the moment > > sub if_then_else { > my ($cond, $true, $false) = @_; > return if_then_else(!$cond, $false, $true); > } > > You pass it a

Re: New CPANTS metrics

2007-04-01 Thread Andy Armstrong
On 1 Apr 2007, at 15:11, ReneeB wrote: But everybody has different opinions about "nice_code". And sometimes companies force their employees to write the code in a specific layout. I don't like the idea of forcing people to program in a specific way. I know all about recursion, And the ben

Re: New CPANTS metrics

2007-04-01 Thread ReneeB
Eric Wilhelm schrieb: I'm looking forward to the source (must just be delayed by PAUSE.) I'm curious whether the mentions_kwalitee metric has any gaming-prevention. If I say "reduced kwalitee" in the changelog, does that count for or against me? Some of the new metrics can't be satisfie

Re: New CPANTS metrics

2007-04-01 Thread Andy Armstrong
On 1 Apr 2007, at 10:36, Eric Wilhelm wrote: I'm looking forward to the source (must just be delayed by PAUSE.) I'm curious whether the mentions_kwalitee metric has any gaming- prevention. If I say "reduced kwalitee" in the changelog, does that count for or against me? I'm going to add the

Re: New CPANTS metrics

2007-04-01 Thread Eric Wilhelm
# from ReneeB # on Sunday 01 April 2007 12:41 am: >On 31 Mar 2007, at 23:14, Thomas Klausner wrote: Yay! Now that the time zones have caught up, I get to participate in the discussion. >>> Even though I was fighting mail servers today, I managed to put >>> some time aside >>> for long-needed C