Re: done_testing()

2009-02-05 Thread David E. Wheeler
On Feb 5, 2009, at 6:23 PM, Michael G Schwern wrote: # Planning 2 more tests at foo.t line 3. ok 1 - First test not ok 2 - 2 tests were planned but only 1 was run # Failed test "2 tests were planned but only 1 was run" # at foo.t line 6. # Planning 1 more test at foo.t line 6. ok 3 - Seco

Re: done_testing()

2009-02-05 Thread Michael G Schwern
David E. Wheeler wrote: > On Feb 5, 2009, at 12:34 PM, Michael G Schwern wrote: > >> Though we don't have incremental TAP plans, Test::Builder can check that >> you've run all the tests you said you'd run before you add more. Thus... >> >> use Test::More; >> >> plan add => 2; >> pass; >> >> p

Re: done_testing()

2009-02-05 Thread David E. Wheeler
On Feb 5, 2009, at 12:34 PM, Michael G Schwern wrote: Though we don't have incremental TAP plans, Test::Builder can check that you've run all the tests you said you'd run before you add more. Thus... use Test::More; plan add => 2; pass; plan add => 1; pass; # failure pass

Re: done_testing()

2009-02-05 Thread Michael G Schwern
David Cantrell wrote: > On Thu, Feb 05, 2009 at 10:00:38AM +0200, Gabor Szabo wrote: > >> You might want to report error if both plan(2) and add_plan(2) was >> called in the same file. > > Or you might not. > > plan(2); > # generic tests > ok(...); > ok(...); > if($ENV{RUN_REALLY_SLOW_TESTS}) {

Re: done_testing()

2009-02-05 Thread Michael G Schwern
Gabor Szabo wrote: > BTW what about > > use Test::More; > pass; > pass; > # done_testing() # not being called at all. > > Is this a failure now as there was no plan, not even a no_plan ? It's a failure by virtue of there being no TAP plan. I didn't feel it was necessary to output an explicit fa

Re: done_testing()

2009-02-05 Thread David Cantrell
On Thu, Feb 05, 2009 at 10:00:38AM +0200, Gabor Szabo wrote: > You might want to report error if both plan(2) and add_plan(2) was > called in the same file. Or you might not. plan(2); # generic tests ok(...); ok(...); if($ENV{RUN_REALLY_SLOW_TESTS}) { add_plan(2); ok(...); ok(...); } done_

Re: [test-more-users] Re: done_testing()

2009-02-05 Thread Ovid
- Original Message > From: Gaurav Vaidya > I just made a branch of Test::Builder which does this. You can see the > expected > behaviour in the tests at: > > http://github.com/gaurav/test-more/tree/incremental-planning/t/incremental_planning/ > (or http://tinyurl.com/ad8mb4)

Re: done_testing()

2009-02-05 Thread Gabor Szabo
On Wed, Feb 4, 2009 at 4:35 PM, Ovid wrote: > - Original Message > >> From: Michael G Schwern > > First of all, thank you! This is fantastic work and I'm sure it will make a > lot of people happy. ++ > Thoughts on first order support: > > use Test::More; > > plan(3); > pass; > pass;