Re: standard for internal-only tests?

2009-07-31 Thread Elliot Shank
David Cantrell wrote: On Fri, Jul 31, 2009 at 10:51:57AM -0700, Jonathan Swartz wrote: Is there a standard for signifying internal-only tests, and for make test to figure out when they should run? The normal way is to have them skip unless some magic environment variable is set. Perl::Criti

Re: standard for internal-only tests?

2009-07-31 Thread David E. Wheeler
On Jul 31, 2009, at 11:32 AM, Jonathan Swartz wrote: I've also started moving the tests themselves from MANIFEST to MANIFEST.skip Wow, putting them in MANIFEST.skip - what a simple and great idea. :) I don't even need the environment variable in that case. Anyone who is running 'make test

Re: standard for internal-only tests?

2009-07-31 Thread Jeffrey Thalhammer
On Jul 31, 2009, at 11:32 AM, Jonathan Swartz wrote: Anyone who is running 'make test' in the git source will see the internal tests, as they should...anyone who has the published distribution won't see them. IMHO, you should still include author-only tests in your published distributio

Re: standard for internal-only tests?

2009-07-31 Thread David Cantrell
On Fri, Jul 31, 2009 at 10:51:57AM -0700, Jonathan Swartz wrote: > There are certain tests in my distribution that I don't want end users > to run. I want to run them during development, and I also want anyone > else contributing to the distribution to run them. These are typically > related

Re: standard for internal-only tests?

2009-07-31 Thread Ricardo SIGNES
* Jonathan Swartz [2009-07-31T14:57:04] > Justin Devuyst kindly pointed me to > > Module::Install::AuthorTests > > which appears to have the desired behavior if one is using > Module::Install (which I happen to be). Thanks again. ...as long as you're looking at AuthorTests, have a look at i

Re: standard for internal-only tests?

2009-07-31 Thread Jonathan Swartz
On 07/31/2009 01:51 PM, Jonathan Swartz wrote: There are certain tests in my distribution that I don't want end users to run. I want to run them during development, and I also want anyone else contributing to the distribution to run them. These are typically related to static analysis of the

Re: standard for internal-only tests?

2009-07-31 Thread Jonathan Swartz
Justin Devuyst kindly pointed me to Module::Install::AuthorTests which appears to have the desired behavior if one is using Module::Install (which I happen to be). Thanks again. Jon On Jul 31, 2009, at 11:32 AM, Jonathan Swartz wrote: On 07/31/2009 01:51 PM, Jonathan Swartz wrote: The

Re: standard for internal-only tests?

2009-07-31 Thread Justin DeVuyst
Jon, You might want to take a look at Module::Install::AuthorTests as an example of one way to do it. -jdv Jonathan Swartz wrote: > There are certain tests in my distribution that I don't want end users > to run. I want to run them during development, and I also want anyone > else contributing t

Re: standard for internal-only tests?

2009-07-31 Thread David Golden
A common standard is to put them in an xt/ directory and run them during development with 'prove'. Regards, David On Jul 31, 2009 2:12 PM, "Jonathan Swartz" wrote: There are certain tests in my distribution that I don't want end users to run. I want to run them during development, and I also wa

Re: standard for internal-only tests?

2009-07-31 Thread Greg Sabino Mullane
On 07/31/2009 01:51 PM, Jonathan Swartz wrote: > There are certain tests in my distribution that I don't want end users > to run. I want to run them during development, and I also want anyone > else contributing to the distribution to run them. These are typically > related to static analysis of th

standard for internal-only tests?

2009-07-31 Thread Jonathan Swartz
There are certain tests in my distribution that I don't want end users to run. I want to run them during development, and I also want anyone else contributing to the distribution to run them. These are typically related to static analysis of the code, e.g. perl critic, perl tidy and pod che