Re: Test.pm does not return false on failed tests.

2006-11-01 Thread Michael G Schwern
David Golden wrote: > On 11/1/06, Michael G Schwern <[EMAIL PROTECTED]> wrote: >> Contact all the authors making use of it and suggest they switch to .t >> files. Maybe I could throw a warning into MakeMaker. Also a kwalitee >> check sounds like a good idea "not_only_test.pl" or something. > > I

Re: Test.pm does not return false on failed tests.

2006-11-01 Thread David Golden
On 11/1/06, Michael G Schwern <[EMAIL PROTECTED]> wrote: Contact all the authors making use of it and suggest they switch to .t files. Maybe I could throw a warning into MakeMaker. Also a kwalitee check sounds like a good idea "not_only_test.pl" or something. It shouldn't be "not_only". If

Re: Test.pm does not return false on failed tests.

2006-11-01 Thread Michael G Schwern
Jos Boumans wrote: > Hmm, I hope this doesn't mean you plan on removing the 'non-zero exit status > on failed make test'.. that's be a real PITA for automated installers... No, that is done by Test::Harness dying on test failure. >> Neither CPAN nor CPANPLUS are under any obligation to parse the

Re: Test.pm does not return false on failed tests.

2006-10-30 Thread Chris Dolan
On Oct 30, 2006, at 11:58 AM, Jos Boumans wrote: You're right, Test.pm does not, never has and does not have to. Exiting non-zero on failure is a little "feature" I put in to make using Test::More without Test::Harness a little easier but I plan on removing it. Hmm, I hope this doesn't m

Re: Test.pm does not return false on failed tests.

2006-10-30 Thread Jos Boumans
> Jos Boumans wrote: >> I got this bug report for CPANPLUS the other day, which turns out that >> Test.pm >> does not actually exit with a non-zero exitcode like Test::More does on >> failed tests: >> >> http://rt.cpan.org/Ticket/Display.html?id=22685 > > You're right, Test.pm does not, never has

Re: Test.pm does not return false on failed tests.

2006-10-30 Thread Chris Dolan
On Oct 30, 2006, at 11:34 AM, Michael G Schwern wrote: The solution is to get authors to stop using test.pl. That sounds like an important Kwalitee test to me! Chris -- Chris Dolan, Software Developer, Clotho Advanced Media Inc. 608-294-7900, fax 294-7025, 1435 E Main St, Madison WI 53703

Re: Test.pm does not return false on failed tests.

2006-10-30 Thread David Golden
On 10/30/06, Michael G Schwern <[EMAIL PROTECTED]> wrote: This is not Test.pm's fault but the fact that test.pl is not run through Test::Harness by MakeMaker.This is a historical accident. No, I won't change it. Many test.pl's do not output TAP. For example, DBI's test.pl contains bench

Re: Test.pm does not return false on failed tests.

2006-10-30 Thread Michael G Schwern
Jos Boumans wrote: > I got this bug report for CPANPLUS the other day, which turns out that > Test.pm > does not actually exit with a non-zero exitcode like Test::More does on > failed tests: > > http://rt.cpan.org/Ticket/Display.html?id=22685 You're right, Test.pm does not, never has and does

Re: Test.pm does not return false on failed tests.

2006-10-30 Thread Adrian Howard
On 30 Oct 2006, at 08:48, Jos Boumans wrote: Greetings, I got this bug report for CPANPLUS the other day, which turns out that Test.pm does not actually exit with a non-zero exitcode like Test::More does on failed tests: http://rt.cpan.org/Ticket/Display.html?id=22685 This means neither

Test.pm does not return false on failed tests.

2006-10-30 Thread Jos Boumans
Greetings, I got this bug report for CPANPLUS the other day, which turns out that Test.pm does not actually exit with a non-zero exitcode like Test::More does on failed tests: http://rt.cpan.org/Ticket/Display.html?id=22685 This means neither CPAN.pm nor CPANPLUS actually detect the fact that