Devel::Cover: completing $x{foo} ||= 1 conditions

2004-05-20 Thread Geoffrey Young
hi paul. I've found that in a statement like $x{foo} ||= 1; I can't ever satisfy the first condition in the "condition coverage" matrix (0,0) since 1 is always true. is it desirable to remove fixed truth values like this from the truth table? I tried taking a look at adding the condition t

Re: Devel::Cover: completing $x{foo} ||= 1 conditions

2004-05-20 Thread Paul Johnson
On Thu, May 20, 2004 at 04:34:39PM -0400, Geoffrey Young wrote: > hi paul. > > I've found that in a statement like > > $x{foo} ||= 1; > > I can't ever satisfy the first condition in the "condition coverage" matrix > (0,0) since 1 is always true. is it desirable to remove fixed truth values

Re: Devel::Cover: completing $x{foo} ||= 1 conditions

2004-05-20 Thread Geoffrey Young
> This is unlikely to be the only case in which I have not fully > understood the subtleties of the op tree, and so I am grateful for > reports such as this. I'll keep them coming, then :) > > The following patch should fix it, and will be in the next release, > hopefully coming next week: exce

Re: Devel::Cover: completing $x{foo} ||= 1 conditions

2004-05-20 Thread Paul Johnson
On Thu, May 20, 2004 at 08:08:19PM -0400, Geoffrey Young wrote: > well, I was trying to be a good citizen and provide a useful test case > (rather than a tarball that merely exhibited the issue). I did add And I appreciate it. > something to cond_or and ran 'make test TEST_FILES=t/acond_or.t' b