Re: is_deeply() and code refs

2005-06-30 Thread demerphq
On 6/30/05, Michael G Schwern <[EMAIL PROTECTED]> wrote: > On Thu, Jun 30, 2005 at 08:03:32AM +0200, demerphq wrote: > > Yitzchak pointed me to this thread. I thought I'd add that > > Data::Dump::Streamer v1.14 has the capability to Dump closures > > properly, that is including bound lexical state.

Re: is_deeply() and code refs

2005-06-30 Thread demerphq
On 6/30/05, demerphq <[EMAIL PROTECTED]> wrote: > Incidentally this is a pretty common mistake when handling REF's. > Data::Dumper does it as does YAML and pretty much all the other > storage tools that i have looked at, although Storable gets it right. > Also, i should say that while this circular

Fwd: [demerphq@gmail.com: Re: fixing is_deeply]

2005-06-30 Thread Michael G Schwern
Yves has some controversial ideas about what is and is not data structure equivalence. I'd like comments on it. - Forwarded message from demerphq <[EMAIL PROTECTED]> - From: demerphq <[EMAIL PROTECTED]> Date: Thu, 30 Jun 2005 23:17:19 +0200 To: Michael G Schwern <[EMAIL PROTECTED]> Subj

Re: Fwd: [demerphq@gmail.com: Re: fixing is_deeply]

2005-06-30 Thread Michael G Schwern
Yves wrote: > Ok, ive started work on this, however there is a minor problem: The > test in circular_refs regarding rt.cpan.org 11623. (I added names to > make it easier to work with.) > > { > # rt.cpan.org 11623 > # Make sure the circular ref checks don't get confused by a reference >

Re: is_deeply() and code refs

2005-06-30 Thread Michael G Schwern
On Thu, Jun 30, 2005 at 09:44:06AM +0200, demerphq wrote: > > Out of curiousity, if Data::Dumper::Streamer can handle > > closures why not fix B::Deparse? > > I'm not really sure what you mean by "fix" B::Deparse. B::Deparse does > exactly what it says it does: it deparses code. We can't consider

Re: Fwd: [EMAIL PROTECTED]: Re: fixing is_deeply]

2005-06-30 Thread Yitzchak Scott-Thoennes
On Thu, Jun 30, 2005 at 05:09:39PM -0700, Michael G Schwern wrote: > > So, I conclude that is_deeply()'s behavior is ok and something like > Test::Deep should be enhanced with an option to deal with this > problem. So, am I correct in understanding that is_deeply will only notice value difference

Re: Fwd: [EMAIL PROTECTED]: Re: fixing is_deeply]

2005-06-30 Thread demerphq
On 7/1/05, Michael G Schwern <[EMAIL PROTECTED]> wrote: > After talking with Ovid some in the kitchen I'm of the opinion that > is_deeply() is currently doing the right thing and that these tests cannot > go. Largely it comes down to the Principle of Least Surprise. I cant agree with this analysi

Re: Fwd: [EMAIL PROTECTED]: Re: fixing is_deeply]

2005-06-30 Thread demerphq
On 7/1/05, demerphq <[EMAIL PROTECTED]> wrote: > The question you have to ask yourself is why should a reference be > treated different from any other value? It is a VALUE. > IE: why should In the following part i meant to make it more clear: by changing this line > > $x=1;$y=2;$z=3; to $

Re: is_deeply() and code refs

2005-06-30 Thread demerphq
On 7/1/05, Michael G Schwern <[EMAIL PROTECTED]> wrote: > On Thu, Jun 30, 2005 at 09:44:06AM +0200, demerphq wrote: > > > Out of curiousity, if Data::Dumper::Streamer can handle > > > closures why not fix B::Deparse? > > > > I'm not really sure what you mean by "fix" B::Deparse. B::Deparse does > >