Re: [PATCH t/op/misc.t] cleanup

2001-09-02 Thread Jarkko Hietaniemi
@@ -739,3 +783,9 @@ # keep this last - doesn't seem to work otherwise? This requirement magically went away while I was away? eval a.b.c.d.e.f;sub EXPECT + + perlbug ID 20010831.001 +($a, b) = (1, 2); +EXPECT +Can't modify constant item in list assignment at - line 1, near

Re: installhtml needs a good beating out

2001-10-19 Thread Jarkko Hietaniemi
Once you've done that you can add Refactoring to the list of buzzwords on your resume. :) I think installhtml teeters heavily on the brink of Rewriting instead of Refactoring. It hasn't changed much since 1997. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist

Re: [PATCH lib/Net/Config.pm, MANIFEST, t/lib/Mock/Socket.pm, lib/Net/Config.t] Add Tests for Net::Config

2001-10-20 Thread Jarkko Hietaniemi
Here's a test suite for Net::Config. In the process of writing this, I've fixed an apparent bug that prevented single values from becoming array references when necessary. I think it's right, but perhaps Graham should weigh in on this. In the process, with some advice from perl-qa, I've

Re: [PATCH t/test.pl] Adding isnt() and next_test()

2001-11-06 Thread Jarkko Hietaniemi
On Tue, Nov 06, 2001 at 08:58:45PM -0500, Michael G Schwern wrote: In the course of revamping t/io/argv.t for VMS, I've added two functions to t/test.pl. isnt() is useful for replacing this sort of thing: print not unless defined $foo; print ok 42\n; with isnt($foo,

Re: Make Schwern Poor before 5.8.0

2001-11-20 Thread Jarkko Hietaniemi
On Tue, Nov 20, 2001 at 03:54:05PM -0600, Dave Rolsky wrote: On Tue, 20 Nov 2001, Tels wrote: If you would prefer to handle the ExtUtils::MakeMaker and ExtUtils::MM_* changes yourself let me know. You can do it. I'll wait until the dust settles (I wrote tests for routines that now

Re: [PATCH] Add test for Pod::ParseUtils

2001-11-20 Thread Jarkko Hietaniemi
On Tue, Nov 20, 2001 at 02:33:14PM -1000, Tim Jenness wrote: Here is a new test script for Pod::ParseUtils. I was mainly concerned with the link parsing. There is a good chance that Pod::ParseUtils is currently doing the wrong thing in some cases. Most obvious to me is that Lsome

Re: [PATCH t/op/misc.t] cleanup

2001-09-02 Thread Jarkko Hietaniemi
I think the wholesale renaming of t/op/misc as t/run/kill_perl is really wrong. (I think you are reading too much into the leading comments, and other people have been reading too little into them.) t/op/misc has NOT consistently been the place for core-dumping tests; it has some yes, but not

Re: Untested modules update: The Magic Number is 27

2001-12-29 Thread Jarkko Hietaniemi
On Thu, Dec 27, 2001 at 02:58:56PM -0500, Michael G Schwern wrote: Dynaloader has a good sized documented interface which isn't necessarily exercised by the core modules. Test that. Remember to test DynaLoader with miniperl, though, otherwise you are cheating. And not fair testing

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
On Fri, Jan 11, 2002 at 04:26:27AM -0500, Michael G Schwern wrote: As long ago promised, here's a patch to pull the logic out of t/run/kill_perl.t and make it into a t/test.pl function. This means its no longer necessary to pile segfault checks into t/run/kill_perl.t. They can be placed in

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
PS There was also a bug in runperl(). All switches were being lost. Well, this change made several tests (like run/switches) to barf. So I backed out that hunk. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for 'stable'. # It is 'dead'. --

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
On Fri, Jan 11, 2002 at 05:18:10PM +0200, Jarkko Hietaniemi wrote: PS There was also a bug in runperl(). All switches were being lost. Well, this change made several tests (like run/switches) to barf. So I backed out that hunk. Urk, so now three of kill_perl tests tests are failing

Re: VMS status @14710

2002-02-15 Thread Jarkko Hietaniemi
t/op/glob.t The test that is failing is: # ... while ($var = glob(...)) should test definedness not truth my $ok = not ok 8\n; $ok = ok 8\n while my $var = glob(0); print $ok; This test massively confuses me. What is the meaning of the 0 in Cglob(0)? As far as I can see we