Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 224c53df969893d76a3d94c4ce4e3684925f36a8
      
https://github.com/Perl/perl5/commit/224c53df969893d76a3d94c4ce4e3684925f36a8
  Author: Tony Cook <t...@develop-help.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    M win32/win32.c

  Log Message:
  -----------
  win32.c: suppress -Wcast-function-type warnings

This appears to be the only place these warnings are produced even
though win32/win32.c contains several other function type casts.

None of the non-warning casts use the "void (*)(void)" type that is
documented to suppress the warning, and adding such a cast to
the lines warning seems less safe to me, cast from a stdcall
function pointer to a cdecl function pointer and back.

So, just suppress the warning where I saw it.


  Commit: a33729fe9919fce96c2a5fd196825c4208b2cbe2
      
https://github.com/Perl/perl5/commit/a33729fe9919fce96c2a5fd196825c4208b2cbe2
  Author: Tony Cook <t...@develop-help.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    M win32/win32.c

  Log Message:
  -----------
  win32.c: don't call wcscpy() with in == out

Since both the input and output parameters are restrict qualified,
this would be invalid, and it is possibe for PerlDir_mapW() to return
its parameter.  This warned on gcc:

win32.c: In function 'win32_link':
win32.c:3712:40: warning: passing argument 1 to 'restrict'-qualified parameter 
aliases with argument 2 [-Wrestrict]
 3712 |         ((aTHXa(PERL_GET_THX)), wcscpy(wOldName, 
PerlDir_mapW(wOldName)),
      |                                        ^~~~~~~~


Compare: https://github.com/Perl/perl5/compare/0e766d6b46e9...a33729fe9919

To unsubscribe from these emails, change your notification settings at 
https://github.com/Perl/perl5/settings/notifications

Reply via email to