Branch: refs/heads/blead Home: https://github.com/Perl/perl5 Commit: 564b0c90d4a5f7c04ed173bd9bac8d4241a9acb3 https://github.com/Perl/perl5/commit/564b0c90d4a5f7c04ed173bd9bac8d4241a9acb3 Author: Yves Orton <demer...@gmail.com> Date: 2023-04-05 (Wed, 05 Apr 2023)
Changed paths: M embed.fnc M embed.h M proto.h M regen/HeaderParser.pm Log Message: ----------- regen/HeaderParser.pm - with multi-term expressions put least first if we have defined(X) && (defined(Y) || defined(Z)) put the defined(X) first because it has less operations in it. Commit: 9d18cc1309653402735f34cc33436853730b54fa https://github.com/Perl/perl5/commit/9d18cc1309653402735f34cc33436853730b54fa Author: Yves Orton <demer...@gmail.com> Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M embed.fnc Log Message: ----------- embed.fnc - remove incorrect comment which in turn allows the nested if clauses to be merged Commit: 0398b69bfddc8738a4788f056a79ba9e4d44fcfb https://github.com/Perl/perl5/commit/0398b69bfddc8738a4788f056a79ba9e4d44fcfb Author: Yves Orton <demer...@gmail.com> Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M embed.fnc M embed.h M embedvar.h M proto.h M regen/HeaderParser.pm Log Message: ----------- regen/HeaderParser.pm - remove comments from elif/else/endif when the contents is short it is a bit "noisy" to have comments that duplication the conditions when the original line with the condition is visible on the screen at the same time. this patch changes the rules so we only add these comments when the clause is 10 lines or more from its prior Commit: 67d37c55ddffebbcbf4847408106334b9ad9a6bc https://github.com/Perl/perl5/commit/67d37c55ddffebbcbf4847408106334b9ad9a6bc Author: Yves Orton <demer...@gmail.com> Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M embed.fnc M embed.h M proto.h M regen/HeaderParser.pm M t/porting/header_parser.t Log Message: ----------- regen/HeaderParser.pm - improved expression formatting and wrapping Karl complained about some of the wrapping logic we use for expressions. This tweaks the rules in a number of different ways in an attempt to produce more legible expressions. For instance if we have a complex expression with different parenthesized sub expressions, then try to put each sub expression on its own line. A previous patch ensures that we put shorter sub expressions first, and this patch builds on that to put each sub expression on its own line. We also use different logic to wrap the expressions, with the end result that each line should have the same number of defined() operations on it (with the exception of the last). We also try harder to line up logical operators and defined() functions. Compare: https://github.com/Perl/perl5/compare/113cefaa4a73...67d37c55ddff