Branch: refs/heads/arc/smaller-toke-bis Home: https://github.com/Perl/perl5 Commit: c47310b95b337f3fd96285730e68de4495276354 https://github.com/Perl/perl5/commit/c47310b95b337f3fd96285730e68de4495276354 Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019)
Changed paths: M toke.c Log Message: ----------- toke.c: factor out static yyl_fake_eof() Commit: 0f4ae15b4b18ad29563ca07b38873abd50f5ff6f https://github.com/Perl/perl5/commit/0f4ae15b4b18ad29563ca07b38873abd50f5ff6f Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: factor out static yyl_fatcomma() This removes a goto label. Commit: a6e541947758095d123dcb38f9240bbe37d2854f https://github.com/Perl/perl5/commit/a6e541947758095d123dcb38f9240bbe37d2854f Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: fold some initialisations into the corresponding declarations Commit: 1e0528058bbcbb226a60aef29352e0ce755dd803 https://github.com/Perl/perl5/commit/1e0528058bbcbb226a60aef29352e0ce755dd803 Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: factor out static yyl_safe_bareword() Commit: ebc0ce61a31021bcb34b9747e535f53421c929d8 https://github.com/Perl/perl5/commit/ebc0ce61a31021bcb34b9747e535f53421c929d8 Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: factor out static yyl_constant_op() With the removal of another goto label! Commit: 3e79f1943c66a4ef244358506b49a7527fb64333 https://github.com/Perl/perl5/commit/3e79f1943c66a4ef244358506b49a7527fb64333 Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: remove the really_sub goto label This permits some additional pleasing simplifications. Commit: 24322871f92582d5acb74a5b9adb84575f7da72b https://github.com/Perl/perl5/commit/24322871f92582d5acb74a5b9adb84575f7da72b Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: factor out static yyl_strictwarn_bareword() Commit: ca8f4a8e4338c1090bfc6004327c69427925c9eb https://github.com/Perl/perl5/commit/ca8f4a8e4338c1090bfc6004327c69427925c9eb Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: stop passing around several needless local variables I introduced these parameters as part of mechanically refactoring goto-heavy logic into subroutines. However, they aren't actually needed through most of the code. Even in the recursive case (in which yyl_try() or one of its callees will call itself), we can reset the variables to zero. Commit: 64aaff026db714ee5ad08ef42027ae1d0caee8ab https://github.com/Perl/perl5/commit/64aaff026db714ee5ad08ef42027ae1d0caee8ab Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: factor out static yyl_just_a_word() Commit: 4fccb321ce8d1f1bf6a11b559b0a11fa885ce216 https://github.com/Perl/perl5/commit/4fccb321ce8d1f1bf6a11b559b0a11fa885ce216 Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: bundle some yyl_just_a_word() params into a struct This makes calls to it much easier to understand. Commit: a4f5f66558a5d1c496dbe22d521bae7f309f917f https://github.com/Perl/perl5/commit/a4f5f66558a5d1c496dbe22d521bae7f309f917f Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: factor out static yyl_key_core() and yyl_word_or_keyword() Commit: fa94b578e4054ce189d549aa9e1da5745362d99e https://github.com/Perl/perl5/commit/fa94b578e4054ce189d549aa9e1da5745362d99e Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: factor out static yyl_keylookup() Commit: dcbf99d96da623f2ef59a49fe77128fe591e818c https://github.com/Perl/perl5/commit/dcbf99d96da623f2ef59a49fe77128fe591e818c Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: delete weird initial_state arg to yyl_try() I thought I was going to end up using this for more stuff, but I've found better approaches. This commit also removes two more goto targets. Commit: c0c5e23174b343d371a2b50f437a41b3486e034b https://github.com/Perl/perl5/commit/c0c5e23174b343d371a2b50f437a41b3486e034b Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: remove formbrack argument from yyl_try() With this commit, yyl_try() has few enough arguments that the RETRY() macro no longer serves any useful purpose; delete it too. Commit: 5b820090dba8cbf875d6693d1d7b2eb5a329423c https://github.com/Perl/perl5/commit/5b820090dba8cbf875d6693d1d7b2eb5a329423c Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: remove some spurious orig_keyword uses Commit: c002598b6db34a97a2cc77a35785d781fa73b977 https://github.com/Perl/perl5/commit/c002598b6db34a97a2cc77a35785d781fa73b977 Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: don't pass around a copy of PL_parser->saw_infix_sigil There's exactly one place where we need to consult it (and that only for producing good error messages in a specific group of term-after-term situations). The reason for passing it around was so that it could be reset to false early on in the process of lexing a token, while then allowing the three separate cases that might need to set it true to do so independently. Instead, centralise the logic of determining when it needs to be true. Commit: 6103c5c1e3dfaa320ad78656fce3967e2f7c7dc5 https://github.com/Perl/perl5/commit/6103c5c1e3dfaa320ad78656fce3967e2f7c7dc5 Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M toke.c Log Message: ----------- toke.c: delete unused bof parameters Commit: 0f2b6d50ec2bed656090bf2e35c22e8a2f975641 https://github.com/Perl/perl5/commit/0f2b6d50ec2bed656090bf2e35c22e8a2f975641 Author: Aaron Crane <a...@cpan.org> Date: 2019-10-30 (Wed, 30 Oct 2019) Changed paths: M pod/perldelta.pod Log Message: ----------- perldelta for recent toke.c refactoring Compare: https://github.com/Perl/perl5/compare/f2a2147ae0b0...0f2b6d50ec2b