Branch: refs/heads/smoke-me/khw-hvds_pr
Home: https://github.com/Perl/perl5
Commit: e9236d941d16b4928d781e39c1149bef99182227
https://github.com/Perl/perl5/commit/e9236d941d16b4928d781e39c1149bef99182227
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move test earlier in regpiece()
Prior to this commit, the code checked if this was a particular
quantifier; if so handled that, then checked if it were some other
quantifier, returning if not.
This commit changes to check first if it is any quantifier, using the
macro that checks for all of them, returning if not.
Thus after the new code we know it is a quantifier and this allows later
commits to simplify
Commit: 50c6f0de5563dfd925cda578cb484c6a9f91e574
https://github.com/Perl/perl5/commit/50c6f0de5563dfd925cda578cb484c6a9f91e574
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Combine common code
This bit of code occurs in two places. Move it so that it gets executed
before the split, so it only has to be specified once.
Commit: 2748817ba3b3bacf7ad75dbc10252aab875f431f
https://github.com/Perl/perl5/commit/2748817ba3b3bacf7ad75dbc10252aab875f431f
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: White-space only
Outdent since the previous commit removed a surrounding block
Commit: 23db22071d0eb9a9f6dfddcd5c3a47a2139af2c6
https://github.com/Perl/perl5/commit/23db22071d0eb9a9f6dfddcd5c3a47a2139af2c6
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move some code in regpiece()
This moves some code, making it part of an if/else. As a result, several
gotos are eliminated, and the code is in a more logical order.
Commit: 54e9618053fa9615157435e0705457fd8c1d44ee
https://github.com/Perl/perl5/commit/54e9618053fa9615157435e0705457fd8c1d44ee
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: White-space only
Outdent since the previous commit removed a surrounding block.
And convert some tabs to blanks
Commit: fdd33d759909800868155f10e524eeff235da22f
https://github.com/Perl/perl5/commit/fdd33d759909800868155f10e524eeff235da22f
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Rmv misleading comment
This NOTREACHED's presence just before an else would make one think
there is something funny going one, when there isn't.
Commit: dc081c9dc76024031aafe08f868d75057bad7db7
https://github.com/Perl/perl5/commit/dc081c9dc76024031aafe08f868d75057bad7db7
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Move code to earlier in regpiece()
This is in preparation for a future commit that will change things so
this would need to be done earlier than the changes.
Commit: 5b033cae81421bfcba6b0b0820e00a9359ce23cc
https://github.com/Perl/perl5/commit/5b033cae81421bfcba6b0b0820e00a9359ce23cc
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Rmv #if 0 bitrotted code
This code has been #ifdef'd out for 20 years, and shows bit rot. It was
kept around in case there was a problem with the replacement for it, but
that hasn't happened and is very unlikely to happen; in the meantime
this is a visual distraction to the code flow.
Commit: 17bb91393b990a09528189b6a6898fa3e0f24fe4
https://github.com/Perl/perl5/commit/17bb91393b990a09528189b6a6898fa3e0f24fe4
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece() Don't match 0 length more than once
There's no point in matching something more than once that doesn't
advance the parse, as long as there are no side effects beyond those
from the first match. Those could only happen in code blocks, which
this code doesn't have.
Commit: 1a1fdb63452e4de078425263a87e6846930f2f8f
https://github.com/Perl/perl5/commit/1a1fdb63452e4de078425263a87e6846930f2f8f
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece() 0 times anything is 0
Prior to this commit, regpiece() gave width to many quantified values.
This is wrong. If something is zero width, repeating it doesn't cause
it to gain width. I don't know if this led to wrong pattern matching
results, but I imagine it led to slower results in some cases.
Commit: e1db24724ea375eef152594e7f029483209bc8d6
https://github.com/Perl/perl5/commit/e1db24724ea375eef152594e7f029483209bc8d6
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): Pass along that is a code block
regpiece was failing to pass up to its caller that a piece of code
contained a code block, if that code was quantified.
I don't know what the consequences of this are
Commit: 5a61d9d5dd01e6a522e5665f4a7af2bc631585ec
https://github.com/Perl/perl5/commit/5a61d9d5dd01e6a522e5665f4a7af2bc631585ec
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: Change label name; rmv extraneous goto
The name was misleading. There are other things being done here. And
previous restructuring led to a goto immediately prior to where it went
to.
Commit: 36b74ae2fbbb36df79a6b5d8f5437315ef82dff9
https://github.com/Perl/perl5/commit/36b74ae2fbbb36df79a6b5d8f5437315ef82dff9
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece: Consolidate code
There is a common place these three occurrences can be placed at,
Commit: abaf3abdb404dbb22cb0b45b6874c21e68679998
https://github.com/Perl/perl5/commit/abaf3abdb404dbb22cb0b45b6874c21e68679998
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): Refactor two 'if's
I think this makes it clearer the commonalities of the * and +
quantifiers.
Commit: ef241881aee84c0aaae052925b6c54611b2d5ab7
https://github.com/Perl/perl5/commit/ef241881aee84c0aaae052925b6c54611b2d5ab7
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): More comments; white-space
Commit: 1fa2ed11839f4fe837d9e71d30db5aed4c11cda0
https://github.com/Perl/perl5/commit/1fa2ed11839f4fe837d9e71d30db5aed4c11cda0
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: regpiece(): Convert to a switch() stmt
This makes the code easier to understand, I think.
Commit: 2b41f87d5e43a4d3714a0afd1e9e83352aa2a46e
https://github.com/Perl/perl5/commit/2b41f87d5e43a4d3714a0afd1e9e83352aa2a46e
Author: Karl Williamson <k...@cpan.org>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M regcomp.c
Log Message:
-----------
regcomp.c: White-space only
Change indentation to correspond with new blocks formed by the previous
commit
Compare: https://github.com/Perl/perl5/compare/a10f7666b9ff...2b41f87d5e43
