In perl.git, the branch maint-5.20-votes has been updated <http://perl5.git.perl.org/perl.git/commitdiff/f45e05d6cf12eaf246bc35aba4c623d4c54ae09c?hp=743c65f5a4260710b56b5f85dc9de535a92aa5df>
- Log ----------------------------------------------------------------- commit f45e05d6cf12eaf246bc35aba4c623d4c54ae09c Author: Aaron Crane <a...@cpan.org> Date: Sun Aug 9 17:53:48 2015 +0100 Votes for some 5.20.3-candidate commits ----------------------------------------------------------------------- Summary of changes: Porting/cherry-pick-votes-maint-5.20.xml | 86 +++++++++++++++++--------------- 1 file changed, 45 insertions(+), 41 deletions(-) diff --git a/Porting/cherry-pick-votes-maint-5.20.xml b/Porting/cherry-pick-votes-maint-5.20.xml index 330aef9..c842ad7 100644 --- a/Porting/cherry-pick-votes-maint-5.20.xml +++ b/Porting/cherry-pick-votes-maint-5.20.xml @@ -5,21 +5,23 @@ <div><h2>Tickets Listed in #123921: 5.20.3 blockers</h2> The leak isn't in blead so there is no blead commit to cherry-pick. The voting here relates to the two patches by Tony C on the ticket. -- steveh -<commit votes="steveh,tonyc" id="" ticket="123786" desc="'use utf8;' leaks memory"/> +AFAICT, the second patch on its own is both necessary and sufficient to fix the leak; valgrind reports an invalid free when both patches are applied. -- arc +<commit votes="steveh,tonyc,arc" id="" ticket="123786" desc="'use utf8;' leaks memory"/> -<commit votes="steveh,tonyc" id="c0388966161bb22622ebac402bb1ebe081ad0b39" ticket="123976" desc="[Win32] Unable to build 64-bit blead using gcc-4.8.2"/> +<commit votes="steveh,tonyc,arc" id="c0388966161bb22622ebac402bb1ebe081ad0b39" ticket="123976" desc="[Win32] Unable to build 64-bit blead using gcc-4.8.2"/> -<commit votes="" id="3553f4fa11fd9e8bb0797ace43605cc33ebf32fa" ticket="124109" desc="panic: swash_fetch got swatch of unexpected bit width"/> -<commit votes="" id="4e0341d2ce817c9956f7f78e36bcaf8b764e18fc" ticket="124109" desc="panic: swash_fetch got swatch of unexpected bit width"/> +I believe DaveM has expressed a vote for these, in https://rt.perl.org/Public/Bug/Display.html?id=124109#txn-1338401 -- arc +<commit votes="arc" id="3553f4fa11fd9e8bb0797ace43605cc33ebf32fa" ticket="124109" desc="panic: swash_fetch got swatch of unexpected bit width"/> +<commit votes="arc" id="4e0341d2ce817c9956f7f78e36bcaf8b764e18fc" ticket="124109" desc="panic: swash_fetch got swatch of unexpected bit width"/> -<commit votes="tonyc" id="816b056ffb99ae54642320e20dc30a59fd1effef" ticket="123784" desc="Tests fail with GCC 5.0 because Errno cannot obtain errno constants"/> -<commit votes="tonyc" id="3bea78d24634e630b610f59957e7a019205a67b2" ticket="123784" desc="Tests fail with GCC 5.0 because Errno cannot obtain errno constants"/> -<commit votes="tonyc" id="33593911f214382b592d05aa902655301915e666" ticket="123784" desc="Tests fail with GCC 5.0 because Errno cannot obtain errno constants"/> +<commit votes="tonyc, arc" id="816b056ffb99ae54642320e20dc30a59fd1effef" ticket="123784" desc="Tests fail with GCC 5.0 because Errno cannot obtain errno constants"/> +<commit votes="tonyc, arc" id="3bea78d24634e630b610f59957e7a019205a67b2" ticket="123784" desc="Tests fail with GCC 5.0 because Errno cannot obtain errno constants"/> +<commit votes="tonyc, arc" id="33593911f214382b592d05aa902655301915e666" ticket="123784" desc="Tests fail with GCC 5.0 because Errno cannot obtain errno constants"/> -<commit votes="steveh,tonyc" id="41ef2c66e0da6dfb04ded81b979f7081007a1add" ticket="124127" desc="Restore ability to debug threaded scripts"/> -<commit votes="steveh,tonyc" id="f80262130b14af7d62281372d55e93f84e2a16b7" ticket="124127" desc="James McCoy is now a perl AUTHOR"/> -<commit votes="steveh,tonyc" id="67a38f64602c1e8bbf6b6e5d21455c3f5df90f01" ticket="124127" desc="bump perl5db.pl's $VERSION"/> -<commit votes="steveh,tonyc" id="902d16915db2735c3a41f15ef8d95cf300c31801" ticket="124127" desc="Restore ability to debug threaded scripts"/> +<commit votes="steveh,tonyc,arc" id="41ef2c66e0da6dfb04ded81b979f7081007a1add" ticket="124127" desc="Restore ability to debug threaded scripts"/> +<commit votes="steveh,tonyc,arc" id="f80262130b14af7d62281372d55e93f84e2a16b7" ticket="124127" desc="James McCoy is now a perl AUTHOR"/> +<commit votes="steveh,tonyc,arc" id="67a38f64602c1e8bbf6b6e5d21455c3f5df90f01" ticket="124127" desc="bump perl5db.pl's $VERSION"/> +<commit votes="steveh,tonyc,arc" id="902d16915db2735c3a41f15ef8d95cf300c31801" ticket="124127" desc="Restore ability to debug threaded scripts"/> </div> @@ -49,25 +51,26 @@ The same criteria apply to code in dual-life modules as to core code.) I feel a bit leery about this next one. The code is a bit fragile, so I would feel more comfortable with a couple monthsâ blead smoking. But the blead implementation changed shortly after that com ... [13 chars truncated] <commit votes="steveh" id="db5cc3ee5bdb14c8d59302b6c3ef8ff4bca660bb" ticket="" desc="Fix crash in leave_scope when my sub has CvGV"/> -<commit votes="steveh" id="83a85f49e265a458a481a9dc402dd3bdd30ae457" ticket="123711" desc="[perl #123711] Fix crash with 0-5x-l{0}"/> +<commit votes="steveh, arc" id="83a85f49e265a458a481a9dc402dd3bdd30ae457" ticket="123711" desc="[perl #123711] Fix crash with 0-5x-l{0}"/> Both of the following should be applied, or neither -- tonyc. -<commit votes="steveh,tonyc" id="5fe499a8e26270679c0c6d48431f3a328a8ffeba" ticket="123218" desc="[perl #123218] 'preserve' $/ if set to a bad value"/> -<commit votes="steveh,tonyc" id="ddce084af02764d4f30ef6089ae67a7983fcc690" ticket="123739" desc="Remove get-magic from $/"/> +<commit votes="steveh,tonyc,arc" id="5fe499a8e26270679c0c6d48431f3a328a8ffeba" ticket="123218" desc="[perl #123218] 'preserve' $/ if set to a bad value"/> +<commit votes="steveh,tonyc,arc" id="ddce084af02764d4f30ef6089ae67a7983fcc690" ticket="123739" desc="Remove get-magic from $/"/> The second of the following 2 depends on the first being applied -- tonyc. -<commit votes="steveh,tonyc" id="8d28fc8f69270cc75d9564b369ac6008c5b5d617" ticket="123748" desc="[perl #123748] - Add test case for possible getenv/putenv/setenv stomping in perl.c"/> -<commit votes="steveh,tonyc" id="7f8f1c2613d1d5df0b1071bd5fe3eec808c4a69e" ticket="123748" desc="Fix quoting in new switchd.t test."/> +<commit votes="steveh,tonyc,arc" id="8d28fc8f69270cc75d9564b369ac6008c5b5d617" ticket="123748" desc="[perl #123748] - Add test case for possible getenv/putenv/setenv stomping in perl.c"/> +<commit votes="steveh,tonyc,arc" id="7f8f1c2613d1d5df0b1071bd5fe3eec808c4a69e" ticket="123748" desc="Fix quoting in new switchd.t test."/> -<commit votes="steveh,tonyc" id="175c4cf98f8ca99cd4f626369ef0beb1d69f8ce5" ticket="123748" desc="locale.c: savepv() of getenv()"/> -<commit votes="steveh,tonyc" id="9e0b0d62ba5a660ab4b6f498912cfaead79014a0" ticket="123748" desc="perl.c: Don't read possibly zapped memory"/> +<commit votes="steveh,tonyc,arc" id="175c4cf98f8ca99cd4f626369ef0beb1d69f8ce5" ticket="123748" desc="locale.c: savepv() of getenv()"/> +<commit votes="steveh,tonyc,arc" id="9e0b0d62ba5a660ab4b6f498912cfaead79014a0" ticket="123748" desc="perl.c: Don't read possibly zapped memory"/> +If a reasonable way is found to make the new test in d27f4 pass in maint, I'll be +1 on these. But I'm not convinced that it's worth making this change to maint to fix a compile-time-only bug if we k ... [46 chars truncated] <commit votes="steveh" id="e47d32dcd59a578274f445fac79e977d83055c8c" ticket="123712" desc="[perl #123712] Fix /$a[/ parsing"/> This commit (d27f4)'s new test is failing in a dry-run of cherry-picking into maint -- steveh: <commit votes="steveh" id="d27f4b916ce5819f564bdd4a135137c457156333" ticket="123712" desc="[perl #123712] Don't check sub_inwhat"/> -<commit votes="steveh" id="1956db7ee60460e5b4a25c19fda4999666c8cbd1" ticket="124156" desc="RT #124156: death during unwinding causes crash"/> -<commit votes="steveh" id="46b27d2f2c37f40dde845f9b4743975c69f2cc27" ticket="123398" desc="don't fatalize warnings during unwinding (#123398)"/> +<commit votes="steveh, arc" id="1956db7ee60460e5b4a25c19fda4999666c8cbd1" ticket="124156" desc="RT #124156: death during unwinding causes crash"/> +<commit votes="steveh, arc" id="46b27d2f2c37f40dde845f9b4743975c69f2cc27" ticket="123398" desc="don't fatalize warnings during unwinding (#123398)"/> </div> @@ -123,34 +126,35 @@ Does this need d9a13252ba5aad7b3eaaff069b56472cfb651a40 too? -- steveh <div><h3>Regression Fixes</h3> -<commit votes="tonyc" id="bae8cfc6926f9b04d8adac6a9ee6d563cc18263f" ticket="125121" desc="Don't treat setpgrp($nonzero) as setpgrp(1)"/> -<commit votes="steveh" id="0fa70a06a98fc8fa9840d4dbaa31fc2d3b28b99b" ticket="123743" desc="simpify and speed up /.*.../ handling"/> -<commit votes="steveh,tonyc" id="ed38223246c041b4e9ce5687cadf6f6b903050ca" ticket="123202" desc="[perl #123202] speed up scalar //g against tainted strings"/> -<commit votes="steveh,tonyc" id="71622e40793536aa4f2ace7ffc704cc78151fd26" ticket="" desc="Stop $^H |= 0x1c020000 from enabling all features"/> +<commit votes="tonyc, arc" id="bae8cfc6926f9b04d8adac6a9ee6d563cc18263f" ticket="125121" desc="Don't treat setpgrp($nonzero) as setpgrp(1)"/> +<commit votes="steveh, arc" id="0fa70a06a98fc8fa9840d4dbaa31fc2d3b28b99b" ticket="123743" desc="simpify and speed up /.*.../ handling"/> +<commit votes="steveh,tonyc,arc" id="ed38223246c041b4e9ce5687cadf6f6b903050ca" ticket="123202" desc="[perl #123202] speed up scalar //g against tainted strings"/> +<commit votes="steveh,tonyc,arc" id="71622e40793536aa4f2ace7ffc704cc78151fd26" ticket="" desc="Stop $^H |= 0x1c020000 from enabling all features"/> -<commit votes="steveh,tonyc" id="b3089e964c0afaf7eb8d54aa5a912e4eb2e6c176" ticket="124113" desc="[perl #124113] Make check for multi-dimensional arrays be UTF8-aware"/> -<commit votes="steveh,tonyc" id="6e59c8626d31f697a2b7b36cf8a200b36d93eac2" ticket="124113" desc="Allow unquoted UTF-8 HERE-document terminators"/> -<commit votes="steveh,tonyc" id="8ce2ba821761a7ada1e1def512c0374977759cf7" ticket="124113" desc="Fix '...without parentheses is ambuguous' warning for UTF-8 function names"/> +<commit votes="steveh,tonyc,arc" id="b3089e964c0afaf7eb8d54aa5a912e4eb2e6c176" ticket="124113" desc="[perl #124113] Make check for multi-dimensional arrays be UTF8-aware"/> +<commit votes="steveh,tonyc,arc" id="6e59c8626d31f697a2b7b36cf8a200b36d93eac2" ticket="124113" desc="Allow unquoted UTF-8 HERE-document terminators"/> +<commit votes="steveh,tonyc,arc" id="8ce2ba821761a7ada1e1def512c0374977759cf7" ticket="124113" desc="Fix '...without parentheses is ambuguous' warning for UTF-8 function names"/> </div> <div><h3>Build and Installation Fixes</h3> The following allows the other hv_func.h patch below to apply cleanly and fixes a real bug. I've voted for the second, but the conflict resolution for that will effectively apply the first, so not ap ... [15 chars truncated] -<commit votes="tonyc" id="54e07e2b21cb1f58c04d67bca2a311715ba8815e" ticket="" desc="hv_func.h - fix seed initialization in sdbm and djb2 hashing algorithms."/> +<commit votes="tonyc, arc" id="54e07e2b21cb1f58c04d67bca2a311715ba8815e" ticket="" desc="hv_func.h - fix seed initialization in sdbm and djb2 hashing algorithms."/> <commit votes="steveh, khw, tonyc" id="b404539126a567987b4748a67c06be2d23b471d5" ticket="123483" desc="silence VC Win64 perl warnings in hv_func.h"/> -<commit votes="steveh" id="f33b2f585292653a3c50ea39cbdab734c3473fcb" ticket="" desc="handle existing mkstemp() in mingw-w64-v4"/> -<commit votes="steveh" id="6378109479f5b474e8205c8478f484b209078772" ticket="" desc="add new address for kmx"/> +On the mailing list (http://www.nntp.perl.org/group/perl.perl5.porters/2015/05/msg227963.html et seqq) Tony says that f33b2f5 is incorrect, because it edits a generated file rather than that file's s ... [302 chars truncated] +<commit votes="steveh, arc" id="f33b2f585292653a3c50ea39cbdab734c3473fcb" ticket="" desc="handle existing mkstemp() in mingw-w64-v4"/> +<commit votes="steveh, arc" id="6378109479f5b474e8205c8478f484b209078772" ticket="" desc="add new address for kmx"/> </div> <div><h3>Portability Fixes</h3> -<commit votes="tux, khw" id="237050634b19905cdd9e8e25c2a43d0b24eb59f2" ticket="" desc="Add pthread to libswanted"/> -<commit votes="tux, khw" id="90207ba1bd77fb10e2c39594d954b43a9e8ee948" ticket="" desc="Put pthread in front of libswanted and add cl"/> +<commit votes="tux, khw, arc" id="237050634b19905cdd9e8e25c2a43d0b24eb59f2" ticket="" desc="Add pthread to libswanted"/> +<commit votes="tux, khw, arc" id="90207ba1bd77fb10e2c39594d954b43a9e8ee948" ticket="" desc="Put pthread in front of libswanted and add cl"/> -<commit votes="tonyc" id="0cf583b0808e2fb2ac90751d506f2b8ff75aed86" ticket="" desc="uname -r works on MINIX as well"/> +<commit votes="tonyc, arc" id="0cf583b0808e2fb2ac90751d506f2b8ff75aed86" ticket="" desc="uname -r works on MINIX as well"/> </div> @@ -160,17 +164,17 @@ The following allows the other hv_func.h patch below to apply cleanly and fixes <div><h3>Documentation Fixes</h3> -<commit votes="steveh,tonyc" id="730d89736d0ae5dfc7580108c451efe91b5102fc" ticket="" desc="Fix warning message regarding 'use autodie' and 'use open'."/> -<commit votes="steveh,tonyc" id="2a403855670ae8592c5a3ca4396e6e909a4fc593" ticket="" desc="perlunicook: Note that autodie >= 2.26 should be okay with 'use open'."/> +<commit votes="steveh,tonyc,arc" id="730d89736d0ae5dfc7580108c451efe91b5102fc" ticket="" desc="Fix warning message regarding 'use autodie' and 'use open'."/> +<commit votes="steveh,tonyc,arc" id="2a403855670ae8592c5a3ca4396e6e909a4fc593" ticket="" desc="perlunicook: Note that autodie >= 2.26 should be okay with 'use open'."/> -<commit votes="steveh,tonyc" id="7ad03f5069e771fe44e92b694a23f10354c548d1" ticket="" desc="Fix setenv() replacement documentation in perlclib"/> -<commit votes="steveh,tonyc" id="38f18a308b948c6eaf187519a16d060e1ec7cc20" ticket="" desc="perlhacktips: Add caution about clib ptr returns to static memory"/> +<commit votes="steveh,tonyc,arc" id="7ad03f5069e771fe44e92b694a23f10354c548d1" ticket="" desc="Fix setenv() replacement documentation in perlclib"/> +<commit votes="steveh,tonyc,arc" id="38f18a308b948c6eaf187519a16d060e1ec7cc20" ticket="" desc="perlhacktips: Add caution about clib ptr returns to static memory"/> -<commit votes="steveh,tonyc" id="7b237c8f3da9b9cd57a5cbd035ff4d3e70dcbb7b" ticket="" desc="Fix minor code typos in perlunicook"/> -<commit votes="steveh,tonyc" id="616b344493d526c505a241bee3571ae735408885" ticket="" desc="Randy Stauneris now a perl author"/> +<commit votes="steveh,tonyc,arc" id="7b237c8f3da9b9cd57a5cbd035ff4d3e70dcbb7b" ticket="" desc="Fix minor code typos in perlunicook"/> +<commit votes="steveh,tonyc,arc" id="616b344493d526c505a241bee3571ae735408885" ticket="" desc="Randy Stauneris now a perl author"/> -<commit votes="steveh,tonyc" id="f942a0dfa923e36f91c00b44e21563cd50dc750b" ticket="122322" desc="[perl #122322] Update OOK example in perlguts"/> -<commit votes="steveh,tonyc" id="d8c1af4e0d4774b60bd59dc0039c7e101f292a4a" ticket="" desc="perlfunc: mention that study() is currently a noop"/> +<commit votes="steveh,tonyc,arc" id="f942a0dfa923e36f91c00b44e21563cd50dc750b" ticket="122322" desc="[perl #122322] Update OOK example in perlguts"/> +<commit votes="steveh,tonyc,arc" id="d8c1af4e0d4774b60bd59dc0039c7e101f292a4a" ticket="" desc="perlfunc: mention that study() is currently a noop"/> <commit votes="steveh" id="965d3000a316a5ed367c2ce65d040e1125d5e31d" ticket="" desc="Update supported versions in perlpolicy.pod"/> </div> -- Perl5 Master Repository