Re: a bit of trouble with compiling with MSVC++ on Win32

2005-06-07 Thread Rafael Garcia-Suarez
Konovalov, Vadim wrote: Dear all, quite a long ago following lines (in both win32/Makefile and win32/makefile.mk) : # VC 6.0 can load the socket dll on demand. Makes the test suite # run in about 10% less time. DELAYLOAD = -DELAYLOAD:ws2_32.dll -DELAYLOAD:shell32.dll delayimp.lib

Re: Universal Binary vs. Perl5

2005-06-07 Thread Rafael Garcia-Suarez
Dan Kogai wrote: I am surprisingly unsurprised at the news. These days I hardly care CPUs. I am as CPU-blind ad Color-blind (in a politically correct sense). But as a Perl5 porter I found at least a couple of issues we have to care. What's gonna happen to XS?

Re: [perl #36127] Using exists() on @_ does not work as expected with undef

2005-06-07 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: How do you feel about this: --- perl/av.c.orig 2005-06-02 01:07:41.0 -0700 +++ perl/av.c 2005-06-06 02:05:04.853572800 -0700 @@ -927,8 +927,8 @@ Perl_av_exists(pTHX_ AV *av, I32 key) return FALSE; } -if (key =

Re: [perl #36193] crash in Perl_yyerror due to missing check for NULL

2005-06-07 Thread Rafael Garcia-Suarez
Todd C. Miller wrote: The fix is to simply check that the buf ptr is non-NULL before dereferencing it. This may fix the Netware case as well. Thanks, your patch applied as change #24718 to bleadperl.

Re: a bit of trouble with compiling with MSVC++ on Win32

2005-06-07 Thread Rafael Garcia-Suarez
Konovalov, Vadim wrote: While I am here, I also added a tiny explanation about static extensions. Currently static extensions will work only with win32/makefile.mk but not win32/Makefile, but I hope this unfortunate difference will not be for a long time... Same text should also go into

Re: [PATCH] Re: [perl #36130] chr(-1) should probably return undef

2005-06-07 Thread Rafael Garcia-Suarez
Jarkko Hietaniemi wrote: Nicholas Clark via RT wrote: On Sun, Jun 05, 2005 at 05:27:30PM -0400, Ed Allen Smith wrote: Under use bytes, isn't that the case? If it isn't, under what pragma or whatever can one indeed get a guarantee of no characters outside ASCII? (If the answer is there

Re: [PATCH] util.c: S_vdie_common() should be static

2005-06-07 Thread Rafael Garcia-Suarez
Alexey Tourbin wrote: S_vdie_common() should naturally be static. Besides this, forward declaration is not needed when you simply change the order of S_vdie_common() and S_vdie_croak_common(). --- perl-5.9.3.24699/util.c- 2005-06-03 09:01:34 + +++ perl-5.9.3.24699/util.c

Re: [PATCH] one more round of is_utf8_foo tuneup

2005-06-07 Thread Rafael Garcia-Suarez
Jarkko Hietaniemi wrote: This time both a speedup and a cleanup: I brought the inlined utf8 goodness to is_utf8_string_loc(), too, but while doing that noticed that at one place in mg.c is_utf8_string() was being used wastingly so that the subcaptured string was walked through twice, first for

Re: [PATCH] File/Glob/Glob.xs: errfunc() should be static

2005-06-07 Thread Rafael Garcia-Suarez
Thanks, several patches applied as : Change 24734 on 2005/06/07 by [EMAIL PROTECTED] make some more functions static Subject: [PATCH] B/C/C.xs: static my_runops() Message-ID: [EMAIL PROTECTED] Subject: [PATCH] Devel/Peek/Peek.xs: make plain C

Re: [PATCH] Random cleanups #47

2005-06-07 Thread Rafael Garcia-Suarez
Andy Lester wrote: We're ignoring the previous util.c patch. Turns out that we may befoul certain compilers, and I don't have time/inclination to dig further. Besides the usual batch of consting and localizing of autovars, this patch: * embed.fnc: Add more function attributes. Put

Re: [perl #36127] Using exists() on @_ does not work as expected with undef

2005-06-05 Thread Rafael Garcia-Suarez
On 6/5/05, Dave Mitchell [EMAIL PROTECTED] wrote: Can't really be fixed short of using some other static SV to mark unused elements (cf PL_sv_placeholder), but personally I think that's throwing good money after bad. I agree with this. exists() on arrays seems to be a bit useless to me, or not

Re: PATCH for [perl #36043] '@foo = sort { $a = $b } @bar' uses too much memory

2005-06-05 Thread Rafael Garcia-Suarez
On 6/5/05, Salvador Fandiño [EMAIL PROTECTED] wrote: The difference in memory usage in pp_sort is caused by elements being stringyfied before the sorting when the comparison block is optimized and substituted by a C function. This is wrong for numerical comparisons that doesn't require its

Re: Perl's getppid cache

2005-06-05 Thread Rafael Garcia-Suarez
On 6/5/05, Alexey Tourbin [EMAIL PROTECTED] wrote: Okay, I reworked the test and now suggest it go into bleadperl as t/op/getppid.t. Thanks! I've added it as #24709. I expect that porting ajustments will be needed (that's an habit).

Re: Perl's getppid cache

2005-06-04 Thread Rafael Garcia-Suarez
Alexey Tourbin wrote: Here is a sketch for a test to be added. Because the test itself should not exit, fork() is used twice. Of course syscall(64) is not portalbe and is used now only to prove the problem. That's interesting but I don't even know whether syscall(64) is portable among all

Re: FindBin.pm: incomplete getcwd/cwd patch? (#24375, #24379)

2005-06-04 Thread Rafael Garcia-Suarez
José Pedro Oliveira wrote: Shouldn't the code in the FindBin.pm patches #24375 and #24379 be also applied to the true block of if($0 eq '-e' || $0 eq '-') ? -- --- FindBin.pm.145 2005-05-03 13:46:43.0 +0100 +++ FindBin.pm 2005-05-12 20:20:22.0 +0100 @@

Re: [PATCH] further speeding up of is_utf8_string()

2005-06-04 Thread Rafael Garcia-Suarez
Jarkko Hietaniemi wrote: I further inlined the fast UTF8 path in is_utf8_string(), thus cutting down the number of function calls in a tight loop. With this the run time of t/uni/class.t was cut by further 20-25% (relative to the first speed up), so now the cumulative total speedup is in the

Re: [PATCH] SvPVX_const() - patch #4

2005-06-03 Thread Rafael Garcia-Suarez
Steve Peters wrote: To quote the movie Airplane, I picked the wrong week to stop sniffing glue. It sure seems like sv.c would be a good place to find possible changes from SvPVX() to SvPVX_const(). Also, included are conversions to regcomp.c and regexec.c which I sort of punted on with

Re: [PATCH] symbian/xsbuild.pl

2005-06-03 Thread Rafael Garcia-Suarez
[EMAIL PROTECTED] wrote: I could have sworn I sent this patch in already, but I must have been imagining. Without it the brave new xsubpp backend does not fly in the Symbian SDK. The only essential change is the addition of -I$BUILDROOT\\lib in one of the system_echo() calls, the rest is

Re: [PATCH] Quotes in pod/*.pod

2005-06-03 Thread Rafael Garcia-Suarez
Andy Lester wrote: Here's some more quote cleaning in pod/*.pod. I also removed Velocigen from the FAQ since it no longer exists, at least that I can find on the web. Thanks, applied to blead as #24686. (Note the multiple changes in the FAQ)

Re: [PATCH] speed up is_utf8_char()

2005-06-03 Thread Rafael Garcia-Suarez
Jarkko Hietaniemi wrote: I got annoyed by t/uni/class.t being so slow, so I inlined much of the is_utf8_char(). This seems to cut away about 25% of the run time of class.t (both in x86/linux and tru64). Still slow, though. Thanks, applied as #24687.

Re: [PATCH] Random consting

2005-06-03 Thread Rafael Garcia-Suarez
Andy Lester wrote: Here's a collection of stuff that I've been tweaking over the past week or so that doesn't fit in any given category. Solaris' lint has been complaining about signed/unsigned, and there are definitely places where we're using I32s when we should be using STRLEN, for

Re: Should while ( $fh ) and while ( $fh ) do the same thing?

2005-06-03 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: --- perl/pod/perlop.pod.orig2005-05-24 09:13:19.0 -0700 +++ perl/pod/perlop.pod 2005-06-02 11:40:43.174036800 -0700 Agreed. Thanks, applied as #24690.

Re: [perl #35977] perlbug AutoReply: Devel::DProf unstacked calls in outer

2005-06-03 Thread Rafael Garcia-Suarez
Duncan Findlay wrote: I believe I have found a patch for this issue. I have attached the patch. This seems to fix the warnings and produce no deviation from the original results. I can't claim I understand dprofpp, but this patch looks minimally sane. Thanks, applied as #24693.

Re: Config_heavy.pl change in 5.8.7 hurts PAR?

2005-06-03 Thread Rafael Garcia-Suarez
Steve Hay wrote: Has anybody else tried PAR-0.87 with perl-5.8.7 yet? I find that it can't do anything because it can't find Config_heavy.pl. Just about all the tests have this problem, and even just trying to compile the Hello, world. program emits: C:\Temp\PAR-0.87perl -Mblib

Re: Config_heavy.pl change in 5.8.7 hurts PAR?

2005-06-03 Thread Rafael Garcia-Suarez
Steve Hay wrote: Rafael Garcia-Suarez wrote: Steve Hay wrote: Has anybody else tried PAR-0.87 with perl-5.8.7 yet? I find that it can't do anything because it can't find Config_heavy.pl. Just about all the tests have this problem, and even just trying to compile the Hello, world

Re: [PATCH] Improved ICMP_UNREACHABLE handling in Net::Ping

2005-06-03 Thread Rafael Garcia-Suarez
On 03 Jun 2005 09:17:44 -0700, Gisle Aas [EMAIL PROTECTED] wrote: Since you have started to patch Net::Ping, I have another patch to Net::Ping that we have applied to ActivePerl that I think should be applied to blead as well. This patch was sent to Rob Brown some months ago, but I have not

Re: [perl #36093] 5.8.7 - ext/IO/t/io_sock.t fails on test 15

2005-06-03 Thread Rafael Garcia-Suarez
On 2 Jun 2005 15:47:28 -, via RT Peter Dintelmann [EMAIL PROTECTED] wrote: ext/IO/t/io_sock.t fails on test 15. (The purpose of this test is to generate test data for other tests.) $ make test ... ... ... ext/IO/t/io_sock..FAILED at test 15 ...

Re: B::Concise torture

2005-06-03 Thread Rafael Garcia-Suarez
On 6/2/05, Jim Cromie [EMAIL PROTECTED] wrote: these 2 patches apply in order, on top of previous (diff.smcc2-tests), on top of current blead 24665. Tested against thread, non-thread, all tests pass Thanks, applied as #24700 to bleadperl, with a few minor formatting nits. The first one was

Re: [PATCH] Clean up UNI* macros in toke.c

2005-06-03 Thread Rafael Garcia-Suarez
On 6/3/05, Andy Lester [EMAIL PROTECTED] wrote: The UNI* macros at the top of toke.c make lint unhappy, specifically about about undefined order of operations in the big chain of comma-separated expressions. This patch turns them into a block that doesn't have any such problems. Thanks,

Re: [PATCH] Consting IO and Devel::Peek

2005-06-03 Thread Rafael Garcia-Suarez
On 5/31/05, Andy Lester [EMAIL PROTECTED] wrote: I'm making my way through the ext/ directory. Thanks, applied as change 24702.

Re: [PATCH] use lengths in sv_setpv() calls

2005-06-02 Thread Rafael Garcia-Suarez
Andy Lester wrote: Here are some cases where we know the length of the SvPV getting passed in to sv_setpv(), so let's call sv_setpvn() instead. Thanks, applied as change 24669 to bleadperl.

Re: Change 24667 introduces typo in perl.c

2005-06-02 Thread Rafael Garcia-Suarez
Dominic Dunlop wrote: -#if defined(__hpux) __ux_version 1020 !defined(__GNUC__) +#if defined(__hpux) _ux_version 1020 !defined(__GNUC__) Thanks, applied as 24674.

Re: [PATCH] Speed up lib/unicore/mktables by 45%

2005-06-01 Thread Rafael Garcia-Suarez
Andy Lester wrote: Whenever I run make perl, I'm stuck with regenerating the unicode tables. I went and poked at lib/unicore/mktables and found that by eliminating a few function calls (and breaking the encapsulation of the object just a ltle bit) I could cut down the 18-second run of

Re: [patch] teach B::Concise to see XS code

2005-06-01 Thread Rafael Garcia-Suarez
Jim Cromie wrote: Jim Cromie wrote: attached patch teaches B::Concise to see XS code, so now it reports 'foo is XS code' when thats appropriate, rather than 'foo has no START'. another revision attached. Thanks, applied as #24653, and Stephen's op.c patch as #24654.

Re: [PATCH]? Why touch lib/ExtUtils/Miniperl.pm?

2005-06-01 Thread Rafael Garcia-Suarez
Robin Barker wrote: Makefile.SH contains (for the target lib/ExtUtils/Miniperl.pm) sh mv-if-diff minimod.tmp $@# $@ == lib/ExtUtils/Miniperl.pm -touch lib/ExtUtils/Miniperl.pm The touch line makes a nonsense of the mv-if-diff line, which serves to preserve old

Re: [PATCH] eliminate always running mktables

2005-06-01 Thread Rafael Garcia-Suarez
Robin Barker wrote: mktables is re-run because it depends on Config_heavy.pl which is always updated. What is needed is a temporary config_heavy, as in the patch below. Thanks, applied as #24656. --- /usr/appl/src/perl/perl-5.8.7/Makefile.SH.origSat Feb 5 15:17:44 2005

Re: [PATCH] eliminate always running mktables

2005-06-01 Thread Rafael Garcia-Suarez
Robin Barker wrote: Not sure my patch does what I wanted. I think configpm may get run twice: once for Config.pm and again for Config_heavy.pl I'll think about it again later today. Hmm, yes, you're right : strange.

Re: [patch] teach B::Concise to see XS code

2005-06-01 Thread Rafael Garcia-Suarez
Jim Cromie wrote: heres 2 tests to confirm Stephens fix doesnt regress later, based on his 1 liner bug demonstration. Actually those tests are not up to date with bleadperl, that's why I didn't integrate them : [EMAIL PROTECTED] t]$ ./perl harness ../ext/B/t/concise.t

Re: [PATCH] eliminate always running mktables

2005-06-01 Thread Rafael Garcia-Suarez
Robin Barker wrote: -Original Message- From: Rafael Garcia-Suarez [mailto:[EMAIL PROTECTED] Sent: 01 June 2005 11:03 To: Robin Barker; perl5-porters@perl.org Subject: Re: [PATCH] eliminate always running mktables Robin Barker wrote: Not sure my patch does what I wanted. I

Re: [PATCH] ByteLoader.xs cleanup

2005-05-31 Thread Rafael Garcia-Suarez
Andy Lester wrote: - SvCUR_set (data-datasv, 0); } + SvCUR_set(data-datasv, len); This seems suspicious to me.

Re: [PATCH] ByteLoader.xs cleanup

2005-05-31 Thread Rafael Garcia-Suarez
demerphq wrote: On 5/31/05, Rafael Garcia-Suarez [EMAIL PROTECTED] wrote: Andy Lester wrote: - SvCUR_set (data-datasv, 0); } + SvCUR_set(data-datasv, len); This seems suspicious to me. Look at the logic: if (len) { memmove (start, start + data

Re: [PATCH] consting B.xs

2005-05-30 Thread Rafael Garcia-Suarez
Andy Lester wrote: This is a little more than a standard consting. * Consted all input string parms * Localized a couple of temporary buffers * Changed some sv_catpv( xx ) to sv_catpvn( xx, 2 ), since we always know the length. * Called SvPV_len() where we were throwing away the length.

Re: [PATCH] perlrun.pod -w description typo

2005-05-30 Thread Rafael Garcia-Suarez
Offer Kaye wrote: Hi, In perlrun.pod, the -w flag description, values used as a number that doesn't look like numbers changed to: values used as a number that don't look like numbers. Thanks, applied as 24623.

Re: [PATCH] More embed.fnc strictures, plus consting and localizing

2005-05-30 Thread Rafael Garcia-Suarez
Andy Lester wrote: Here's another batch of good ol' strictures in the functions specified in embed.fnc, and some more consting and localizing. Thanks, applied as #24625 (with an adaptation on share_hek_flags' proto) and with your other patch : Subject: [PATCH] Remove unused casts

Re: [PATCH] Teeny optimization in S_hv_magic_check

2005-05-30 Thread Rafael Garcia-Suarez
Andy Lester wrote: This patch lets us exit out of S_hv_magic_check once we've set all the flags that there are to set, rather than continuing down the linked list of magic. Thanks, applied as 24626.

Re: [perl #36037] Perl 5.8.7-RC1 build problems on LynxOS

2005-05-30 Thread Rafael Garcia-Suarez
Olli Savia (via RT) wrote: I'm building perl 5.8.7-RC1 on LynxOS and I encountered a compilation problem. It is a result of missing prototype in LynxOS system header files. With the following patch I'm able to compile perl successfully. Could it be possible to get this change in main tree?

Re: why is Filter-Simple-0.79 not installed with blead-perl? (0.78 is used instead)

2005-05-29 Thread Rafael Garcia-Suarez
On 5/29/05, David Dyck [EMAIL PROTECTED] wrote: I've noticed that most of the other modules have been integrated into perl v5.9.3 but when I have CPAN check if my modules are up to date, it continues to identify that Filter::Simple is getting re-installed as 0.78 instead of the CPAN

Re: explaining all this const stuff

2005-05-29 Thread Rafael Garcia-Suarez
On 5/29/05, Andy Lester [EMAIL PROTECTED] wrote: I've explained at least three times in IRC why consting is a good thing. I figure I should write up something explaining it. Porting/pumpkin.pod seems like the best choice, but it's not exactly a fit. Suggestions? The only other place I see

Re: [PATCH] Documentation nits and fixes for Sv*_set() macros

2005-05-27 Thread Rafael Garcia-Suarez
Steve Peters wrote: The attached patch fixes a couple of nits in the documentation for the Sv*_set() macros. Thanks, applied as #24592.

Re: [PATCH] Re: [perl #35420] localtime corruption

2005-05-27 Thread Rafael Garcia-Suarez
Michael G Schwern wrote: My patch to the localtime documentation appears to have been lost in the noise. Here it is again. It documents in perlport the portability issues of time ranges localtime() can handle. Thanks, applied as #24593.

Re: [PATCH] bytes.pm doesn't check undefined subroutine calling

2005-05-26 Thread Rafael Garcia-Suarez
SADAHIRO Tomoyuki wrote: A problem of bytes.pm was reported at perl-unicode list last month. cf. http://www.nntp.perl.org/group/perl.unicode/2803 The problem is that a infinite loop is invoked once an undefined subroutine in bytes:: package is called. Older AUTOLOAD subroutine in

Re: [perl #35963] Typo in Term::ReadLine

2005-05-25 Thread Rafael Garcia-Suarez
[EMAIL PROTECTED] (via RT) wrote: The documentation for Term::ReadLine says: Actually Term::ReadLine can use some other package, that will support reacher set of commands. I'm imagining this should say richer. I was going to email the author but his email address indicated a preference

Re: warnings during tests @24570

2005-05-25 Thread Rafael Garcia-Suarez
Andreas J Koenig wrote: I noticed this during make test with bleedperl @24570: lib/ExtUtils/t/00compile..Variable $bal will not stay shared at (re_eval 70) line 2. Variable $bal will not stay shared at (re_eval 71) line 2. Variable $C_group_rex will

Re: [perl #35857] [PATCH] B::Deparse doesnt handle warnings register properly.

2005-05-24 Thread Rafael Garcia-Suarez
demerphq wrote: Hi, deparse.t patch attached. Sorry about the delay. Thanks, applied as 24559 to bleadperl.

Re: [perl #35885] qw and x operators doesn't mix

2005-05-24 Thread Rafael Garcia-Suarez
Rafael Garcia-Suarez wrote: There's indeed a bug, since the tokenizer doesn't set its state after parsing qw//. Fixed by this nit : --- toke.c (revision 4822) +++ toke.c (working copy) @@ -4956,6 +4956,7 @@ s = scan_str(s,FALSE,FALSE); if (!s

Re: [PATCH] embed.fnc cleanup + SvPVX_const usage

2005-05-24 Thread Rafael Garcia-Suarez
Andy Lester wrote: These should be two separate patches, but there's too much overlap. * Added more NN flags to functions in embed.fnc * Rearranged some funcs to reduce the number of #ifdefs * Added definitions for all the Perl_ck_* functions in op.c. * In op.c renamed static

Re: Change 24561: [PATCH] embed.fnc cleanup + SvPVX_const usage

2005-05-24 Thread Rafael Garcia-Suarez
Nicholas Clark wrote: In fact, it looks like the only reason they can't be static to op.c is because Perl_init_global_struct in util.c expects to see them. And in turn, I would have thought that that could be cured by making it call a function in op.c There's also the PL_check function

Re: [PATCH] Re: [perl #35885] qw and x operators doesn't mix

2005-05-24 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: I applied this as change 24560 to bleadperl, with a regression test that says : is( (join ',', (qw(a b c) x 3)), 'a,b,c,a,b,c,a,b,c', 'x on qw produces list' ); --- perl/pod/perlop.pod.orig2005-05-10 08:07:42.0 -0700 +++

Re: [perl #35929] a possible Perl bug about IO::String and $/ in Perl 5.8.6 on Linux/Solaris/MacOS X

2005-05-23 Thread Rafael Garcia-Suarez
On 5/23/05, Rafael Garcia-Suarez [EMAIL PROTECTED] wrote: The bug is in PerlIOScalar_unread, which doesn't do what it should. The following patch solves this particular problem, but it's obviously not sufficient... it's late and I'll try to work out a proper solution another day. Now

Re: [PATCH] Re: (attributes error) Re: Smoke [5.9.3] 24533 FAIL(m) MSWin32 WinXP/.Net SP1 (x86/1 cpu)

2005-05-23 Thread Rafael Garcia-Suarez
On 5/23/05, Andy Lester [EMAIL PROTECTED] wrote: Sorry about that. Tried to optimize away what I thought were unnecessary #define checks. Here's the real solution. Thanks, applied as #24552.

Re: Removing needless files

2005-05-22 Thread Rafael Garcia-Suarez
On 5/22/05, Tels [EMAIL PROTECTED] wrote: it looks to me like there are quite a few files in /lib that are not needed for building Perl, like changelogs, SIGNATUREs etc. Attached is a small script to list them and the list from my /usr/local/lib/perl5/5.8.6 installation as an example (it might

Re: [PATCH 5.8.7 RC1] lib/Carp.t todo for VMS

2005-05-22 Thread Rafael Garcia-Suarez
On 5/20/05, Michael G Schwern [EMAIL PROTECTED] wrote: On Fri, May 20, 2005 at 08:26:01AM -0500, Craig A. Berry wrote: --- lib/Carp.t;-0 Mon May 16 10:47:48 2005 +++ lib/Carp.tFri May 20 08:14:12 2005 @@ -157,6 +157,7 @@ } # Check that croak() and confess() don't clobber

Re: [perl #35936] [patch] errno problem on DragonFly 1.3.1+

2005-05-22 Thread Rafael Garcia-Suarez
On 22 May 2005 16:01:25 -, via RT Jörg Sonnenberger [EMAIL PROTECTED] wrote: Perl contains local extern int errno; defines in two places of sdbm, one of which is actually used. This conflicts with errno.h, leading to build errors. The attached patch is fixes, all ANSI C conforming

Re: [perl #35929] a possible Perl bug about IO::String and $/ in Perl 5.8.6 on Linux/Solaris/MacOS X

2005-05-22 Thread Rafael Garcia-Suarez
On 22 May 2005 06:09:41 -, via RT Hseu-Ming Chen [EMAIL PROTECTED] wrote: The following self-contained program dies with a read failed message: #!/usr/local/bin/perl -w use strict; my $s = 'EOF'; line A line B a third line EOF open (F, '', \$s)

Re: eval { goto foo } behaviour

2005-05-21 Thread Rafael Garcia-Suarez
On 5/21/05, Dave Mitchell [EMAIL PROTECTED] wrote: My question is, should sub f { eval { goto g } } a) give an error like the string form of eval, or b) exit f() and start executing g()? I vote (b). I agree. You're already allowed to exit eval {} statements by using last or

Re: [perl #35904] Unable to 'make' Perl 5.8.6

2005-05-21 Thread Rafael Garcia-Suarez
On 20 May 2005 23:43:24 -, via RT Gerard Seibert [EMAIL PROTECTED] wrote: config.h:1976:9: invalid preprocessing directive #HAS_MSG_CTRUNC Somehow config.h wasn't properly generated. How did you invoke the Configure script ?

Re: eval { goto foo } behaviour

2005-05-21 Thread Rafael Garcia-Suarez
On 5/21/05, Dave Mitchell [EMAIL PROTECTED] wrote: Actually I've changed my mind. I've just remembered that sub f { eval { return } } only exits the eval and not f(). So (b) would be inconsistent behaviour. I now favour (a). A third option, of replacing the eval with a call to g(), which

Re: eval { goto foo } behaviour

2005-05-21 Thread Rafael Garcia-Suarez
On 5/21/05, Dave Mitchell [EMAIL PROTECTED] wrote: Er, I think you mean (d) :-) OK, you made it perfectly clear, and I adopt your advice.

Re: [PATCH] Attribute configuration

2005-05-20 Thread Rafael Garcia-Suarez
Andy Lester wrote: I await your feedback. So do I. Thanks, applied as 24508.

Re: [perl #35885] qw and x operators doesn't mix

2005-05-20 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: On Thu, May 19, 2005 at 04:12:45PM -, Salvador Fandiño wrote: for instance: $ perl -e '@foo = qw(foo bar) x 3' Number found where operator expected at -e line 1, near x 3 (Do you need to predeclare x?) syntax error at -e line 1, near

Re: [perl #35885] qw and x operators doesn't mix

2005-05-20 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: $ bleadperl -le 'print for qw(foo bar) x 2' foo bar foo bar That's the opposite of what I was trying to say. Yes, I'm quite aware of this :) A nonetheless is missing in my previous mail. I think of ()x and x as being two separate operators, that

Re: [perl #35885] qw and x operators doesn't mix

2005-05-20 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: On Fri, May 20, 2005 at 11:07:25AM +0200, Rafael Garcia-Suarez wrote: qw() has a strong list feeling. Moreover, perl 6 seems to agree : $ ./pugs -e 'say for qw(foo bar) xx 2' foo bar foo bar Is p6's xx supposed to have both roles of p5's x

Re: SvPVX_const() - Patch #1

2005-05-20 Thread Rafael Garcia-Suarez
Steve Peters wrote: OK, here we go. After rethinking my methodology for these patches, here is the first patch to convert SvPVX() to SvPVX_const(). This patch includes changes to doio.c, toke.c, universal.c, util.c, and warnings.pl. Before checking in this patch, a regen will need to be

ExtUtils::ParseXS emits closure warnings on blead

2005-05-20 Thread Rafael Garcia-Suarez
With current blead : [EMAIL PROTECTED] bleadperl]$ bleadperl -cw lib/ExtUtils/ParseXS.pm Variable $bal will not stay shared at (re_eval 3) line 2. Variable $bal will not stay shared at (re_eval 4) line 2. Variable $C_group_rex will not stay shared at (re_eval 5) line 2.

Re: ExtUtils::ParseXS emits closure warnings on blead

2005-05-20 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: On Fri, May 20, 2005 at 12:18:21PM +0200, Rafael Garcia-Suarez wrote: With current blead : [EMAIL PROTECTED] bleadperl]$ bleadperl -cw lib/ExtUtils/ParseXS.pm Variable $bal will not stay shared at (re_eval 3) line 2. Variable $bal

Re: [PATCH] Add a Makefile target for ctags

2005-05-20 Thread Rafael Garcia-Suarez
Andy Lester wrote: This patch changes the ctags target from being a synonym for tags and etags to running Exuberant Tags (ctags.sf.net). I don't use Emacs-format tags, and I bet many others don't, either. Thanks, applied as #24511.

Re: 5.8.7 RC1 (uh-oh, Math::BigInt bug)

2005-05-20 Thread Rafael Garcia-Suarez
On 5/20/05, Tels [EMAIL PROTECTED] wrote: Now, I have prepared a patch (attached) that brings blead to v1.77 - I can prepare one against 5.8.7RC1 if nec. Thanks, applied as #24517 to bleadperl.

Re: [perl #35877] Strange regex failure?

2005-05-19 Thread Rafael Garcia-Suarez
Steve Hay (via RT) wrote: I believe that the following program should print OK 5 times over, but it prints NOT OK from the first line. print qq[10\n] =~ /\d+$ \n/ix ? OK\n : NOT OK\n; print qq[1\n] =~ /\d+$ \n/ix ? OK\n : NOT OK\n; print qq[10\n] =~ /\d+$ \n/ix ? OK\n : NOT OK\n;

Re: Smoke [5.9.3] 24501 FAIL(F) hp-ux 10.20 (PA-2.0/32/1 cpu)

2005-05-19 Thread Rafael Garcia-Suarez
On 19 May 2005 14:26:46 -0700, Gisle Aas [EMAIL PROTECTED] wrote: What happens is that the shell interferes on some platforms and change the status returned back to perl. This patch made this test failure go away on HP-UX. Hopefully this fixes the failure seen on some other platforms as

Re: [PATCH] Eliminate function signatures from perlport

2005-05-18 Thread Rafael Garcia-Suarez
Michael G Schwern wrote: perlport's alphabetical listing of functions and their portability concerns lists each function with its signature. For example =item system LIST instead of just =item system. As perlport is not documenting how the function works this is just clutter. Furthermore,

Re: B::Disassembler.pm

2005-05-18 Thread Rafael Garcia-Suarez
Nicholas Clark wrote: On Tue, May 17, 2005 at 05:53:36PM +0200, Rafael Garcia-Suarez wrote: Nicholas Clark wrote: I think that the following is correct, but does anyone know better? What problem does this solve ? Without this change you can't disassemble the bytecode from (IIRC

Re: [PATCH] ExtUtils-{ParseXS,CBuilder} into bleadperl (was: Re: [Module::Build] ANNOUNCE: Module::Build 0.2610 - CPAN)

2005-05-18 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: On Tue, May 17, 2005 at 06:02:22PM -0700, Yitzchak Scott-Thoennes wrote: I'll send a full patch to bleadperl separately just to p5p. Thanks, applied as #24500 to bleadperl.

Re: Well defined $? and introduction of ${^CHILD_ERROR_NATIVE} [PATCH]

2005-05-18 Thread Rafael Garcia-Suarez
Gisle Aas wrote: Rafael Garcia-Suarez [EMAIL PROTECTED] writes: Makes sense to me... more than reformulating $? anyway (historically perl trying to hide the differences between platforms rather than to show them.) This is a patch that I think can be applied to blead. It contains

Re: [PATCH] perl 5.9.x (@ 24471): Symbian update

2005-05-17 Thread Rafael Garcia-Suarez
jarkko hietaniemi wrote: Some updates required because of the ongoing cleanup work: Thanks, applied as 24492, as well as your follow-up patch to symbian/port.pl.

Re: B::Disassembler.pm

2005-05-17 Thread Rafael Garcia-Suarez
Nicholas Clark wrote: I think that the following is correct, but does anyone know better? What problem does this solve ? --- ext/B/B/Disassembler.pm.orig 2005-05-05 15:55:42.0 +0100 +++ ext/B/B/Disassembler.pm 2005-05-17 11:25:21.0 +0100 @@ -154,12 +154,12 @@ sub

Re: B::Disassembler.pm

2005-05-17 Thread Rafael Garcia-Suarez
Michael G Schwern wrote: On Tue, May 17, 2005 at 05:53:36PM +0200, Rafael Garcia-Suarez wrote: Nicholas Clark wrote: I think that the following is correct, but does anyone know better? What problem does this solve ? What does FooBar even mean?! Its used in a few places and we

Re: Change 24471: [PATCH] Minor tweak to via

2005-05-16 Thread Rafael Garcia-Suarez
Nicholas Clark wrote: On Sun, May 15, 2005 at 02:14:30PM -0700, Nicholas Clark wrote: +++ perl/ext/PerlIO/via/via.xs Sun May 15 13:46:03 2005 @@ -247,7 +247,7 @@ else { /* Required open method not present */ PerlIO_funcs *tab = NULL; - IV m = n - 1;

Re: [PATCH] consting-eleventy.patch: More consts, plus actual bug fix

2005-05-16 Thread Rafael Garcia-Suarez
Andy Lester wrote: Here's the interesting stuff in the attached patch. Thanks, applied ! utf8.c: Fixed a bug where we weren't printing in s/// on a certain warning. This was caught by GCC's printf format checking. Then, I removed some redundant calls using my first goto. I feel dirty, but

Re: change to quiet cygwin's perlld

2005-05-13 Thread Rafael Garcia-Suarez
Yitzchak Scott-Thoennes wrote: I'm having some trouble with some new tests I'm adding to perl; perlld is outputing stuff to STDOUT, which makes TEST unhappy (though harness doesn't mind). Would the following change be okay with you: --- perl/cygwin/perlld.in 2003-11-24

Re: Why is $? forced to 16 bits?

2005-05-13 Thread Rafael Garcia-Suarez
Gisle Aas wrote: This is an implementation of this idea. Tests still missing but the old test suite still passes (at least on Linux). With this patch perl will construct $? from the values that the W* macros give it. If this approach makes sense to most people I will finish up the patch by

Re: [perl #33766] [PATCH] perldoc -f split lacks basic null example

2005-05-12 Thread Rafael Garcia-Suarez
Randy W. Sims wrote: Dave Mitchell wrote: On Wed, May 11, 2005 at 02:14:28PM -0400, Ronald J Kimball wrote: Of course split('') is equivalent to split(//), just as split('a|b') is equivalent to split(/a|b/). And of course split(/a\b/) is *not* equivalent to split(a\b), so it's

Re: Why is $? forced to 16 bits?

2005-05-12 Thread Rafael Garcia-Suarez
Gisle Aas wrote: The following trivial test program fails on AIX 5.1 because the high bits are always stipped off $?. Does anybody know why perl does this? Smells like non portable assumptions. As says perlvar, This is just the 16-bit status word returned by the wait() system call (or

Re: ponie in svn

2005-05-12 Thread Rafael Garcia-Suarez
Nicholas Clark wrote: Robert has migrated ponie to subversion: OK. Next question... migrating perl 5 ?

Re: [PATCH] Add Win32::GetFileVersion() function

2005-05-12 Thread Rafael Garcia-Suarez
Jan Dubois wrote: The attached patch adds Win32::GetFileVersion() to the Win32 module. It also adds documentation for Win32::GuidGen(), which has been part of the Win32 module for a long time, but somehow I overlooked it when I wrote the docs for the other functions. While looking at

Re: [PATCH] Add Win32::GetFileVersion() function

2005-05-12 Thread Rafael Garcia-Suarez
Steve Hay wrote: Rafael Garcia-Suarez wrote: Looks like this patch was already applied in : ?! No it wasn't... But it is applied now (#24453). Thanks. Er, well, ok. The space-time continuum isn't was it used to be ...

Re: [perl #35420] localtime corruption

2005-05-12 Thread Rafael Garcia-Suarez
Daniel Pfeiffer (via RT) wrote: localtime returns rubbish outside of -~0/2..~0/2. The first quarter of possible arguments all return 1901, while the last quarter wraps around after 2038, back to 1970. This should die or, better, be extended. Perl can't do better than the OS here.

Re: Read-only files (was: Re: [PATCH] reentr.h changes so threaded Perl's compile on OpenBSD 3.7)

2005-05-11 Thread Rafael Garcia-Suarez
Randy W. Sims wrote: -*- buffer-read-only: t -*- somewhere in the first (or second?) line will set the (GNU or X) emacs buffer to read-only if that's what you're looking for. OK, I've added this and the corresponding vi modeline to every generated file (#24445). -- A First Encyclopedia

Re: potential [PATCH] Tru64 crank up strictness

2005-05-10 Thread Rafael Garcia-Suarez
On 5/10/05, Jarkko Hietaniemi [EMAIL PROTECTED] wrote: (2) More seriously, cc gets upset by the casting between a function pointer and a void pointer in toke.c when dealing with the source code filters. With this upsetness I do agree more than with (1) and therefore I resorted to the usual

Re: [PATCH] GCC attributes!

2005-05-09 Thread Rafael Garcia-Suarez
Andy Lester wrote: - my @pos = map { $has_context ? pTHX_ $_ : $_ } @nonnull; - $ret .= sprintf( \n\t\t\t__attribute__((nonnull(%s))), join( ,, @pos ) ); + if ($has_context) { + my @pos = map { $has_context ? $_ + 1 : $_ } @nonnull; +

Re: [PATCH] GCC attributes!

2005-05-09 Thread Rafael Garcia-Suarez
Andy Lester wrote: - my @pos = map { $has_context ? pTHX_ $_ : $_ } @nonnull; - $ret .= sprintf( \n\t\t\t__attribute__((nonnull(%s))), join( ,, @pos ) ); + if ($has_context) { + my @pos = map { $has_context ? $_ + 1 : $_ } @nonnull; +

<    1   2   3   4   5   6   7   8   9   10   >