Andy
I still get the following warnings related to attributes
Robin
gv.c: In function `Perl_gv_init':
gv.c:167: warning: ignoring return value of `Perl_start_subparse', declared
with attribute warn_unused_result
op.c: In function `Perl_newCONSTSUB':
op.c:4613: warning: null argument where
-Original Message-
From: Rafael Garcia-Suarez [mailto:[EMAIL PROTECTED]
Sent: 27 August 2005 17:59
To: Jos I. Boumans
Cc: Perl 5 Porters
Subject: Re: [ANNOUNCE] Archive::Tar 1.25
On 8/25/05, Jos I. Boumans [EMAIL PROTECTED] wrote:
Thanks, applied as 12201, with the following
:[EMAIL PROTECTED]
Sent: 18 July 2005 14:04
To: Robin Barker
Cc: ''The Perl5 Porters Mailing List ''; John Peacock
Subject: Re: [PATCH] RE: blead: no longer supports %vd format
Thanks, applied as change #25171 to bleadperl.
---
This e
This fixes some compiler warnings in mg.c and POSIX.xs,
and clarifies some related macro definitions in perl.h
Robin
---
This e-mail and any attachments may contain confidential and/or
privileged material; it is for the intended
This patch allows Perl_die to have a NULL argument - corresponding to throwing
an exception.
This allows various bits of code (previously complicated by format checkery) to
be simplified.
The macros DieNull and DIE_NULL have been removed: they don't appear to used in
CPAN modules.
Robin
-Original Message-
From: Nicholas Clark [mailto:[EMAIL PROTECTED]
Sent: 27 July 2005 17:03
To: Steve Peters
Cc: perl5-porters@perl.org
Subject: Re: [PATCH] Squish warnings in POSIX.xs
On Wed, Jul 27, 2005 at 11:01:00AM -0500, Steve Peters wrote:
POSIX.xs has recently been giving the
I'm worried that allowing a Null pointer will still cause printf warnings.
Lack to tuits to look at this until next week.
Robin
-Original Message-
From: Andy Lester [mailto:[EMAIL PROTECTED]
Sent: 20 July 2005 14:24
To: Stas Bekman
Cc: The Perl5 Porters Mailing List
Subject: Re: blead:
[EMAIL PROTECTED] wrote
Somehow, although $1 was set it has been changed back to undef on
exiting the 'for' block. I don't see anything in perlre or perlvar
documenting this.
In perlre:
The numbered match variables ($1, $2, $3, etc.) and the related
punctuation set ($+, $, $`, $', and
-Original Message-
From: Steve Hay
To: Rafael Garcia-Suarez
Cc: Robin Barker; ''The Perl5 Porters Mailing List ''; John Peacock
Sent: 18/07/05 17:26
Subject: Re: [PATCH] RE: blead: no longer supports %vd format
Rafael Garcia-Suarez wrote:
On 7/14/05, Robin Barker [EMAIL PROTECTED] wrote
Attached patch reinstates VDf in blead perl to implement the %vd format,
which is still used in XS code and will reappear in blead for read-only
version numbers.
I have taken the opportunity to tidy up the code for the %p hacks that
are used to proved SVf (was %_) and VDf. The format processing
I suggest we use this patch I proposed earlier (as one of two alternatives).
It removes mv-if-diff from lib/Config.pm and uses lib/Config.pod to
de-parallelise the call to configpm. There does not seem much downside to
this approach -- except for the comment in Makefile
saying that
In an earlier patch of mine (18696), I made a mistake.
[I added code to a one-line if statement
without changing it to a block if.]
The attached patch fixes the mistake and (much harder)
provides a test to distinguish old and new behaviour.
Should new tests go at the end of the
John
I'm sorry that I didn't notice when you submitted the original patches
that you were nuking the VDf support. Is there some reason that the
'%-1p' hack cannot be re-added so that VDf could be supported in the
core as well as in XS modules?
Because its a nasty hack that I never meant
-Original Message-
From: John Peacock
To: Robin Barker
Cc: ''The Perl5 Porters Mailing List ' '
Sent: 09/07/05 00:56
Subject: Re: blead: no longer supports %vd format
Robin Barker wrote:
My 23767 (and a few later patches) kept the -Wformat checking hacks
hidden behind -DCHECK_FORMAT
gcc -Wall (or gcc -Wformat) complain about %vd and %_ because the
functions they are used in now have an attribute that says they
expect format strings. This attribute used to be conditional on
-DCHECK_FORMAT but that was removed: when VDf (='vd') was
removed and SVf was changed from '_' to a
-Original Message-
From: John Peacock
Cc: Robin Barker; 'The Perl5 Porters Mailing List '
Sent: 08/07/05 20:43
Subject: Re: blead: no longer supports %vd format
Robin Barker wrote:
Previously -DCHECK_FORMAT defined VDf + SVf differently, to avoid the
warnings and allow -Wformat
-Original Message-
From: Michael G Schwern [mailto:[EMAIL PROTECTED]
Sent: 29 June 2005 00:21
To: perl5-porters@perl.org
Subject: Re: [perl #36417] IO::Handle::getline() doco should note an
important difference from $io
On Tue, Jun 28, 2005 at 06:25:31PM -, Justin Mason wrote:
FPTR2DPTR in perl.h is defined as (t)PTR2UV(p)
if UVSIZE PTRSIZE this gives a compiler warning.
We could use INT2PTR(t,PTR2UV(p)) but this could
expand to
(t)(unsigned long)(UV)(unsigned long)(p)
which is a bit unnecessary.
What is needed is an unsigned integer the same size
as a
-Original Message-
From: Rafael Garcia-Suarez [mailto:[EMAIL PROTECTED]
Sent: 17 June 2005 14:48
To: perl5-porters@perl.org
Subject: Re: rebuilding lib/Config*; was RE: [PATCH] 5.8.7 fails to
build with parallel make
Robin Barker wrote:
I assume this solves the parallel make problem
-Original Message-
From: Rafael Garcia-Suarez
To: perl5-porters@perl.org
Sent: 17/06/05 13:48
Subject: Re: [perl #36199] [PATCH] 5.8.7 fails to build with parallel make
Steve Peters via RT wrote:
Actually, not very hard at all. We just need to make the Makefile
single-thread making
mktables is re-run because it depends on Config_heavy.pl which is always
updated.
What is needed is a temporary config_heavy, as in the patch below.
Robin
--- /usr/appl/src/perl/perl-5.8.7/Makefile.SH.orig Sat Feb 5 15:17:44 2005
+++ /usr/appl/src/perl/perl-5.8.7/Makefile.SH Wed Jun 1
Makefile.SH contains (for the target lib/ExtUtils/Miniperl.pm)
sh mv-if-diff minimod.tmp $@# $@ == lib/ExtUtils/Miniperl.pm
-touch lib/ExtUtils/Miniperl.pm
The touch line makes a nonsense of the mv-if-diff line, which serves
to preserve old modification times on
@perl.org
Subject: Re: [PATCH] eliminate always running mktables
Robin Barker wrote:
mktables is re-run because it depends on Config_heavy.pl which is always
updated.
What is needed is a temporary config_heavy, as in the patch below.
Thanks, applied as #24656.
--- /usr/appl/src/perl/perl
-Original Message-
From: Rafael Garcia-Suarez [mailto:[EMAIL PROTECTED]
Sent: 01 June 2005 11:03
To: Robin Barker; perl5-porters@perl.org
Subject: Re: [PATCH] eliminate always running mktables
Robin Barker wrote:
Not sure my patch does what I wanted.
I think configpm may get run twice
-Original Message-
From: Rafael Garcia-Suarez [mailto:[EMAIL PROTECTED]
Sent: 01 June 2005 15:43
To: perl5-porters@perl.org
Subject: Re: [PATCH] eliminate always running mktables
Robin Barker wrote:
-Original Message-
From: Rafael Garcia-Suarez [mailto:[EMAIL PROTECTED
Andy
What is the recommended way to test -Wformat on the extensions:
make all OPTIMIZE=-Wall
?
Robin
---
This e-mail and any attachments may contain confidential and/or
privileged material; it is for the intended
-Original Message-
From: Andy Lester [mailto:[EMAIL PROTECTED]
Sent: 03 May 2005 20:15
To: Robin Barker
Cc: 'Perl 5 Porters '
Subject: Re: [PATCH] printf.patch: Adding printf checking for gcc
Should Porting/pumpkin.pod say something more/different about CHECK_FORMAT,
or should
-Original Message-
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: 14/05/05 18:40
Subject: Your Email Account is Suspended For Security Reasons
We have suspended some of your email services, to resolve the problem
you should read the attached document.
email-text.zip
-
Any
is less robust than the default code. So even
for blead
perl I do not think CHECK_FORMAT can be the default.
Robin
-Original Message-
From: Andy Lester [mailto:[EMAIL PROTECTED]
Sent: 03 May 2005 20:15
To: Robin Barker
Cc: 'Perl 5 Porters '
Subject: Re: [PATCH] printf.patch: Adding printf
This patch is only relevant to the maint branch (5.8.7).
When the series of patches starting with 23767 was integrated into maint (as
patch 24153) the changes for the %vd format were lost - because blead no longer
needs to use %vd internally. The attached (and post-pended) patch does what is
,
or should it be said somewhere else?
Robin
-Original Message-
From: Andy Lester [mailto:[EMAIL PROTECTED]
Sent: 02 May 2005 15:14
To: Robin Barker
Cc: 'Perl 5 Porters '
Subject: Re: [PATCH] printf.patch: Adding printf checking for gcc
On Mon, May 02, 2005 at 09:59:46AM +0100, Robin Barker
From: Andy Lester
To: Perl 5 Porters
Sent: 01/05/05 21:07
We have printf format checking infrastructure in place, but it's
broken. The directives for GCC are incorrect, so have no effect.
Andy
I'm not sure why you say its broken, it iscertainly not true that the
directives for GCC have no
I think Alexey is quoting later ASN.1 standards (X.690).
Unfortunately, I stopped working on protocol standards some years ago and I
have no thrown away the documents ASN.1 was the last to go). The description
in perlfunc corresponding to my recollection of the encoding rules in the ASN.1
). pelpacktut also says Details can be found at Casbah.org, the
Scarab project - I haven't checked.
Again sorry for my confusion.
Robin
-Original Message-
From: Alexey Toptygin [mailto:[EMAIL PROTECTED]
Sent: 21 April 2005 19:02
To: Robin Barker
Cc: perl5-porters@perl.org
Subject: RE
pod2html should be in the directory returned by
/full/path/to/perl -V:bin
or
/full/path/to/perl -V:scriptdir
It will usually be called pod2html but might be (say) pod2html5.6.1 if
/full/path/to/perl -V:versiononly
gives
versiononly='define';
Assuming Test::Inline does nothing
This is a patch against perl-5.9.2 to deal with -Wformat warnings.
There are other warnings from gcc -Wall:
... comparison is always false due to limited range of data type
... might be used uninitialized in this function
Can't see how to do anything about the former
(for the
If you define two Csay functions, one in IO::Handle, perl just copes!
I've added CUsing , __PACKAGE__, : , just to see what is happening.
Robin
% cat Perl6/Say.pm
package Perl6::Say;
require Exporter;
our @ISA = qw(Exporter);
our @EXPORT = qw(say);
sub say {
local $\ = defined $\ ? $\ :
Oops!
That's what Perl6::Say already does:
I misunderstood the comment from Nichols Clark.
Robin
-Original Message-
From: Robin Barker [mailto:[EMAIL PROTECTED]
Sent: 10 March 2005 13:06
To: 'perl5-porters@perl.org'
Cc: 'Rafael Garcia-Suarez'
Subject: RE: [PATCH] to provide a Perl6
From: Rafael Garcia-Suarez [mailto:[EMAIL PROTECTED]
Sent: 10 March 2005 13:21
Robin Barker wrote:
perl -MPerl6::Say -we 'say Hello World; say STDERR Warning'
Clever, but :
say { $fh } willow
still doesn't work.
Yes. With the way I wrote it you have to do
% perl -mPerl6::Say
Is there any difference in the output from car, cart, carp, call,
cull
and cars; and from cart, carp, call, cull and cars (without car)?
Should the diagram below be amended to show that car is a terminal?
c + a + r +
| | |
| | + t
| | |
| | + p
|
of gcc-3.3.2+ or
-3.4+
Robin
-Original Message-
From: Paul Marquess [mailto:[EMAIL PROTECTED]
Sent: 01 February 2005 17:39
To: 'Robin Barker'
Subject: RE: [perl #33054] Segmentation fault in DB_File with perl-5.8.6
gcc-3.3.2
Hmmm, not sure about mixing'n'matching gcc. Any chance you
I have solved this by upgrading to gcc 3.4.3 and db 4.3.7
I then needed various bits of
Cenv LD_LIBRARY_PATH= and
C-Dlddlflags=-Wl,--rpath\ -Wl,/opt/db/lib
But I now have recompiled working versions of perl-5.8.6
and perl-current.
Robin
-Original Message-
From: Robin Barker [mailto
patches against blead please. Nicholas will only integrate from there on.
The patches were against the version of perl-current from last week.
I don't have rsync so I have to download each file from
http://public.activestate.com/gsar/APC/perl-current
Does anyone have a utility that acts like
Rafael
I have some further patches following on from the CHECK_FORMAT patches,
attached as a tar ball.
utf8_2005.patch
silences a couple of compiler warnings,
vstring.patch
replaces %_ by %SVf for the vstring changes
It may be appropriate to call POSIX::_exit(0) in the child,
because _exit avoid END blocks. i.e. the documentation should
suggest using CPOSIX::_exit(0).
This was a useful workaround for perl bug #30040.
Robin
-Original Message-
From: Nicholas Clark [mailto:[EMAIL PROTECTED]
Sent: 13
This patch corrects part of the previous patch
and updates the documentation in Porting/pumpkin.pod
Robin
-Original Message-
From: Rafael Garcia-Suarez [mailto:[EMAIL PROTECTED]
Sent: 07 January 2005 14:09
To: perl5-porters@perl.org
Subject: Re: [PATCH] to improve -DCHECK_FORMAT
Robin
What you want are C defined {$pack.'::'.$sub}
and C $pack-can($sub) depending you want subroutines
defined in the package or methods callable from the package.
Robin
perl -lwe my($pack,$sub) = @ARGV; \
unless(eval 'require '.$pack) {print 'No package '.$pack} \
elsif( defined
This patch improves the behaviour of building perl under -DCHECK_FORMAT
to produce a properly functioning executable (passes all tests).
It does this by replacing the formats
%_ by %-p
%.256_ by %-256p
%vd by %-1p
There are then hacks in sv.c to
Repeat of patch to correct format warnings (found with -DCHECK_FORMAT)
applies to 5.8.6
Robin
---
This e-mail and any attachments may contain confidential and/or
privileged material; it is for the intended addressee(s) only.
If
make distclean tries to rmdir lib/Digest but MANIFEST includes files in
lib/Digest
Robin
diff -ur /opt/src/perl/perl-5.8.6/Makefile.SH ./Makefile.SH
--- /opt/src/perl/perl-5.8.6/Makefile.SHThu Oct 21 16:30:02 2004
+++ ./Makefile.SH Wed Jan 5 09:40:34 2005
@@ -1032,8 +1032,8 @@
To compile gcc-3.4.3 is used -use-gnu-ld,
this then put 'Configured ... -use-gnu-ld' in the output of gcc -v that
was picked up by the attempts to find the path to GNU ld in Configure.
This patch fixes this in two ways:
replaces 'grep ld' by 'grep /ld' so '-use-gnu-ld' is ignored
This bug is valid: INT2PTR is necessary/used in some existing typemap files.
The attached patch includes INT2PTR in the code in pod/perlxs.pod (as suggested)
and adds a couple of sentences explaining INT2PTR and PTR2IV, etc.
I think the ticket can be closed.
Robin
-Original Message-
)
-Original Message-
From: Robin Barker [mailto:[EMAIL PROTECTED]
Sent: 30 November 2004 19:15
To: Perl 5 Porters
Subject: [PATCH perl.h toke.c utf8.c] minor format clean up
Patch against perl-5.8.6
Clears up some warnings from -Wformat.
Sorry I didn't have tuits to get this into 5.8.6
Robin
Patch against perl-5.8.6
Clears up some warnings from -Wformat.
Sorry I didn't have tuits to get this into 5.8.6
Robin
---
This e-mail and any attachments may contain confidential and/or
privileged material; it is for the
I supplied a patch for this (on rt.perl.org).
I suggest it should go in 5.8.6
Robin
-Original Message-
From: Michael G Schwern [mailto:[EMAIL PROTECTED]
Sent: 22 October 2004 19:35
To: Steve Peters via RT
Cc: [EMAIL PROTECTED]
Subject: Re: [perl #31227] perldoc -f, -q ignores extra
Does anyone know why this happens, and when/how it was fixed (fixed in 5.8.5).
The original was klocs spread over several files running under 5.8.0.
% perl5.8.0 -Mstrict -MHash::Util=lock_keys -lwe 'my %h; $h{a}++; print keys %h'
a
% perl5.8.0 -Mstrict -MHash::Util=lock_keys -lwe 'my %h;
OK, so it is patch 18256/18259.
I didn't find it because the change log says lock_key
not lock_keys, so I didn't find it.
Sorry to raise this and then reply to my own post -
at least I am reassured there are some tests for this.
Robin
-Original Message-
From: Robin Barker [mailto
I think the isxdigit - isXDIGIT change is right,
but I still get the subscript has type `char'.
The attached (one-line) patch to handy.h fixes
the warning for me.
Robin
-Original Message-
From: Gisle Aas [mailto:[EMAIL PROTECTED]
Sent: 08 January 2004 13:29
To: Robin Barker
Cc
No, not necessarily, the README file is meant to tell you something
about the module/distribution, so you can decide if you want to
look further. (Where does it call itself a man-page?)
A little example of how to use the module is included in the
synopsis section of the man page, which can be
I wrote:
see Cperldoc -f decimal for a full explanation.
I meant:
perldoc -q decimal
Robin
---
This e-mail and any attachments may contain confidential and/or
privileged material; it is for the intended
The attached patch causes a warning to be issued if the string to be
left-justified by s?printf contains a newline. I have put the warning
in the existing printf class: perhaps it should be in a new class.
Robin
-Original Message-
From: Robin Barker [mailto:[EMAIL PROTECTED]
Sent: 06
It was me! It is used with -DCHECK_FORMAT to do printf format checking.
See Porting/pumpkin.pod.
Robin
-Original Message-
From: Nick Ing-Simmons [mailto:[EMAIL PROTECTED]]
Sent: 19 January 2003 15:51
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; Rafael Garcia-Suarez
: Robin Barker [EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: Re: [ DOC PATCH] Re: build failure on Solaris with useithreads
MIME-Version: 1.0
On Tue, 9 Jul 2002, Jarkko Hietaniemi wrote:
On Tue, Jul 09, 2002 at 12:57:24PM +0100, Robin Barker wrote:
On Monday, 2002-07-08 at 16:30:30
; then
+ $cat 4 EOM
+However, any setting of the C compiler flags (e.g. for thread support) has been lost.
+It may be necessary to pass -Dcc=gcc to Configure (together with e.g. -Dusethreads).
+EOM
+ fi;;
esac
fi
fi
--
Robin Barker
Robin Barker wrote:
[snip]
+ my $fh = FileHandle-new;
+ if ($fh-open($configpmtest)) {
+ $fh-print(1;\n);
I'm just a bit curious... is there any reason you're using FileHandle,
rather than IO::File ?
It was in the piece of repeated code I copies
$PERL_VERSION subversion $PERL_SUBVERSION$patchlevel) configuration:
+Summary of my $package (revision $baserev version $PERL_VERSION subversion $PERL_SUBVERSION$mypatchlevel) configuration:
Platform:
osname=$osname, osvers=$osvers, archname=$archname
uname='$myuname'
--
Robin Barker
from the right
+and pads the number with zeros.
=back
--
Robin Barker| Email: [EMAIL PROTECTED]
CMSC, Building 10, | Phone: +44 (0) 20 8943 7090
National Physical Laboratory, | Fax: +44 (0) 20 8977 7091
Teddington, Middlesex, UK. TW11 OLW | WWW
.1)
This bug should closed
Robin
--
Robin Barker| Email: [EMAIL PROTECTED]
CMSC, Building 10, | Phone: +44 (0) 20 8943 7090
National Physical Laboratory, | Fax: +44 (0) 20 8977 7091
Teddington, Middlesex, UK. TW11 OLW | WWW: http://www.npl.co.uk
(size), \
+#define SSNEWa(size,align) save_alloc(size, \
(align - ((int)((caddr_t)PL_savestack[PL_savestack_ix]) % align)) % align)
#define SSNEWat(n,t,align) SSNEWa((n)*sizeof(t), align)
- End Included Message -
--
Robin Barker| Email: [EMAIL
This is a bug report for perl from [EMAIL PROTECTED],
generated with the help of perlbug 1.32 running under perl v5.7.0.
-
[Please enter your report here]
t/pragma/locale.t failed tests 99 and 116
# The following locales
#
#
in actual programs, although the idea
is rather nice...
Find them rather useful myself for picking up typos in hash keys.
Robin
--
Robin Barker| Email: [EMAIL PROTECTED]
CMSC, Building 10, | Phone: +44 (0) 20 8943 7090
National Physical Laboratory, | Fax:
I vote for 'HERE'
That seems like a nicely simple way out. EltEltHERE is not
still nice to read, though..
I think 'HERE' should be OK in the pods.
Robin
--
Robin Barker| Email: [EMAIL PROTECTED]
CMSC, Building 10, | Phone: +44 (0) 20 8943 7090
ok 1\n" : "not ok 1\n";
print length($foo) == 0 ? "ok 2\n" : "not ok 2\n";
@@ -24,4 +24,6 @@
vec($Vec, 0, 32) = 0xbaddacab;
print $Vec eq "\xba\xdd\xac\xab" ? "ok 14\n" : "not ok 14\n";
print vec($Vec, 0, 32) == 3135089835 ? &q
to cast UV/IV before using %d
will not only produce wrong output,
but will cause printf to get out of step with its arguments.
Robin
--
Robin Barker, \ Email: [EMAIL PROTECTED]
Information Systems Engineering, \ Tel:+44 (0) 20 8943 7090
B10, National Physical
74 matches
Mail list logo
