Re: (in blead) a missing const in a prototype

2005-04-28 Thread Andy Lester
On Thu, Apr 28, 2005 at 08:52:06AM +0300, [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: If PADOFFSET was a pointer, it would be different. All true. But now if the declaration has const but the proto doesn't, compilers will whine. (E.g. Visual C does.) Oof, I didn't know. gcc doesn't

RE: (in blead) a missing const in a prototype

2005-04-28 Thread jarkko.hietaniemi
-Original Message- From: ext Andy Lester [mailto:[EMAIL PROTECTED] Sent: 28 April, 2005 17:29 To: Hietaniemi Jarkko (Nokia-NVO/Helsinki) Cc: perl5-porters@perl.org Subject: Re: (in blead) a missing const in a prototype On Thu, Apr 28, 2005 at 08:52:06AM +0300, [EMAIL

Re: (in blead) a missing const in a prototype

2005-04-28 Thread Steve Hay
[EMAIL PROTECTED] wrote: In general, I wouldn't trust gcc to tell that much, even with -Wall. The -Wall does *not* mean all the warnings. Gcc 3.x and 4.x are getting better at whining, though. Especially naughty gcc is at silently enabling gcc-specific extensions, and not warning about their

Re: (in blead) a missing const in a prototype

2005-04-28 Thread H.Merijn Brand
On Thu, 28 Apr 2005 16:49:02 +0100, Steve Hay [EMAIL PROTECTED] wrote: [...] -Wdeclaration-after-statement Assuming that one does what it sounds like it does, that would be a good one for Perl to use generally. Declarations after statements are something that VC++ doesn't allow but

Re: (in blead) a missing const in a prototype

2005-04-28 Thread Steve Peters
On Thu, Apr 28, 2005 at 05:48:54PM +0300, [EMAIL PROTECTED] wrote: -Original Message- From: ext Andy Lester [mailto:[EMAIL PROTECTED] Sent: 28 April, 2005 17:29 To: Hietaniemi Jarkko (Nokia-NVO/Helsinki) Cc: perl5-porters@perl.org Subject: Re: (in blead) a missing const

Re: (in blead) a missing const in a prototype

2005-04-28 Thread Steve Hay
H.Merijn Brand wrote: On Thu, 28 Apr 2005 16:49:02 +0100, Steve Hay [EMAIL PROTECTED] wrote: [...] -Wdeclaration-after-statement Assuming that one does what it sounds like it does, that would be a good one for Perl to use generally. Declarations after statements are something

Re: (in blead) a missing const in a prototype

2005-04-28 Thread Andy Lester
On Thu, Apr 28, 2005 at 05:48:54PM +0300, [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: In general, I wouldn't trust gcc to tell that much, even with -Wall. The -Wall does *not* mean all the warnings. Gcc 3.x and 4.x are getting better at whining, though. Especially naughty gcc is at silently

Re: (in blead) a missing const in a prototype

2005-04-28 Thread Steve Hay
[EMAIL PROTECTED] wrote: I think the pad_compname_type in embed.fnc should be p |HV*|pad_compname_type|const PADOFFSET po to match pad.c Thanks, applied as change #24350. (My VC++ was whining too.) - Steve Radan Computational Ltd.

Re: (in blead) a missing const in a prototype

2005-04-28 Thread Ton Hospel
In article [EMAIL PROTECTED], [EMAIL PROTECTED] writes: -Waggregate-return -Wbad-function-cast -Wcast-align -Wcast-qual -Wconversion -Wdeclaration-after-statement -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wsign-compare -Wstrict-prototypes

Re: (in blead) a missing const in a prototype

2005-04-27 Thread Andy Lester
On Wed, Apr 27, 2005 at 05:35:27PM +0300, [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: I think the pad_compname_type in embed.fnc should be p |HV*|pad_compname_type|const PADOFFSET po to match pad.c's Perl_pad_compname_type(pTHX_ const PADOFFSET po) Sorry, I changed that but