Re: [PATCH] Refactoring to Sv*_set() macros - patch #5

2005-04-19 Thread Dave Mitchell
On Tue, Apr 19, 2005 at 05:16:31AM +, Ton Hospel wrote: In article [EMAIL PROTECTED], Steve Peters [EMAIL PROTECTED] writes: char *start = SvPVX(sv) + SvCUR(sv); - SvCUR(sv) += n; + SvCUR_set(sv, SvCUR(sv) + n); start[n] = '\0'; Aren't things like

Re: [PATCH] Refactoring to Sv*_set() macros - patch #5

2005-04-19 Thread Nicholas Clark
On Mon, Apr 18, 2005 at 07:09:25PM -0500, Steve Peters wrote: My cruel taskmaster reminded me that SvRV(), SvSTASH(), SvMAGIC(), SvLEN(), SvCUR(), and SvEND() all needed to changed as well. So, I'm taking care of all of them all in one patch. Well, you did volunteer. :-) Amongst the

Re: [PATCH] Refactoring to Sv*_set() macros - patch #5

2005-04-19 Thread John Peacock
Nicholas Clark wrote: --- lib/List/Util.pm.orig Sat May 22 03:02:24 2004 +++ lib/List/Util.pmMon Apr 18 18:26:54 2005 @@ -10,7 +10,7 @@ @ISA= qw(Exporter); @EXPORT_OK = qw(first min max minstr maxstr reduce sum shuffle); -$VERSION= 1.14; +$VERSION= 1.14_01; $XS_VERSION =

Re: [PATCH] Refactoring to Sv*_set() macros - patch #5

2005-04-19 Thread Steve Peters
On Tue, Apr 19, 2005 at 06:34:43AM -0400, John Peacock wrote: Nicholas Clark wrote: --- lib/List/Util.pm.orig Sat May 22 03:02:24 2004 +++ lib/List/Util.pmMon Apr 18 18:26:54 2005 @@ -10,7 +10,7 @@ @ISA= qw(Exporter); @EXPORT_OK = qw(first min max minstr maxstr reduce

[PATCH] Refactoring to Sv*_set() macros - patch #5

2005-04-18 Thread Steve Peters
My cruel taskmaster reminded me that SvRV(), SvSTASH(), SvMAGIC(), SvLEN(), SvCUR(), and SvEND() all needed to changed as well. So, I'm taking care of all of them all in one patch. Amongst the highlights of this patch... * new SvRV_set(), SvSTASH_set(), and SvMAGIC_set() macros in sv.h * new

Re: [PATCH] Refactoring to Sv*_set() macros - patch #5

2005-04-18 Thread Ton Hospel
In article [EMAIL PROTECTED], Steve Peters [EMAIL PROTECTED] writes: char *start = SvPVX(sv) + SvCUR(sv); - SvCUR(sv) += n; + SvCUR_set(sv, SvCUR(sv) + n); start[n] = '\0'; Aren't things like this a loss ? Now the SvANY(sv) lookup needs to happen