Re: [perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-11 Thread Elizabeth Mattijsen via RT
Fixed with 3c9cfdba88287e23e0ced8 (and further refined by later commits), tests needed. > On 6 Sep 2017, at 15:38, jn...@jnthn.net via RT > wrote: > > On Tue, 05 Sep 2017 09:11:19 -0700, allber...@gmail.com wrote: >> On Tue, Sep 5, 2017 at 5:40 AM,

Re: [perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-11 Thread Elizabeth Mattijsen
Fixed with 3c9cfdba88287e23e0ced8 (and further refined by later commits), tests needed. > On 6 Sep 2017, at 15:38, jn...@jnthn.net via RT > wrote: > > On Tue, 05 Sep 2017 09:11:19 -0700, allber...@gmail.com wrote: >> On Tue, Sep 5, 2017 at 5:40 AM,

Re: [perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-06 Thread Elizabeth Mattijsen via RT
> On 6 Sep 2017, at 15:38, jn...@jnthn.net via RT > wrote: > To recap the IRC discussion yesterday: no, we haven't had this so far (except > for stdout/stderr), and have gotten away with it due to the lack of output > buffering. At present, we can either choose

Re: [perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-06 Thread Elizabeth Mattijsen
> On 6 Sep 2017, at 15:38, jn...@jnthn.net via RT > wrote: > To recap the IRC discussion yesterday: no, we haven't had this so far (except > for stdout/stderr), and have gotten away with it due to the lack of output > buffering. At present, we can either choose

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-06 Thread jn...@jnthn.net via RT
On Tue, 05 Sep 2017 09:11:19 -0700, allber...@gmail.com wrote: > On Tue, Sep 5, 2017 at 5:40 AM, jn...@jnthn.net via RT < > perl6-bugs-follo...@perl.org> wrote: > > > Failing to close output handles has been clearly documented (and yes, > > documented well before the recent buffering change) as

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-06 Thread jn...@jnthn.net via RT
On Tue, 05 Sep 2017 09:11:19 -0700, allber...@gmail.com wrote: > On Tue, Sep 5, 2017 at 5:40 AM, jn...@jnthn.net via RT < > perl6-bugs-follo...@perl.org> wrote: > > > Failing to close output handles has been clearly documented (and yes, > > documented well before the recent buffering change) as

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread Aleks-Daniel Jakimenko-Aleksejev via RT
“Will leave this ticket open a little longer for further comments/discussion, but my intention is to reject it.” Nope, that's not exactly a good sounding plan. We'll run toaster and fix all modules that require fixing (or create appropriate issues if fixing something turns out to be too hard).

Re: [perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread Brandon Allbery via RT
On Tue, Sep 5, 2017 at 5:40 AM, jn...@jnthn.net via RT < perl6-bugs-follo...@perl.org> wrote: > Failing to close output handles has been clearly documented (and yes, > documented well before the recent buffering change) as something that can > cause data loss. Default output buffering just makes

Re: [perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread Brandon Allbery
On Tue, Sep 5, 2017 at 5:40 AM, jn...@jnthn.net via RT < perl6-bugs-follo...@perl.org> wrote: > Failing to close output handles has been clearly documented (and yes, > documented well before the recent buffering change) as something that can > cause data loss. Default output buffering just makes

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread jn...@jnthn.net via RT
On Tue, 05 Sep 2017 05:29:00 -0700, 1parr...@gmail.com wrote: > Perl 5 programmers are used to being casual about closing file > handles. Obviously, 6 requires a change of habits. A cultural shift, > if that's not too pretentious a term. Perhaps it needs to be mentioned > in large, friendly

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread jn...@jnthn.net via RT
On Tue, 05 Sep 2017 05:29:00 -0700, 1parr...@gmail.com wrote: > Perl 5 programmers are used to being casual about closing file > handles. Obviously, 6 requires a change of habits. A cultural shift, > if that's not too pretentious a term. Perhaps it needs to be mentioned > in large, friendly

Re: [perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread Parrot Raiser via RT
Perl 5 programmers are used to being casual about closing file handles. Obviously, 6 requires a change of habits. A cultural shift, if that's not too pretentious a term. Perhaps it needs to be mentioned in large, friendly letters somewhere in the documentation? On 9/5/17, jn...@jnthn.net via RT

Re: [perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread Parrot Raiser
Perl 5 programmers are used to being casual about closing file handles. Obviously, 6 requires a change of habits. A cultural shift, if that's not too pretentious a term. Perhaps it needs to be mentioned in large, friendly letters somewhere in the documentation? On 9/5/17, jn...@jnthn.net via RT

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread jn...@jnthn.net via RT
On Tue, 05 Sep 2017 00:54:27 -0700, alex.jakime...@gmail.com wrote: > <[Tux]> CSV tests started to fail > <[Tux]> # at t/90_csv.t line 260 > <[Tux]> # expected: $[["1", "2", "3"], ["2", "a b", ""]] > <[Tux]> # got: $[["1", "2", "3"],] > <[Tux]> # Failed test 'AOH parse out' > > > Bisectable

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread jn...@jnthn.net via RT
On Tue, 05 Sep 2017 00:54:27 -0700, alex.jakime...@gmail.com wrote: > <[Tux]> CSV tests started to fail > <[Tux]> # at t/90_csv.t line 260 > <[Tux]> # expected: $[["1", "2", "3"], ["2", "a b", ""]] > <[Tux]> # got: $[["1", "2", "3"],] > <[Tux]> # Failed test 'AOH parse out' > > > Bisectable

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread Aleks-Daniel Jakimenko-Aleksejev via RT
The issue is likely in Text::CSV so it's not fully a rakudo bug. However, we probably have a bunch of broken modules in the ecosystem because of this. I guess we need a Toaster report and a bunch of PRs for missing .close calls to fix everything… On 2017-09-05 00:54:27, alex.jakime...@gmail.com

[perl #132030] [REGRESSION] Broken Text::CSV tests and possibly other ecosystem fallout

2017-09-05 Thread via RT
# New Ticket Created by Aleks-Daniel Jakimenko-Aleksejev # Please include the string: [perl #132030] # in the subject line of all future correspondence about this issue. # https://rt.perl.org/Ticket/Display.html?id=132030 > <[Tux]> CSV tests started to fail <[Tux]> # at t/90_csv.t line 260