[perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-16 Thread James Keenan via RT
On Fri Aug 15 18:33:59 2008, [EMAIL PROTECTED] wrote: And I, for one, find myself going to the Smolder site much more often than our 'official' site these days -- precisely because I can spot new test failures more quickly there and jump in with a quick fix. As I did just now: I

[perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread via RT
# New Ticket Created by Will Coleda # Please include the string: [perl #57942] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=57942 #not ok 1 - Line length ok # Failed test 'Line length ok' # at

Re: [perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread Geoffrey Broadwell
On Fri, 2008-08-15 at 07:00 -0700, Will Coleda wrote: #not ok 1 - Line length ok # Failed test 'Line length ok' # at t/codingstd/linelength.t line 80. # Lines longer than coding standard limit (100 columns) in 1 files: # /home/smoke/parrot/compilers/pirc/new/pirsymbol.c:256: 104 cols #

Re: [perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread Will Coleda
On Fri, Aug 15, 2008 at 11:44 AM, Geoffrey Broadwell [EMAIL PROTECTED] wrote: On Fri, 2008-08-15 at 07:00 -0700, Will Coleda wrote: #not ok 1 - Line length ok # Failed test 'Line length ok' # at t/codingstd/linelength.t line 80. # Lines longer than coding standard limit (100 columns) in 1

Re: [perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread Geoffrey Broadwell
On Fri, 2008-08-15 at 11:57 -0400, Will Coleda wrote: This causes -all- smolder reports to be marked as failures. Perhaps 'make codetest' or 'make codingstd_tests' should be an automated commit hurdle? Meaning, SVN won't allow the commit if those don't pass. Assuming we actually want

Re: [perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread Bob Rogers
From: Geoffrey Broadwell [EMAIL PROTECTED] Date: Fri, 15 Aug 2008 09:07:46 -0700 . . . It seems then that we have two remaining options: 1. Don't run codingstd as part of smolder. 2. Differentiate a codingstd failure and a real failure in smolder. . . . Seems to me

Re: [perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread chromatic
On Friday 15 August 2008 09:07:46 Geoffrey Broadwell wrote: It seems then that we have two remaining options: 1. Don't run codingstd as part of smolder. 2. Differentiate a codingstd failure and a real failure in smolder. Which one of these are you proposing? +1 to either. #1 seems

Re: [perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread jerry gay
On Fri, Aug 15, 2008 at 9:39 AM, Bob Rogers [EMAIL PROTECTED] wrote: From: Geoffrey Broadwell [EMAIL PROTECTED] Date: Fri, 15 Aug 2008 09:07:46 -0700 . . . It seems then that we have two remaining options: 1. Don't run codingstd as part of smolder. 2. Differentiate a

Re: [perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread Michael Peters
chromatic wrote: On Friday 15 August 2008 09:07:46 Geoffrey Broadwell wrote: 1. Don't run codingstd as part of smolder. +1 to either. #1 seems slightly easier (no changes to Smolder). Yeah, it would just need a change to the make smolder_test target, which currently just uses

[perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread Klaas-Jan Stol via RT
fixed in r30252.

[perl #57942] [BUG] Smolder failure [linelength, compilers/pirc]

2008-08-15 Thread James Keenan via RT
On Fri Aug 15 07:00:38 2008, coke wrote: #not ok 1 - Line length ok # Failed test 'Line length ok' # at t/codingstd/linelength.t line 80. # Lines longer than coding standard limit (100 columns) in 1 files: # /home/smoke/parrot/compilers/pirc/new/pirsymbol.c:256: 104 cols # Looks like you