[perl #131858] [REGRESSION] default $.nl-in on IO::Handle does not correctly work in subclasses
There's now a regression test in
https://github.com/perl6/roast/commit/a7af87465e0dc593f4e008d6dcfe077f1bbff0f1
Closing (but please take a look at that roast commit)
On 2018-03-11 13:11:21, jan-olof.hen...@bredband.net wrote:
> On Tue, 08 Aug 2017 04:19:24 -0700, elizabeth wrote:
> > reverted c63c57e9a823303e74c06 for now
> >
> > > On 8 Aug 2017, at 12:21, Zoffix Znet (via RT) > > follo...@perl.org> wrote:
> > >
> > > # New Ticket Created by Zoffix Znet
> > > # Please include the string: [perl #131858]
> > > # in the subject line of all future correspondence about this
> > > issue.
> > > # https://rt.perl.org/Ticket/Display.html?id=131858 >
> > >
> > >
> > > Currently, this causes breakage in IO::String
> > >
> > > zoffix@VirtualBox~$ perl6 -e 'class Z is IO::Handle { method x { dd
> > > $.nl-in } }.new.x;'
> > > $["\n"]
> > >
> > > zoffix@VirtualBox~$ perl6 -v
> > > This is Rakudo version 2017.07-138-ga91ad2d built on MoarVM version
> > > 2017.07-318-g604da4d
> > >
> > > Above, it should give the two-element array, with "\r\n" as another
> > > element.
> > >
> > > AlexDaniel bisected my original code[^1] to point to
> > > https://gist.github.com/Whateverable/b26f4103f5da0809e11749b50fdbabb4
> > > ¦c63c57e9a823^: «"hello,"» ¦c63c57e: «"hello,\r\nworld!\r\n"»
> > >
> > > I tried to golf it further, by taking all the relevant bits from
> > > IO::Handle into a custom class, but failed to reproduce the issue
> > > then.
> > >
> > > [1]
> > > https://gist.github.com/zoffixznet/0c2cbd7acaaf0d3b27d245ad2e2bc737
>
> It seems as if everything is still good after the revert
> ((2017-08-08)
>
https://github.com/rakudo/rakudo/commit/67455170ca50bb908f309b77e5ca579eaa21605c
> ),
> tests needed,
[perl #131858] [REGRESSION] default $.nl-in on IO::Handle does not correctly work in subclasses
On Tue, 08 Aug 2017 04:19:24 -0700, elizabeth wrote:
> reverted c63c57e9a823303e74c06 for now
>
> > On 8 Aug 2017, at 12:21, Zoffix Znet (via RT) > follo...@perl.org> wrote:
> >
> > # New Ticket Created by Zoffix Znet
> > # Please include the string: [perl #131858]
> > # in the subject line of all future correspondence about this issue.
> > # https://rt.perl.org/Ticket/Display.html?id=131858 >
> >
> >
> > Currently, this causes breakage in IO::String
> >
> > zoffix@VirtualBox~$ perl6 -e 'class Z is IO::Handle { method x { dd
> > $.nl-in } }.new.x;'
> > $["\n"]
> >
> > zoffix@VirtualBox~$ perl6 -v
> > This is Rakudo version 2017.07-138-ga91ad2d built on MoarVM version
> > 2017.07-318-g604da4d
> >
> > Above, it should give the two-element array, with "\r\n" as another
> > element.
> >
> > AlexDaniel bisected my original code[^1] to point to
> > https://gist.github.com/Whateverable/b26f4103f5da0809e11749b50fdbabb4
> > ¦c63c57e9a823^: «"hello,"» ¦c63c57e: «"hello,\r\nworld!\r\n"»
> >
> > I tried to golf it further, by taking all the relevant bits from
> > IO::Handle into a custom class, but failed to reproduce the issue
> > then.
> >
> > [1]
> > https://gist.github.com/zoffixznet/0c2cbd7acaaf0d3b27d245ad2e2bc737
It seems as if everything is still good after the revert
((2017-08-08)
https://github.com/rakudo/rakudo/commit/67455170ca50bb908f309b77e5ca579eaa21605c
),
tests needed,
Re: [perl #131858] [REGRESSION] default $.nl-in on IO::Handle does not correctly work in subclasses
reverted c63c57e9a823303e74c06 for now
> On 8 Aug 2017, at 12:21, Zoffix Znet (via RT)
> wrote:
>
> # New Ticket Created by Zoffix Znet
> # Please include the string: [perl #131858]
> # in the subject line of all future correspondence about this issue.
> # https://rt.perl.org/Ticket/Display.html?id=131858 >
>
>
> Currently, this causes breakage in IO::String
>
>zoffix@VirtualBox~$ perl6 -e 'class Z is IO::Handle { method x { dd
> $.nl-in } }.new.x;'
>
>
>$["\n"]
>
>zoffix@VirtualBox~$ perl6 -v
>This is Rakudo version 2017.07-138-ga91ad2d built on MoarVM version
> 2017.07-318-g604da4d
>
> Above, it should give the two-element array, with "\r\n" as another element.
>
> AlexDaniel bisected my original code[^1] to point to
> https://gist.github.com/Whateverable/b26f4103f5da0809e11749b50fdbabb4
> ¦c63c57e9a823^: «"hello,"» ¦c63c57e: «"hello,\r\nworld!\r\n"»
>
> I tried to golf it further, by taking all the relevant bits from IO::Handle
> into a custom class, but failed to reproduce the issue then.
>
> [1] https://gist.github.com/zoffixznet/0c2cbd7acaaf0d3b27d245ad2e2bc737
Re: [perl #131858] [REGRESSION] default $.nl-in on IO::Handle does not correctly work in subclasses
reverted c63c57e9a823303e74c06 for now
> On 8 Aug 2017, at 12:21, Zoffix Znet (via RT)
> wrote:
>
> # New Ticket Created by Zoffix Znet
> # Please include the string: [perl #131858]
> # in the subject line of all future correspondence about this issue.
> # https://rt.perl.org/Ticket/Display.html?id=131858 >
>
>
> Currently, this causes breakage in IO::String
>
>zoffix@VirtualBox~$ perl6 -e 'class Z is IO::Handle { method x { dd
> $.nl-in } }.new.x;'
>
>
>$["\n"]
>
>zoffix@VirtualBox~$ perl6 -v
>This is Rakudo version 2017.07-138-ga91ad2d built on MoarVM version
> 2017.07-318-g604da4d
>
> Above, it should give the two-element array, with "\r\n" as another element.
>
> AlexDaniel bisected my original code[^1] to point to
> https://gist.github.com/Whateverable/b26f4103f5da0809e11749b50fdbabb4
> ¦c63c57e9a823^: «"hello,"» ¦c63c57e: «"hello,\r\nworld!\r\n"»
>
> I tried to golf it further, by taking all the relevant bits from IO::Handle
> into a custom class, but failed to reproduce the issue then.
>
> [1] https://gist.github.com/zoffixznet/0c2cbd7acaaf0d3b27d245ad2e2bc737
[perl #131858] [REGRESSION] default $.nl-in on IO::Handle does not correctly work in subclasses
# New Ticket Created by Zoffix Znet
# Please include the string: [perl #131858]
# in the subject line of all future correspondence about this issue.
# https://rt.perl.org/Ticket/Display.html?id=131858 >
Currently, this causes breakage in IO::String
zoffix@VirtualBox~$ perl6 -e 'class Z is IO::Handle { method x { dd $.nl-in
} }.new.x;'
$["\n"]
zoffix@VirtualBox~$ perl6 -v
This is Rakudo version 2017.07-138-ga91ad2d built on MoarVM version
2017.07-318-g604da4d
Above, it should give the two-element array, with "\r\n" as another element.
AlexDaniel bisected my original code[^1] to point to
https://gist.github.com/Whateverable/b26f4103f5da0809e11749b50fdbabb4
¦c63c57e9a823^: «"hello,"» ¦c63c57e: «"hello,\r\nworld!\r\n"»
I tried to golf it further, by taking all the relevant bits from IO::Handle
into a custom class, but failed to reproduce the issue then.
[1] https://gist.github.com/zoffixznet/0c2cbd7acaaf0d3b27d245ad2e2bc737
