Re: [perl #41132] [BUG] Segfault in Parrot_call_sub_ret_int

2006-12-26 Thread Nikolay Ananiev
Nikolay Ananiev [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] forgot to attach the files. Attached in this message. The attached patch fixes the problem. The code is taken from Parrot_call_sub (which works). But I don't know why it was not applied to the other two function. Maybe

Re: [perl #41020] [PATCH] pmc2c.pl functionality extracted into separate package

2006-12-26 Thread James E Keenan
chromatic wrote: On Monday 25 December 2006 21:44, James Keenan via RT wrote: A few style comments here. Utils.pm unshift @{$allargsref-{include}}, ( ., $FindBin::Bin/../.., $FindBin::Bin/../../src/pmc/ ); Why no File::Spec here? There are certain ways in

Re: [perl #41020] [PATCH] pmc2c.pl functionality extracted into separate package

2006-12-26 Thread James E Keenan
James Keenan via RT wrote: On Sun Dec 03 14:08:31 2006, [EMAIL PROTECTED] wrote: The files attach refactor tools/build/pmc2c.pl, extracting most of its functionality into lib/ Parrot/Pmc2c/Utils.pm and provide 8 test files to be stored in t/tools/pmc2cutils/. These substitute for my

Re: [perl #41020] [PATCH] pmc2c.pl functionality extracted into separate package

2006-12-26 Thread James E Keenan
James Keenan via RT wrote: On Sun Dec 03 14:08:31 2006, [EMAIL PROTECTED] wrote: The files attach refactor tools/build/pmc2c.pl, extracting most of its functionality into lib/ Parrot/Pmc2c/Utils.pm and provide 8 test files to be stored in t/tools/pmc2cutils/. These substitute for my

Re:[PATCH] make pdump's output about debug segment more consistent

2006-12-26 Thread Lee Duhem
The attached patch of the first message have some no-ASCII characters, this patch fix that. Otherwise, there are same.

Re: [PATCH] make pdump's output about debug segment more consistent

2006-12-26 Thread Lee Duhem
Sorry, forget the patch... Index: src/packfile.c === --- src/packfile.c (revision 16268) +++ src/packfile.c (working copy) @@ -2187,7 +2187,7 @@ default_dump_header(interp, self); -PIO_printf(interp, mappings = [\n); +

[perl #41140] Re: [PATCH] make pdump's output about debug segment more consistent

2006-12-26 Thread Lee Duhem
# New Ticket Created by Lee Duhem # Please include the string: [perl #41140] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41140 Sorry, forget the patch... Index: src/packfile.c

[perl #41139] Re:[PATCH] make pdump's output about debug segment more consistent

2006-12-26 Thread Lee Duhem
# New Ticket Created by Lee Duhem # Please include the string: [perl #41139] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41139 The attached patch of the first message have some no-ASCII characters, this patch fix

Re: [PATCH] make pdump's output about debug segment more consistent

2006-12-26 Thread Jonathan Worthington
Lee Duhem wrote: The attached patch of the first message have some no-ASCII characters, this patch fix that. Otherwise, there are same. Thanks, applied in r16269 and closed the related RT ticket. Jonathan

Re: [perl #41132] [BUG] Segfault in Parrot_call_sub_ret_int

2006-12-26 Thread Jonathan Worthington
Jonathan Worthington wrote: I'd like to poke into this at bit deeper at the moment, Of course I meant, in the future. Oh, and it was r16270 that it went in as. Don't drink and patch! Jonathan

[perl #41020] [PATCH] pmc2c.pl functionality extracted into separate package

2006-12-26 Thread James Keenan via RT
On Mon Dec 25 22:14:18 2006, [EMAIL PROTECTED] wrote: A few style comments here. [snip] sub dump_vtable {     my $self    = shift;     my $file    = shift; Why two shifts here, when @_ goes unused through the rest of the method? Fixed in attached patch: Utils.pm. sub print_tree

Re: [perl #41132] [BUG] Segfault in Parrot_call_sub_ret_int

2006-12-26 Thread chromatic
On Tuesday 26 December 2006 14:35, Bob Rogers wrote: AFAICS, the old code failed because Parrot_switch_to_cs (which is what normally sets ctx-contants in a sub call) is not given a chance to run in this situation. Parrot_loadbc sets interp-code without doing any of the other

Re: [perl #41132] [BUG] Segfault in Parrot_call_sub_ret_int

2006-12-26 Thread Bob Rogers
From: chromatic [EMAIL PROTECTED] Date: Tue, 26 Dec 2006 16:26:03 -0800 On Tuesday 26 December 2006 14:35, Bob Rogers wrote: AFAICS, the old code failed because Parrot_switch_to_cs (which is what normally sets ctx-contants in a sub call) is not given a chance to run in this

[svn:parrot-pdd] r16271 - trunk/docs/pdds

2006-12-26 Thread rgrjr
Author: rgrjr Date: Tue Dec 26 22:15:08 2006 New Revision: 16271 Modified: trunk/docs/pdds/pdd13_bytecode.pod Log: Fix minor typos. Modified: trunk/docs/pdds/pdd13_bytecode.pod == ---